[PATCH] test: add known broken tests for python bindings in split configs

2021-10-25 Thread David Bremner
This reproduces the bug(s) reported in id:87h7d4wp6b@tethera.net --- test/T055-path-config.sh | 28 1 file changed, 28 insertions(+) diff --git a/test/T055-path-config.sh b/test/T055-path-config.sh index ef22e964..c06962e4 100755 --- a/test/T055-path-config.sh

Re: problem with message headers in python bindings

2021-10-25 Thread David Bremner
David Bremner writes: > On a host running Debian Stable with python 3.9.2, and notmuch 0.31.4, > both of the attached programs work fine. On my developement host running > notmuch 0.34, both segfault when trying to fetch the 'to' header. This > invokes a more complicated code path, which seems

problem with message headers in python bindings

2021-10-25 Thread David Bremner
On a host running Debian Stable with python 3.9.2, and notmuch 0.31.4, both of the attached programs work fine. On my developement host running notmuch 0.34, both segfault when trying to fetch the 'to' header. This invokes a more complicated code path, which seems to have broken sometime between

Re: [PATCH] fix(nmweb): replace deprecated method

2021-10-25 Thread David Bremner
Austin Ray writes: > Python 3.2 deprecated 'cgi.escape()' and Python 3.8 removed it[1][2]. > Its replacement is 'html.escape()'. > > [0] https://docs.python.org/3.7/library/cgi.html#cgi.escape > [1] https://docs.python.org/3/whatsnew/3.8.html#api-and-feature-removals > [2]

[PATCH] fix(nmweb): replace deprecated method

2021-10-25 Thread Austin Ray
Python 3.2 deprecated 'cgi.escape()' and Python 3.8 removed it[1][2]. Its replacement is 'html.escape()'. [0] https://docs.python.org/3.7/library/cgi.html#cgi.escape [1] https://docs.python.org/3/whatsnew/3.8.html#api-and-feature-removals [2] https://bugs.python.org/issue33843 Signed-off-by:

Re: [PATCH 2/2] test/new: replace use of gdb in vanishing file test

2021-10-25 Thread Tomi Ollila
On Sun, Oct 24 2021, David Bremner wrote: > Because the file to be removed has a predictable name, we can hard > code it in the generated shim. I am not sure about the message above -- the file name is as predictable as it was before -- and the shim code is created dynamically, with same amout

Re: [PATCH 1/2] test/count: replace use of gdb with a LD_PRELOAD shim

2021-10-25 Thread Tomi Ollila
On Sun, Oct 24 2021, David Bremner wrote: > There is a certain amount of boilerplate to pass the call on the > original function, so abstract it out as a C preprocessor macro, plus > some extra includes in notmuch-test.h Looks like good progress -- some comments... > --- > test/T060-count.sh

Re: notmuch-emacs: Add option to set -exclude=false in notmuch search/tree

2021-10-25 Thread David Bremner
Mohsin Kaleem writes: > > I suggest we add a new option `notmuch-search-exclude`, which is used to > set the default value of the exclude flag in both notmuch-search and > notmuch-tree mode, and also to add a new command `notmuch-toggle-exclude` > which toggles the value of

[PATCH 3/3] test: mark some tests as broken when run as root.

2021-10-25 Thread David Bremner
File permission errors e.g., are hard to trigger as root. --- test/T050-new.sh | 1 + test/T150-tagging.sh | 1 + test/test-lib.sh | 6 ++ 3 files changed, 8 insertions(+) diff --git a/test/T050-new.sh b/test/T050-new.sh index 5a03998b..c75021bc 100755 --- a/test/T050-new.sh +++

[PATCH 2/3] debian: add autopkgtests

2021-10-25 Thread David Bremner
We generate output to stderr for BROKEN tests, which are not failures, so tell the test runner not to fail because of output on stderr. --- debian/tests/control | 12 1 file changed, 12 insertions(+) create mode 100644 debian/tests/control diff --git a/debian/tests/control

[PATCH 1/3] WIP/test: support testing notmuch as installed

2021-10-25 Thread David Bremner
We put some effort into testing the built copy rather than some installed copy. On the other hand for people like packagers, testing the installed copy is also of interest. When NOTMUCH_TEST_INSTALLED is set to a nonempty value, tests do not require a built notmuch tree or running configure. One

WIP: Support testing notmuch as installed

2021-10-25 Thread David Bremner
The goal of the series is to support CI tests like Debian's autopkgtest that test packages as installed (as opposed to in the build tree). Most of the test suite works OK in the setting, although some things need built binaries. One important exception is the python bindings, which are not run

notmuch-emacs: Add option to set -exclude=false in notmuch search/tree

2021-10-25 Thread Mohsin Kaleem
At the moment we always use the default value of exclude in calls to notmuch search and notmuch tree. If any of the searched mail is tagged with somethinh that is excluded it isn't shown and if we'd like to check whether this is the case we have to do an exhaustive search over all of our hidden

Re: Clean up some warnings from makeinfo

2021-10-25 Thread David Bremner
David Bremner writes: > Recently (?) makeinfo started generating pages of warnings about the > sphinx generated texinfo. This series fixes those warnings related to > the use of explicit markup in definition lists. There are still some > warnings about "definfoenclose", which I suspect to be a