Re: Elisp error with recent master-branch Emacs

2021-12-05 Thread Joseph Mingrone
On Sun, 2021-12-05 at 08:26, David Bremner wrote: > David Bremner writes: >> Joseph Mingrone writes: >>> Hello, >>> When building the FreeBSD OS package for notmuch-emacs, we have begun to >>> see build errors recently that report >>> (error "Unknown button type `help-function'").

[PATCH] emacs/tree: fix docstrings for author faces

2021-12-05 Thread Kyle Meyer
The docstrings for notmuch-tree-match-author-face and notmuch-tree-no-match-author-face incorrectly match the docstring of notmuch-tree-match-date-face. --- emacs/notmuch-tree.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el

[PATCH] test/emacs: mark one test as fixed in newer emacs.

2021-12-05 Thread David Bremner
The remaining problem in this test is fixed upstream in Emacs 28. While most people are using earlier versions of emacs, the test still provides some documentation of a known bug. --- test/T450-emacs-show.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH] test: remove directory names from paths in exceptions

2021-12-05 Thread David Bremner
These cause failures when building out of tree. --- test/T562-lib-database.sh | 4 ++-- test/T563-lib-directory.sh | 4 ++-- test/test-lib.sh | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index

Re: [PATCH] python-cffi: fix out-of-tree build

2021-12-05 Thread David Bremner
David Bremner writes: > The main idea is to replace the hack of copying version.txt into the > bindings source with a generated _notmuch_config.py file. > > This will mean that the bindings only build after configuring and > building notmuch itself. Given those constraints, "pip install ." >

Re: Fix python exception object string repr

2021-12-05 Thread David Bremner
Floris Bruynooghe writes: > This fixes a bug in the exception class which would produce > unprintable exceptions because it was not converting an error > code correctly to a string. Applied to release and master. Apologies for the delay. d ___

Re: Strip spaces in `tags` in `~/.notmuch-config` (and other fields)

2021-12-05 Thread David Bremner
Ciprian Dorin Craciun writes: > > Given that the `~/.notmuch-config` resembles an INI file, and given > how lax the actual syntax is in general, I would suggest the > following: > > * allow white-spaces around `[ section ]`, and `field = value`; > * strip white-spaces (left and right) from values

Re: Notmuch Emacs 0.31.2 documentation and keybinding suggestions

2021-12-05 Thread David Bremner
"Jorge P. de Morais Neto" writes: > Hi. I would like to report the following documentation and keybinding > imperfections: > > The info page > [[info:notmuch-emacs.info#notmuch-hello key bindings]] says that > moves to the previous widget, but that key is actually bound > to

Re: problem with message headers in python bindings

2021-12-05 Thread David Bremner
David Bremner writes: > On a host running Debian Stable with python 3.9.2, and notmuch 0.31.4, > both of the attached programs work fine. On my developement host running > notmuch 0.34, both segfault when trying to fetch the 'to' header. This > invokes a more complicated code path, which seems

Re: Elisp error with recent master-branch Emacs

2021-12-05 Thread David Bremner
David Bremner writes: > Joseph Mingrone writes: > >> Hello, >> >> When building the FreeBSD OS package for notmuch-emacs, we have begun to >> see build errors recently that report >> >> (error "Unknown button type `help-function'"). >> >>