Re: [PATCH] bindings/python-cffi: add matched property to message objects

2022-01-01 Thread David Bremner
Floris Bruynooghe writes: > > LGTM applied to master. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: Python notmuch2 bridge, something changed in the Database constructor

2022-01-01 Thread Floris Bruynooghe
On Fri 24 Dec 2021 at 09:03 -0400, David Bremner wrote: > > @Floris: when I made the change to the Database constructor, I chose the > default as CONFIG.NONE because this matched the previous semantics > _except_ for finding the database path. But since I don't want to use > the ad hoc default_path

Re: [PATCH] bindings/python-cffi: add matched property to message objects

2022-01-01 Thread Floris Bruynooghe
On Sat 01 Jan 2022 at 10:42 -0400, David Bremner wrote: > Existing users of the legacy python bindings use > message.get_flags(Message.FLAG.MATCH) to determine which messages in a > thread matched. Since the bindings don't provide get_flags anymore, > they should provide a property analogous to th

[PATCH] bindings/python-cffi: add matched property to message objects

2022-01-01 Thread David Bremner
Existing users of the legacy python bindings use message.get_flags(Message.FLAG.MATCH) to determine which messages in a thread matched. Since the bindings don't provide get_flags anymore, they should provide a property analogous to the existing "excluded" property. --- bindings/python-cffi/notmuch

[PATCH] test: fix deprecation warning in symbol-test

2022-01-01 Thread David Bremner
Reduce the amount of noise in the build log. --- test/symbol-test.cc | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/symbol-test.cc b/test/symbol-test.cc index 9d73a571..9e956ddf 100644 --- a/test/symbol-test.cc +++ b/test/symbol-test.cc @@ -12,8 +12,10 @@ main (int

[PATCH 2/3] lib/config: add known config key "show.extra_headers"

2022-01-01 Thread David Bremner
Used in a following commit to enable including extra headers beyond the default in structured output. --- lib/config.cc | 3 +++ lib/notmuch.h | 1 + test/T590-libconfig.sh | 4 3 files changed, 8 insertions(+) diff --git a/lib/config.cc b/lib/config.cc index 7a2882de..9706

[PATCH 3/3] CLI: print extra headers in structured output

2022-01-01 Thread David Bremner
This is based on a patch from Johan Parin [1], which is in turn responding to a bug report / feature requiest from Jan Malkhovski. The update to the structured output documented in schemata is intended to be upward compatible, so the format version stays the same [1]: id:20191116162723.18343-1-jo

[PATCH 1/3] CLI: stash pointer to database in sprinter structs

2022-01-01 Thread David Bremner
We already use an allocated (and presumably open) database as a talloc context. Keeping the pointer in the allocated struct will allow us to e.g. interrogate the configuration in a sprinter function without threading the database all the way through the various levels of function. --- notmuch-clie

support extra headers in notmuch show v2

2022-01-01 Thread David Bremner
This is a respin of [1], that takes advantage of changes to the config system in the meantime and adds a couple tests. Like that patch, this only updates the CLI. There are some related changes to the emacs UI proposed in [2], but those would require adapting to work with these changes. In particul