Re: [PATCH] emacs: use query name for tree saved-search buffer names

On Sat, Jan 08 2022, jao wrote: > This simply mimics what we already do for non-tree searches, and makes > up for nicer buffer names. Note that this patch only applies to > queries not coming from a search widget in the hello buffer. sorry, i meant "queries *coming* from a search widget" __

Re: Notmuch-Company overrides other company backends?

Igor Sosa Mayor writes: > David Bremner writes: > >> Igor Sosa Mayor writes: >> I guess you mean that it overrides it in a buffer-local way, in notmuch-message-mode? Or do you see some kind of global overiding going on? d >>> >>> thanks for your reply. Yes, sorry f

[PATCH v2] bindings/python-cffi: search for config by default

The previous (pre-0.34.2) constructor searched for a config file but only if the database path was not specified, and only to retrieve database.path. Neither of the available options (CONFIG.SEARCH or CONFIG.NONE) matches this semantics exactly, but CONFIG.SEARCH causes less breakage for people who

Re: Notmuch-Company overrides other company backends?

David Bremner writes: > Igor Sosa Mayor writes: > >>> >>> I guess you mean that it overrides it in a buffer-local way, in >>> notmuch-message-mode? Or do you see some kind of global overiding going >>> on? >>> >>> d >> >> thanks for your reply. Yes, sorry for not being clear enough. I see in >>

[PATCH] emacs: use query name for tree saved-search buffer names

This simply mimics what we already do for non-tree searches, and makes up for nicer buffer names. Note that this patch only applies to queries not coming from a search widget in the hello buffer. Signed-off-by: jao --- emacs/notmuch-hello.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Notmuch-Company overrides other company backends?

Igor Sosa Mayor writes: >> >> I guess you mean that it overrides it in a buffer-local way, in >> notmuch-message-mode? Or do you see some kind of global overiding going >> on? >> >> d > > thanks for your reply. Yes, sorry for not being clear enough. I see in > the code > > (make-local-variable

Re: Notmuch-Company overrides other company backends?

David Bremner writes: > Igor Sosa Mayor writes: > >> Hi, >> >> as far as I see, notmuch-company overrides other company backends. Other >> is it maybe something with my configuration? >> >> If I look into company-backends I only see company-notmuch instead of >> my usual backends (ispell, dabbre

Re: [PATCH 2/2] python-cffi: returned OwnedMessage objects from Message.replies

On Sat 08 Jan 2022 at 10:03 -0400, David Bremner wrote: > If we return regular Message objects, python will try to destroy them, > and the underlying notmuch object, causing e.g. the crash [1]. > > [1]: id:87sfu6utxg@tethera.net > --- > bindings/python-cffi/notmuch2/_message.py | 4 ++-- > te

Re: [PATCH] bindings/python-cffi: search for config by default

On Sat 08 Jan 2022 at 12:19 -0400, David Bremner wrote: > The previous (pre-0.34.2) constructor searched for a config file but > only if the database path was not specified, and only to retrieve > database.path. Neither of the available options (CONFIG.SEARCH or > CONFIG.NONE) matches this semanti

Re: Notmuch-Company overrides other company backends?

Igor Sosa Mayor writes: > Hi, > > as far as I see, notmuch-company overrides other company backends. Other > is it maybe something with my configuration? > > If I look into company-backends I only see company-notmuch instead of > my usual backends (ispell, dabbrev, etc.). > > Any hints? > > Many

Notmuch-Company overrides other company backends?

Hi, as far as I see, notmuch-company overrides other company backends. Other is it maybe something with my configuration? If I look into company-backends I only see company-notmuch instead of my usual backends (ispell, dabbrev, etc.). Any hints? Many thanks in advance. Igor -- :: Igor Sosa

[PATCH 2/2] lib/database: delete stemmer on destroy

Commit 3202e0d1feba1ab955ba1c07098c00208f8f0ada left the stemmer object accessible, but did not add de-allocation code to notmuch_database_destroy. This commit corrects that oversight. --- lib/database.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/database.cc b/lib/database.cc index

[PATCH 1/2] lib/config: move g_key_File_get_string before continue

In [1] Austin Ray reported some memory leaks in notmuch_database_open. One of those leaks is caused by jumping to the next key without freeing val. This change avoids that leak. [1]: id:20220105224538.m36lnjn7rf3ieonc@athena --- lib/config.cc | 11 ++- 1 file changed, 6 insertions(+), 5 d

[PATCH] emacs: make header line in notmuch-show buffers optional

New notmuch-show-header-line customizable boolean to allow inhibiting a header line in notmuch-show-mode buffers (for instance, because one prefers to just include Subject in notmuch-message-headers). Signed-off-by: jao --- emacs/notmuch-show.el | 16 +++- 1 file changed, 11 insertio

[PATCH] bindings/python-cffi: search for config by default

The previous (pre-0.34.2) constructor searched for a config file but only if the database path was not specified, and only to retrieve database.path. Neither of the available options (CONFIG.SEARCH or CONFIG.NONE) matches this semantics exactly, but CONFIG.SEARCH causes less breakage for people who

[PATCH 2/2] python-cffi: returned OwnedMessage objects from Message.replies

If we return regular Message objects, python will try to destroy them, and the underlying notmuch object, causing e.g. the crash [1]. [1]: id:87sfu6utxg@tethera.net --- bindings/python-cffi/notmuch2/_message.py | 4 ++-- test/T392-python-cffi-notmuch.sh | 2 -- 2 files changed, 2 ins

[PATCH 1/2] test: add known broken tests for recursive traversal of replies.

This reproduces the bug reported at [1]. The second test hints at the solution, making reply return OwnedMessage objects. [1]: id:87sfu6utxg@tethera.net --- test/T392-python-cffi-notmuch.sh | 50 1 file changed, 50 insertions(+) create mode 100755 test/T392-p