Re: [PATCH 2/2] lib: thread-safe s-expression query parser

2023-07-22 Thread David Bremner
Kevin Boulain writes: > + > +inline Xapian::Query > +_sexp_initial_query (_sexp_initial_t initial) My first thought was that this should be static, but maybe it doesn't matter in C++; I see the other inline functions in that file are not declared static. > +} > +assert (!

Re: [PATCH 1/2] test: showcase thread-unsafe s-expression query parser

2023-07-22 Thread David Bremner
Kevin Boulain writes: > The test fails quite reliably for me: > T810-tsan: Testing run code with TSan enabled against the library >PASS create >PASS query >FAIL sexp query I can't get this test to fail at all. I'm not sure what to conclude from that. This is on a 20 core

Re: What to do about message/rfc822 attachments?

2023-07-22 Thread David Bremner
Andy Smith writes: > > What this means is that I see a message that looks like this: > > From: Joe Bloggs via somelist > Message-ID: > Subject: Joe's original subject > References: (from Joe's post) > In-Reply-To: (from Joe's post) > > That then contains a message/rfc822

Re: [PATCH] improve notmuch-hello layout

2023-07-22 Thread David Bremner
Rudolf Adamkovič writes: > --- > emacs/notmuch-hello.el | 22 +++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > index 3235f555..f245a7dd 100644 > --- a/emacs/notmuch-hello.el > +++

[PATCH] emacs/hello: refresh hello directly

2023-07-22 Thread David Bremner
According to the now deleted commentary, the hack of using run-at-time was needed for Emacs 24. It seems to be no longer needed for Emacs 28.2, and removing it makes further changes to the code simpler. --- emacs/notmuch-hello.el | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) I would

Re: [PATCH v4 4/5] test: support testing notmuch as installed

2023-07-22 Thread David Bremner
Tomi Ollila writes: >> fi >> >> +if [ -n "${LD_PRELOAD-}" ]; then > > Is it problem to chain LD_PRELOADs here ? I see later in this message > there is LD_PRELOAD's concatenated with :'s (in case non-empty) ? > It is not a problem in general, but ASAN insists on being first in LD_PRELOAD, so

Re: v4 test notmuch as installed

2023-07-22 Thread David Bremner
David Bremner writes: > This obsoletes the series at id:20230409142627.2216080-1-da...@tethera.net. > I have applied this series (with some fixes from Tomi) to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email

Re: [PATCH v4 4/5] test: support testing notmuch as installed

2023-07-22 Thread David Bremner
Tomi Ollila writes: >> -LD_PRELOAD=${LD_PRELOAD:+:$LD_PRELOAD}:./${shim_file} notmuch-shared >> "$@" >> +LD_PRELOAD=${LD_PRELOAD:+:$LD_PRELOAD}:./${shim_file} $notmuch_cmd "$@" > > hmm, should the "chaining" be done on other order (i.e. the shim_file > before anything if there... (that

Re: Speedup for deleting files

2023-07-22 Thread Tomi Ollila
On Thu, Jul 20 2023, David Bremner wrote: > Thanks to discussion with Olly Betts and some perf runs, I realized > the current clean up of deleted files from the database is somewhat > wasteful since it modifies the message documents (by deleting the > filename) before in most cases deleting the