[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

Hi David. Perhaps I am missing something here. But I do not get any warnings when building with GCC 4.6.2 with -Wall -Werror (-O2 and -O0). I do not like adding any complex hacks to make the build warning-free on old GCC versions. If this happens on the build bot, we should just update it or ig

[PATCH] emacs: put the last search on top of recent searches in notmuch-hello

Notmuch-hello stores a list of recent searches. Before the change, if a search from this list is repeated, the recent search list is not changed. The patch makes repeated recent searches move to the head of the list. I.e. the last search is always on top of the recent search list, which is what

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

On Wed, 21 Dec 2011 22:49:13 +0100, Thomas Jost wrote: > On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin gmail.com> wrote: > > Test that `notmuch-hello-refresh-hook' is called once when > > `notmuch-hello' is called and twice when calling > > `notmuch-hell

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

Hi David. Perhaps I am missing something here. But I do not get any warnings when building with GCC 4.6.2 with -Wall -Werror (-O2 and -O0). I do not like adding any complex hacks to make the build warning-free on old GCC versions. If this happens on the build bot, we should just update it or ig

[PATCH] test: add tests for `notmuch-hello-refresh-hook'

Hi Thomas. I think all hook count tests must be consistent. We should either add hook counters in test-lib.el (like it is already done for `notmuch-hello-mode-hook') or use lambdas in individual test cases (like you did in the patch). I believe the former approach is better (that is why I used i

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

Test that `notmuch-hello-refresh-hook' is called once when `notmuch-hello' is called and twice when calling `notmuch-hello-update' after that. The tests are very similar to tests for `notmuch-hello-mode-hook'. --- test/emacs | 19 +++ test/test-lib.el |1 + 2 files cha

[PATCH 1/2] test: add general Emacs hook counter

Replace `notmuch-hello-mode-hook-counter' with general `hook-counter' and `add-hook-counter' functions to allow counting calls for any hook. --- test/test-lib.el | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index

[PATCH 1/2] emacs: rename notmuch-decimal-separator to notmuch-hello-thousands-separator

Both patches look good to me. Thanks, Thomas! Regards, Dmitry

[PATCH] emacs: put the last search on top of recent searches in notmuch-hello

Notmuch-hello stores a list of recent searches. Before the change, if a search from this list is repeated, the recent search list is not changed. The patch makes repeated recent searches move to the head of the list. I.e. the last search is always on top of the recent search list, which is what

Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

On Wed, 21 Dec 2011 22:49:13 +0100, Thomas Jost wrote: > On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin > wrote: > > Test that `notmuch-hello-refresh-hook' is called once when > > `notmuch-hello' is called and twice when calling > > `notmuch-hello-upda

Re: [PATCH] test: add tests for `notmuch-hello-refresh-hook'

Hi Thomas. I think all hook count tests must be consistent. We should either add hook counters in test-lib.el (like it is already done for `notmuch-hello-mode-hook') or use lambdas in individual test cases (like you did in the patch). I believe the former approach is better (that is why I used i

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

Test that `notmuch-hello-refresh-hook' is called once when `notmuch-hello' is called and twice when calling `notmuch-hello-update' after that. The tests are very similar to tests for `notmuch-hello-mode-hook'. --- test/emacs | 19 +++ test/test-lib.el |1 + 2 files cha

[PATCH 1/2] test: add general Emacs hook counter

Replace `notmuch-hello-mode-hook-counter' with general `hook-counter' and `add-hook-counter' functions to allow counting calls for any hook. --- test/test-lib.el | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index

Re: [PATCH 1/2] emacs: rename notmuch-decimal-separator to notmuch-hello-thousands-separator

Both patches look good to me. Thanks, Thomas! Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

Hi Thomas. On Wed, 21 Dec 2011 01:30:48 +0100, Thomas Jost wrote: > On Fri, 16 Dec 2011 16:34:03 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner > > wrote: > > > On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kuro

[PATCH] emacs: add notmuch-hello-refresh-hook

Hi Thomas. Looks good to me. We should also add tests for this, similar to those for `notmuch-hello-mode-hook'. Thomas, do you think you can work on it? Regards, Dmitry

[PATCH] emacs: create patch filename from subject for inline patch fake parts

Hi Jani. On Tue, 20 Dec 2011 22:05:31 +0200, Jani Nikula wrote: > > Shameless promotion of own patches... I suppose not many use the > notmuch-wash-convert-inline-patch-to-part option, but with this patch > I've actually started to like it better. An actual patch name from > subject instead of "

Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

Hi Thomas. On Wed, 21 Dec 2011 01:30:48 +0100, Thomas Jost wrote: > On Fri, 16 Dec 2011 16:34:03 +0400, Dmitry Kurochkin > wrote: > > On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner wrote: > > > On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin > > > w

Re: [PATCH] emacs: add notmuch-hello-refresh-hook

Hi Thomas. Looks good to me. We should also add tests for this, similar to those for `notmuch-hello-mode-hook'. Thomas, do you think you can work on it? Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

Hi Jani. On Tue, 20 Dec 2011 22:05:31 +0200, Jani Nikula wrote: > > Shameless promotion of own patches... I suppose not many use the > notmuch-wash-convert-inline-patch-to-part option, but with this patch > I've actually started to like it better. An actual patch name from > subject instead of "

[PATCH 1/2] test/smtp-dummy: add --background option for going background after listen(2)

Hi Tomi. On Tue, 13 Dec 2011 11:01:22 +0200, Tomi Ollila wrote: > To avoid the possibility that smtp-dummy doesn't have chance to bind > its listening socket until something tries to send message to it this > option makes caller wait until socket is already listening for connections. > > In case

Re: [PATCH 1/2] test/smtp-dummy: add --background option for going background after listen(2)

Hi Tomi. On Tue, 13 Dec 2011 11:01:22 +0200, Tomi Ollila wrote: > To avoid the possibility that smtp-dummy doesn't have chance to bind > its listening socket until something tries to send message to it this > option makes caller wait until socket is already listening for connections. > > In case

Code Style Bikeshed 1/n: Break before Brace or Brace before Break?

On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila wrote: > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin gmail.com> wrote: > > +1 for the former. > > +1 > > > How about indenting with spaces+tabs vs indenting with spaces only? :) > > -1 -- tab-wid

Code Style Bikeshed 1/n: Break before Brace or Brace before Break?

+1 for the former. How about indenting with spaces+tabs vs indenting with spaces only? :) Regards, Dmitry

Re: Code Style Bikeshed 1/n: Break before Brace or Brace before Break?

On Sun, 18 Dec 2011 18:12:51 +0200, Tomi Ollila wrote: > On Sun, 18 Dec 2011 19:50:52 +0400, Dmitry Kurochkin > wrote: > > +1 for the former. > > +1 > > > How about indenting with spaces+tabs vs indenting with spaces only? :) > > -1 -- tab-width is 8, a

Re: Code Style Bikeshed 1/n: Break before Brace or Brace before Break?

+1 for the former. How about indenting with spaces+tabs vs indenting with spaces only? :) Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v4 4/4] emacs: do not call `notmuch-hello-mode' on update

`notmuch-hello' should call `notmuch-hello-mode' function only when run for the first time. But before the change, `notmuch-hello' used `kill-all-local-variables' to remove editable widgets fields. This caused the major mode to be reset, and `notmuch-hello-mode' to be called every time. The patc

[PATCH v4 3/4] test: add broken test for `notmuch-hello-mode-hook' called during update

Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken. --- test/emacs | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index a864ffa..b4c2444 100755 --- a/test/emacs +++ b/te

[PATCH v4 2/4] test: add test for `notmuch-hello-mode-hook'

Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called. --- test/emacs |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 6e922de..a864ffa 100755 --- a/test/emacs +++ b/test/emacs @@ -476,4 +476,13 @@ t

[PATCH v4 1/4] test: add `notmuch-hello-mode-hook-counter'

Add `notmuch-hello-mode-hook-counter' hook to count how many times `notmuch-hello-mode-hook' was called. The counter function increments `notmuch-hello-mode-hook-counter' variable value if it is bount, otherwise it does nothing. --- test/test-lib.el |9 + 1 files changed, 9 insertions

[PATCH v4 0/4] emacs: do not call `notmuch-hello-mode' on update

Changes: v4: * explain why we need to properly delete editable widget fields v3: * remove useless let with `widget-field-list', thanks Austin v2: * actually use `all' variable in `mapc' call, thanks Tomi

[PATCH v3 4/4] emacs: do not call `notmuch-hello-mode' on update

`notmuch-hello' should call `notmuch-hello-mode' function only when run for the first time. But before the change, `notmuch-hello' used `kill-all-local-variables' to remove editable widgets fields. This caused the major mode to be reset, and `notmuch-hello-mode' to be called every time. The patc

[PATCH v3 3/4] test: add broken test for `notmuch-hello-mode-hook' called during update

Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken. --- test/emacs | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index a864ffa..b4c2444 100755 --- a/test/emacs +++ b/te

[PATCH v3 2/4] test: add test for `notmuch-hello-mode-hook'

Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called. --- test/emacs |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 6e922de..a864ffa 100755 --- a/test/emacs +++ b/test/emacs @@ -476,4 +476,13 @@ t

[PATCH v3 1/4] test: add `notmuch-hello-mode-hook-counter'

Add `notmuch-hello-mode-hook-counter' hook to count how many times `notmuch-hello-mode-hook' was called. The counter function increments `notmuch-hello-mode-hook-counter' variable value if it is bount, otherwise it does nothing. --- test/test-lib.el |9 + 1 files changed, 9 insertions

[PATCH v3 0/4] emacs: do not call `notmuch-hello-mode' on update

Changes: v3: * remove useless let with `widget-field-list', thanks Austin v2: * actually use `all' variable in `mapc' call, thanks Tomi

[PATCH v2 4/4] emacs: do not call `notmuch-hello-mode' on update

`notmuch-hello' should call `notmuch-hello-mode' function only when run for the first time. But before the change, `notmuch-hello' used `kill-all-local-variables' to remove editable widgets fields. This caused the major mode to be reset, and `notmuch-hello-mode' to be called every time. The patc

[PATCH v2 3/4] test: add broken test for `notmuch-hello-mode-hook' called during update

Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken. --- test/emacs | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index a864ffa..b4c2444 100755 --- a/test/emacs +++ b/te

[PATCH v2 2/4] test: add test for `notmuch-hello-mode-hook'

Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called. --- test/emacs |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 6e922de..a864ffa 100755 --- a/test/emacs +++ b/test/emacs @@ -476,4 +476,13 @@ t

[PATCH v2 1/4] test: add `notmuch-hello-mode-hook-counter'

Add `notmuch-hello-mode-hook-counter' hook to count how many times `notmuch-hello-mode-hook' was called. The counter function increments `notmuch-hello-mode-hook-counter' variable value if it is bount, otherwise it does nothing. --- test/test-lib.el |9 + 1 files changed, 9 insertions

[PATCH v2 0/4] emacs: do not call `notmuch-hello-mode' on update

Changes in v2 since v1: * actually use `all' variable in `mapc' call, thanks Tomi Regards, Dmitry

[PATCH] [emacs] Add an argument to notmuch-mua-mail

Looks good to me. Regards, Dmitry

[PATCH] [emacs] Add an argument to notmuch-mua-mail

On Sat, 17 Dec 2011 05:41:28 -0500, Aaron Ecay wrote: > From the emacs changelog: > > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and > passes it to the mail user agent function. This argument specifies an > action for returning to the caller after finishing with the

[PATCH v4 4/4] emacs: do not call `notmuch-hello-mode' on update

`notmuch-hello' should call `notmuch-hello-mode' function only when run for the first time. But before the change, `notmuch-hello' used `kill-all-local-variables' to remove editable widgets fields. This caused the major mode to be reset, and `notmuch-hello-mode' to be called every time. The patc

[PATCH v4 3/4] test: add broken test for `notmuch-hello-mode-hook' called during update

Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken. --- test/emacs | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index a864ffa..b4c2444 100755 --- a/test/emacs +++ b/te

[PATCH v4 2/4] test: add test for `notmuch-hello-mode-hook'

Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called. --- test/emacs |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 6e922de..a864ffa 100755 --- a/test/emacs +++ b/test/emacs @@ -476,4 +476,13 @@ t

[PATCH v4 1/4] test: add `notmuch-hello-mode-hook-counter'

Add `notmuch-hello-mode-hook-counter' hook to count how many times `notmuch-hello-mode-hook' was called. The counter function increments `notmuch-hello-mode-hook-counter' variable value if it is bount, otherwise it does nothing. --- test/test-lib.el |9 + 1 files changed, 9 insertions

[PATCH v4 0/4] emacs: do not call `notmuch-hello-mode' on update

Changes: v4: * explain why we need to properly delete editable widget fields v3: * remove useless let with `widget-field-list', thanks Austin v2: * actually use `all' variable in `mapc' call, thanks Tomi ___ notmuch mailing list notmuch@notmuchmail

[PATCH v3 4/4] emacs: do not call `notmuch-hello-mode' on update

`notmuch-hello' should call `notmuch-hello-mode' function only when run for the first time. But before the change, `notmuch-hello' used `kill-all-local-variables' to remove editable widgets fields. This caused the major mode to be reset, and `notmuch-hello-mode' to be called every time. The patc

[PATCH v3 3/4] test: add broken test for `notmuch-hello-mode-hook' called during update

Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken. --- test/emacs | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index a864ffa..b4c2444 100755 --- a/test/emacs +++ b/te

[PATCH v3 2/4] test: add test for `notmuch-hello-mode-hook'

Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called. --- test/emacs |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 6e922de..a864ffa 100755 --- a/test/emacs +++ b/test/emacs @@ -476,4 +476,13 @@ t

[PATCH v3 1/4] test: add `notmuch-hello-mode-hook-counter'

Add `notmuch-hello-mode-hook-counter' hook to count how many times `notmuch-hello-mode-hook' was called. The counter function increments `notmuch-hello-mode-hook-counter' variable value if it is bount, otherwise it does nothing. --- test/test-lib.el |9 + 1 files changed, 9 insertions

[PATCH v3 0/4] emacs: do not call `notmuch-hello-mode' on update

Changes: v3: * remove useless let with `widget-field-list', thanks Austin v2: * actually use `all' variable in `mapc' call, thanks Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 4/4] emacs: do not call `notmuch-hello-mode' on update

`notmuch-hello' should call `notmuch-hello-mode' function only when run for the first time. But before the change, `notmuch-hello' used `kill-all-local-variables' to remove editable widgets fields. This caused the major mode to be reset, and `notmuch-hello-mode' to be called every time. The patc

[PATCH v2 3/4] test: add broken test for `notmuch-hello-mode-hook' called during update

Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken. --- test/emacs | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index a864ffa..b4c2444 100755 --- a/test/emacs +++ b/te

[PATCH v2 2/4] test: add test for `notmuch-hello-mode-hook'

Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called. --- test/emacs |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 6e922de..a864ffa 100755 --- a/test/emacs +++ b/test/emacs @@ -476,4 +476,13 @@ t

[PATCH v2 1/4] test: add `notmuch-hello-mode-hook-counter'

Add `notmuch-hello-mode-hook-counter' hook to count how many times `notmuch-hello-mode-hook' was called. The counter function increments `notmuch-hello-mode-hook-counter' variable value if it is bount, otherwise it does nothing. --- test/test-lib.el |9 + 1 files changed, 9 insertions

[PATCH v2 0/4] emacs: do not call `notmuch-hello-mode' on update

Changes in v2 since v1: * actually use `all' variable in `mapc' call, thanks Tomi Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 4/4] emacs: do not call `notmuch-hello-mode' on update

`notmuch-hello' should call `notmuch-hello-mode' function only when run for the first time. But before the change, `notmuch-hello' used `kill-all-local-variables' to remove editable widgets fields. This caused the major mode to be reset, and `notmuch-hello-mode' to be called every time. The patc

[PATCH 3/4] test: add broken test for `notmuch-hello-mode-hook' called during update

Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken. --- test/emacs | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index a864ffa..b4c2444 100755 --- a/test/emacs +++ b/te

[PATCH 2/4] test: add test for `notmuch-hello-mode-hook'

Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called. --- test/emacs |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 6e922de..a864ffa 100755 --- a/test/emacs +++ b/test/emacs @@ -476,4 +476,13 @@ t

[PATCH 1/4] test: add `notmuch-hello-mode-hook-counter'

Add `notmuch-hello-mode-hook-counter' hook to count how many times `notmuch-hello-mode-hook' was called. The counter function increments `notmuch-hello-mode-hook-counter' variable value if it is bount, otherwise it does nothing. --- test/test-lib.el |9 + 1 files changed, 9 insertions

Re: [PATCH] [emacs] Add an argument to notmuch-mua-mail

Looks good to me. Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] [emacs] Add an argument to notmuch-mua-mail

On Sat, 17 Dec 2011 05:41:28 -0500, Aaron Ecay wrote: > From the emacs changelog: > > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and > passes it to the mail user agent function. This argument specifies an > action for returning to the caller after finishing with the

[PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi Tom. On Thu, 15 Dec 2011 10:27:33 -0700, Tom Prince wrote: > On Thu, 15 Dec 2011 08:14:08 -0400, David Bremner > wrote: > > On Mon, 4 Jul 2011 05:59:03 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > Result: nothing happens except for "No URL at poin

[PATCH v3 4/4] emacs: add notmuch-hello-hook

On Tue, 13 Dec 2011 21:49:00 +0400, Dmitry Kurochkin wrote: > On Tue, 13 Dec 2011 18:32:12 +0100, Thomas Jost > wrote: > > This hook is called every time the notmuch-hello buffer is updated. > > --- > > emacs/notmuch-hello.el |9 - > > 1 files changed

[PATCH 4/4] emacs: do not call `notmuch-hello-mode' on update

`notmuch-hello' should call `notmuch-hello-mode' function only when run for the first time. But before the change, `notmuch-hello' used `kill-all-local-variables' to remove editable widgets fields. This caused the major mode to be reset, and `notmuch-hello-mode' to be called every time. The patc

[PATCH 3/4] test: add broken test for `notmuch-hello-mode-hook' called during update

Test that `notmuch-hello-mode-hook' is not called during `notmuch-hello' buffer updates. The test is currently broken. --- test/emacs | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index a864ffa..b4c2444 100755 --- a/test/emacs +++ b/te

[PATCH 1/4] test: add `notmuch-hello-mode-hook-counter'

Add `notmuch-hello-mode-hook-counter' hook to count how many times `notmuch-hello-mode-hook' was called. The counter function increments `notmuch-hello-mode-hook-counter' variable value if it is bount, otherwise it does nothing. --- test/test-lib.el |9 + 1 files changed, 9 insertions

[PATCH 2/4] test: add test for `notmuch-hello-mode-hook'

Test that `notmuch-hello-mode-hook' is called once when `notmuch-hello' function is called. --- test/emacs |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/test/emacs b/test/emacs index 6e922de..a864ffa 100755 --- a/test/emacs +++ b/test/emacs @@ -476,4 +476,13 @@ t

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner wrote: > On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin gmail.com> wrote: > > > > What do perople think about making the thousands separator a space by > > default? > > > > Is that really good for a

[PATCH 2/2] emacs: Fix notmuch-mua-user-agent defcustom

On Fri, 23 Sep 2011 22:03:42 +0300, Jani Nikula wrote: > The :options keyword is not meaningful for function type. Also, it was not > possible to enter nil value, contrary to the notmuch-mua-user-agent > defcustom documentation. Specify the alternatives using choice type, taking > nil into account

[PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom

On Fri, 16 Dec 2011 16:22:07 +0400, Dmitry Kurochkin wrote: > Hi Jani. > > On Fri, 23 Sep 2011 22:03:41 +0300, Jani Nikula wrote: > > It was not possible to define custom filters or filter functions because > > the types were const. Remove const to allow editing. >

[PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom

Hi Jani. On Fri, 23 Sep 2011 22:03:41 +0300, Jani Nikula wrote: > It was not possible to define custom filters or filter functions because > the types were const. Remove const to allow editing. > How about making "Unread messages" query configurable as well? Regards, Dmitry > Signed-off-by:

[PATCH] [emacs] Add an argument to notmuch-mua-mail

On Fri, 16 Dec 2011 06:16:45 -0500, Aaron Ecay wrote: > From the emacs changelog: > > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and > passes it to the mail user agent function. This argument specifies an > action for returning to the caller after finishing with the

[PATCH] [emacs] Add an argument to notmuch-mua-mail

On Fri, 16 Dec 2011 13:06:21 +0200, Tomi Ollila wrote: > On Fri, 16 Dec 2011 05:30:39 -0500, Aaron Ecay wrote: > > >From the emacs changelog: > > > > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and > > passes it to the mail user agent function. This argument specifies

[PATCH] [emacs] Add an argument to notmuch-mua-mail

On Fri, 16 Dec 2011 05:30:39 -0500, Aaron Ecay wrote: > From the emacs changelog: > > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and > passes it to the mail user agent function. This argument specifies an > action for returning to the caller after finishing with the

Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part

Hi Tom. On Thu, 15 Dec 2011 10:27:33 -0700, Tom Prince wrote: > On Thu, 15 Dec 2011 08:14:08 -0400, David Bremner wrote: > > On Mon, 4 Jul 2011 05:59:03 +0400, Dmitry Kurochkin > > wrote: > > > Result: nothing happens except for "No URL at point" message

Re: [PATCH v3 4/4] emacs: add notmuch-hello-hook

On Tue, 13 Dec 2011 21:49:00 +0400, Dmitry Kurochkin wrote: > On Tue, 13 Dec 2011 18:32:12 +0100, Thomas Jost wrote: > > This hook is called every time the notmuch-hello buffer is updated. > > --- > > emacs/notmuch-hello.el |9 - > > 1 files changed, 8

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

On Tue, 13 Dec 2011 18:32:11 +0100, Thomas Jost wrote: > In 123,456.78, "." is the decimal separator, but "," is the thousands > separator. > > This commit also mentions the space being used as thousands separator in > several > European countries. > --- What do perople think about making the

[PATCH v3 2/4] emacs: Add a face for crypto parts headers

On Tue, 13 Dec 2011 18:32:10 +0100, Thomas Jost wrote: > Commit cb841878 introduced new parts handlers for crypto parts, but also > hardcoded values for their headers face. This replaces these hardcoded values > with a customizable face. > --- Looks good to me. Regards, Dmitry > emacs/notmu

Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner wrote: > On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin > wrote: > > > > What do perople think about making the thousands separator a space by > > default? > > > > Is that really good for a majori

Re: [PATCH 2/2] emacs: Fix notmuch-mua-user-agent defcustom

On Fri, 23 Sep 2011 22:03:42 +0300, Jani Nikula wrote: > The :options keyword is not meaningful for function type. Also, it was not > possible to enter nil value, contrary to the notmuch-mua-user-agent > defcustom documentation. Specify the alternatives using choice type, taking > nil into account

Re: [PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom

On Fri, 16 Dec 2011 16:22:07 +0400, Dmitry Kurochkin wrote: > Hi Jani. > > On Fri, 23 Sep 2011 22:03:41 +0300, Jani Nikula wrote: > > It was not possible to define custom filters or filter functions because > > the types were const. Remove const to allow editing. >

Re: [PATCH 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom

Hi Jani. On Fri, 23 Sep 2011 22:03:41 +0300, Jani Nikula wrote: > It was not possible to define custom filters or filter functions because > the types were const. Remove const to allow editing. > How about making "Unread messages" query configurable as well? Regards, Dmitry > Signed-off-by:

Re: [PATCH] [emacs] Add an argument to notmuch-mua-mail

On Fri, 16 Dec 2011 06:16:45 -0500, Aaron Ecay wrote: > From the emacs changelog: > > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and > passes it to the mail user agent function. This argument specifies an > action for returning to the caller after finishing with the

Re: [PATCH] [emacs] Add an argument to notmuch-mua-mail

On Fri, 16 Dec 2011 13:06:21 +0200, Tomi Ollila wrote: > On Fri, 16 Dec 2011 05:30:39 -0500, Aaron Ecay wrote: > > >From the emacs changelog: > > > > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and > > passes it to the mail user agent function. This argument specifies

Re: [PATCH] [emacs] Add an argument to notmuch-mua-mail

On Fri, 16 Dec 2011 05:30:39 -0500, Aaron Ecay wrote: > From the emacs changelog: > > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and > passes it to the mail user agent function. This argument specifies an > action for returning to the caller after finishing with the

Re: [PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

On Tue, 13 Dec 2011 18:32:11 +0100, Thomas Jost wrote: > In 123,456.78, "." is the decimal separator, but "," is the thousands > separator. > > This commit also mentions the space being used as thousands separator in > several > European countries. > --- What do perople think about making the

Re: [PATCH v3 2/4] emacs: Add a face for crypto parts headers

On Tue, 13 Dec 2011 18:32:10 +0100, Thomas Jost wrote: > Commit cb841878 introduced new parts handlers for crypto parts, but also > hardcoded values for their headers face. This replaces these hardcoded values > with a customizable face. > --- Looks good to me. Regards, Dmitry > emacs/notmuc

[Alpha Patch 2/2] test: update dump-restore tests for 8 bit characters.

On Wed, 14 Dec 2011 16:14:01 -0400, David Bremner wrote: > From: David Bremner > > hex-escape: fix for handling of 8 bit chars > > The low level problem was passing negative numbers to sprintf(s,"%x"); > we fix this and clarify the api for hex_(decode|encode) by making > encode go from (unsigne

[Alpha PATCH 6/6] test: second set of dump/restore --format=notmuch tests

On Tue, 13 Dec 2011 16:27:55 -0400, David Bremner wrote: > From: David Bremner > > These one need the completed functionality in notmuch-restore. Fairly > exotic tags are tested, but no weird message id's. > --- > test/dump-restore | 33 + > 1 files changed, 33

[PATCH v6 1/2] emacs: User-defined sections in notmuch-hello

On Wed, 14 Dec 2011 07:11:21 +0400, Dmitry Kurochkin wrote: > Hi Daniel. > > I have finished reviewing this patch at last. Sorry, it is a bit messy. > Overall, I like the patch. It is a very nice improvement. > > I am sure I have missed some important points, but I guess th

Re: [Alpha Patch 2/2] test: update dump-restore tests for 8 bit characters.

On Wed, 14 Dec 2011 16:14:01 -0400, David Bremner wrote: > From: David Bremner > > hex-escape: fix for handling of 8 bit chars > > The low level problem was passing negative numbers to sprintf(s,"%x"); > we fix this and clarify the api for hex_(decode|encode) by making > encode go from (unsigne

Re: [Alpha PATCH 6/6] test: second set of dump/restore --format=notmuch tests

On Tue, 13 Dec 2011 16:27:55 -0400, David Bremner wrote: > From: David Bremner > > These one need the completed functionality in notmuch-restore. Fairly > exotic tags are tested, but no weird message id's. > --- > test/dump-restore | 33 + > 1 files changed, 33

[PATCH v6 1/2] emacs: User-defined sections in notmuch-hello

Hi Daniel. I have finished reviewing this patch at last. Sorry, it is a bit messy. Overall, I like the patch. It is a very nice improvement. I am sure I have missed some important points, but I guess this is the best I can do right now. Perhaps I will find more comments for the next version of

Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello

On Wed, 14 Dec 2011 07:11:21 +0400, Dmitry Kurochkin wrote: > Hi Daniel. > > I have finished reviewing this patch at last. Sorry, it is a bit messy. > Overall, I like the patch. It is a very nice improvement. > > I am sure I have missed some important points, but I guess th

[PATCH] test: optionally print subtest number

On Tue, 13 Dec 2011 15:35:53 -0800, Jameson Graef Rollins wrote: > On Wed, 14 Dec 2011 03:24:23 +0400, Dmitry Kurochkin gmail.com> wrote: > > BTW I have some plans to introduce optional explicit test ids that can > > be used for inter-test dependencies. E.g.: > > >

[PATCH] test: optionally print subtest number

On Tue, 13 Dec 2011 19:18:16 -0400, David Bremner wrote: > On Tue, 13 Dec 2011 14:22:21 -0800, Jameson Graef Rollins finestructure.net> wrote: > > > I've only been vaguely following this "test count" stuff, but I'm not > > sure I understand what's the point of giving tests a number that is > > u

[PATCH] test: optionally print subtest number

On Tue, 13 Dec 2011 22:55:18 +0200, Tomi Ollila wrote: > On Wed, 14 Dec 2011 00:15:43 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Tue, 13 Dec 2011 15:56:47 -0400, David Bremner > > wrote: > > > From: David Bremner > > > > > > The idea is tha

<    2   3   4   5   6   7   8   9   10   11   >