cur/", only if no flags have to be changed. It's hopefully enough to satisfy
mutt (and maybe other MUAs showing the "new" status) users checking the "new"
status.
Changelog:
* v2: Fix bool type as well as NULL returned despite having no errors (Austin
Clements)
* v4: T
mit log to better describe the intended changes, and tag the
test as broken until the actual changes are implemented -- Louis Rilling ]
Signed-off-by: Louis Rilling
---
test/maildir-sync |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/test/maildir-sync b/test/maildir-sync
ind
The for loop right after already does the job.
Signed-off-by: Louis Rilling
---
lib/message.cc |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index cf651e5..b1b2942 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -1172,8 +1172,6
Signed-off-by: Louis Rilling
---
lib/message.cc | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index d993cde..cf651e5 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -49,16 +49,16 @@ struct visible _notmuch_message
- included the test contributed by Michal Sojka
* v3: Added patch to kill the last usage of C++ type bool
* v2: Fix bool type as well as NULL returned despite having no errors (Austin
Clements)
Thanks,
Louis
Louis Rilling (3):
lib: Kill last usage of C++ type bool
tags_to_mai
The for loop right after already does the job.
Signed-off-by: Louis Rilling l.rill...@av7.net
---
lib/message.cc |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index cf651e5..b1b2942 100644
--- a/lib/message.cc
+++ b/lib/message.cc
changes, and tag the
test as broken until the actual changes are implemented -- Louis Rilling ]
Signed-off-by: Louis Rilling l.rill...@av7.net
---
test/maildir-sync |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/test/maildir-sync b/test/maildir-sync
index a60854f
(and maybe other MUAs showing the new status) users checking the new
status.
Changelog:
* v2: Fix bool type as well as NULL returned despite having no errors (Austin
Clements)
* v4: Tag the related test (contributed by Michal Sojka) as working
Signed-off-by: Louis Rilling l.rill...@av7.net
On 05/09/11 12:31 -0700, Jameson Graef Rollins wrote:
> Also, we generally prefer to have modifications to the test suite in
> separate patches that precede the patches that add the features/fix the
> bugs.
>
For new features, this does not look like 'git bisect'-safe. I would say that
the
On 05/09/11 12:31 -0700, Jameson Graef Rollins wrote:
Also, we generally prefer to have modifications to the test suite in
separate patches that precede the patches that add the features/fix the
bugs.
For new features, this does not look like 'git bisect'-safe. I would say that
the testsuite
On 14/07/11 2:06 +0200, Michal Sojka wrote:
> From: Michal Sojka
>
> This adds a test for patch submitted by Louis Rilling. Without his patch
> applied this test fails.
Thanks a lot Michal! I was indeed wondering how to do this. This test perfectly
matches the intended u
On 14/07/11 2:06 +0200, Michal Sojka wrote:
From: Michal Sojka so...@os.inf.tu-dresden.de
This adds a test for patch submitted by Louis Rilling. Without his patch
applied this test fails.
Thanks a lot Michal! I was indeed wondering how to do this. This test perfectly
matches the intended
The for loop right after already does the job.
Signed-off-by: Louis Rilling
---
lib/message.cc |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index cf651e5..b1b2942 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -1172,8 +1172,6
On 11/07/11 20:03 -0400, Austin Clements wrote:
> > > The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE
> > > (though, admittedly, I don't know why; avoiding C99-isms?)
> >
> > And bool is already used at another place in message.cc:
> >
> > struct maildir_flag_tag {
> >
cur/", only if no flags have to be changed. It's hopefully enough to satisfy
mutt (and maybe other MUAs showing the "new" status) users checking the "new"
status.
Changelog:
* v2: Fix bool type as well as NULL returned despite having no errors (Austin
Clements)
Signed-off-
elow.
They should be addressed by the follow-up patch. Just a comment below.
>
> Quoth Louis Rilling on Jul 11 at 4:36 pm:
> > notmuch_message_tags_to_maildir_flags() unconditionally moves messages from
> > maildir directory "new/" to maildir directory "cur/"
On 11/07/11 20:03 -0400, Austin Clements wrote:
The convention in notmuch is to use notmuch_bool_t, TRUE, and FALSE
(though, admittedly, I don't know why; avoiding C99-isms?)
And bool is already used at another place in message.cc:
struct maildir_flag_tag {
char flag;
as notmuch can respect the
maildir specification.
Changelog:
* v3: Added patch to kill the last usage of C++ type bool
* v2: Fix bool type as well as NULL returned despite having no errors (Austin
Clements)
Thanks,
Louis
Louis Rilling (3):
lib: Kill last usage of C++ type bool
Signed-off-by: Louis Rilling l.rill...@av7.net
---
lib/message.cc | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index d993cde..cf651e5 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -49,16 +49,16 @@ struct visible
The for loop right after already does the job.
Signed-off-by: Louis Rilling l.rill...@av7.net
---
lib/message.cc |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index cf651e5..b1b2942 100644
--- a/lib/message.cc
+++ b/lib/message.cc
cur/", only if no flags have to be changed. It's hopefully enough to satisfy
mutt (and maybe other MUAs showing the "new" status) users checking the "new"
status.
Signed-off-by: Louis Rilling
---
lib/message.cc | 12 +++-
1 files changed, 11 insertions(+), 1 deletion
The for loop right after already does the job.
Signed-off-by: Louis Rilling
---
lib/message.cc |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index d993cde..64b6cf8 100644
--- a/lib/message.cc
+++ b/lib/message.cc
@@ -1172,8 +1172,6
flags=true
messages will be kept in "new/", even with
[new]
tags=inbox;unread;
[maildir]
synchronize_flags=true
as long as no maildir flags have to be changed.
The first patch can be applied independently.
Thanks,
Louis
Louis Rilling (2):
tags_to_ma
messages will be kept in new/, even with
[new]
tags=inbox;unread;
[maildir]
synchronize_flags=true
as long as no maildir flags have to be changed.
The first patch can be applied independently.
Thanks,
Louis
Louis Rilling (2):
tags_to_maildir_flags
The for loop right after already does the job.
Signed-off-by: Louis Rilling l.rill...@av7.net
---
lib/message.cc |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index d993cde..64b6cf8 100644
--- a/lib/message.cc
+++ b/lib/message.cc
(and maybe other MUAs showing the new status) users checking the new
status.
Signed-off-by: Louis Rilling l.rill...@av7.net
---
lib/message.cc | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index 64b6cf8..131d99b 100644
--- a/lib
(and maybe other MUAs showing the new status) users checking the new
status.
Changelog:
* v2: Fix bool type as well as NULL returned despite having no errors (Austin
Clements)
Signed-off-by: Louis Rilling l.rill...@av7.net
---
lib/message.cc | 12 +++-
1 files changed, 11 insertions
>
> [1] There's a bug open about the second problem (thanks to ccxCZ for
> finding this):
> http://dev.mutt.org/trac/ticket/2476
> Of course, fixing that implies addressing the first problem, too.
>
> On Thu, Jun 23, 2011 at 11:36 AM, Louis Rilling wrote:
> > no
that this would be acceptable?
Thanks,
Louis
[1] There's a bug open about the second problem (thanks to ccxCZ for
finding this):
http://dev.mutt.org/trac/ticket/2476
Of course, fixing that implies addressing the first problem, too.
On Thu, Jun 23, 2011 at 11:36 AM, Louis Rilling l.rill
ildir]" section of .notmuch-config, so that users can
configure whether commands "notmuch tag" and "notmuch restore" preserve the
"new" status or not.
Signed-off-by: Louis Rilling
---
Hi,
I'm in the process of using notmuch, but the issue "addressed&
30 matches
Mail list logo
