[PATCH] News for emacs saved-searches change.

2014-04-09 Thread Mark Walters
--- The important point is that the changed search variable is not forward compatible (it *is* backwards compatible): that is previous version of notmuch-emacs will be unusable with a new style notmuch-saved-search variable. Best wishes Mark NEWS | 17 + 1 file changed, 17 i

[PATCH] News for emacs saved-searches change.

2014-04-09 Thread Mark Walters
--- The important point is that the changed search variable is not forward compatible (it *is* backwards compatible): that is previous version of notmuch-emacs will be unusable with a new style notmuch-saved-search variable. Best wishes Mark NEWS | 17 + 1 file changed, 17 i

Feature suggestion. Indexing encrypted mail?

2014-04-07 Thread Mark Walters
On Mon, 07 Apr 2014, Jeremy Nickurak wrote: > Nonetheess, if you can tell from the index that a given message contains > the words "hotel" "wine" "wife" "secret" and "rendezvous", you can infer a > *lot* about the contents of encrypted contents of the message. I think it is worse that that: I th

Re: Feature suggestion. Indexing encrypted mail?

2014-04-07 Thread Mark Walters
On Mon, 07 Apr 2014, Jeremy Nickurak wrote: > Nonetheess, if you can tell from the index that a given message contains > the words "hotel" "wine" "wife" "secret" and "rendezvous", you can infer a > *lot* about the contents of encrypted contents of the message. I think it is worse that that: I th

[PATCH v2 5/5] emacs: Add a sort-order option to saved-searches

2014-04-06 Thread Mark Walters
This adds a sort-order option to saved-searches, stores it in the saved-search buttons (widgets), and uses the stored value when the button is pressed. Storing the sort-order in the widget was suggested by Jani in id:4c3876274126985683e888641b29cf18142a5eb8.1391771337.git.jani at nikula.org. ---

[PATCH v2 4/5] emacs: hello: switch notmuch-hello-insert-buttons to plists

2014-04-06 Thread Mark Walters
Switching notmuch-hello-insert-buttons to plists means we can easily pass extra options through to the buttons. --- emacs/notmuch-hello.el | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el ind

[PATCH v2 3/5] emacs: hello: add a customize for saved-searches

2014-04-06 Thread Mark Walters
Make the defcustom for notmuch-saved-searches use the new plist format. It should still work with oldstyle saved-searches but will write the newstyle form. --- emacs/notmuch-hello.el |2 +- emacs/notmuch-lib.el | 46 ++ 2 files changed, 43 insert

[PATCH v2 2/5] emacs: hello: use the saved-search helper functions

2014-04-06 Thread Mark Walters
This uses the helper functions: the saved searches format has not changed yet but backwards compatibility means everything still works. --- emacs/notmuch-hello.el | 48 ++-- emacs/notmuch.el |6 +++--- 2 files changed, 25 insertions(+), 29 de

[PATCH v2 1/5] emacs: hello: add helper functions for saved-searches

2014-04-06 Thread Mark Walters
Add helper functions to for saved searches to ease the transition to the new plist form while maintaining backwards compatibility. They will be used in the next patch. --- emacs/notmuch-hello.el | 38 ++ 1 file changed, 38 insertions(+) diff --git a/emacs/not

[PATCH v2 0/5] emacs: hello: convert saved-searches to plists

2014-04-06 Thread Mark Walters
appears in patch 3 while the users and references to that documentation appear in patch 2. Best wishes Mark Mark Walters (5): emacs: hello: add helper functions for saved-searches emacs: hello: use the saved-search helper functions emacs: hello: add a customize for saved-searches emacs

[PATCH 0/5] emacs: hello: convert saved-searches to plists

2014-04-06 Thread Mark Walters
On Sun, 06 Apr 2014, David Bremner wrote: > Mark Walters writes: > >> This series converts the saved-search format to plists. This should >> make it much easier to extend their functionality. The final patch >> illustrates this by adding a sort-order option to the sa

[PATCH 5/5] emacs: Add a sort-order option to saved-searches

2014-04-06 Thread Mark Walters
Hi On Sun, 06 Apr 2014, Austin Clements wrote: > Quoth Mark Walters on Apr 05 at 10:24 pm: >> This adds a sort-order option to saved-searches, stores it in the >> saved-search buttons (widgets), and uses the stored value when the >> button is pressed. >> >> Sto

[PATCH 4/5] emacs: hello: switch notmuch-hello-insert-buttons to plists

2014-04-06 Thread Mark Walters
Hello >> @@ -455,23 +457,26 @@ (defun notmuch-hello-query-counts (query-list &rest >> options) >> #'identity >> (mapcar >>(lambda (elem) >> -(let ((name (notmuch-saved-search-get elem :name)) >> - (search-query (notmuch-saved-search-get elem :query)) >> -

[PATCH v2 4/5] emacs: hello: switch notmuch-hello-insert-buttons to plists

2014-04-05 Thread Mark Walters
Switching notmuch-hello-insert-buttons to plists means we can easily pass extra options through to the buttons. --- emacs/notmuch-hello.el | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el ind

[PATCH v2 5/5] emacs: Add a sort-order option to saved-searches

2014-04-05 Thread Mark Walters
This adds a sort-order option to saved-searches, stores it in the saved-search buttons (widgets), and uses the stored value when the button is pressed. Storing the sort-order in the widget was suggested by Jani in id:4c3876274126985683e888641b29cf18142a5eb8.1391771337.git.j...@nikula.org. --- ema

[PATCH v2 2/5] emacs: hello: use the saved-search helper functions

2014-04-05 Thread Mark Walters
This uses the helper functions: the saved searches format has not changed yet but backwards compatibility means everything still works. --- emacs/notmuch-hello.el | 48 ++-- emacs/notmuch.el |6 +++--- 2 files changed, 25 insertions(+), 29 de

[PATCH v2 1/5] emacs: hello: add helper functions for saved-searches

2014-04-05 Thread Mark Walters
Add helper functions to for saved searches to ease the transition to the new plist form while maintaining backwards compatibility. They will be used in the next patch. --- emacs/notmuch-hello.el | 38 ++ 1 file changed, 38 insertions(+) diff --git a/emacs/not

[PATCH v2 3/5] emacs: hello: add a customize for saved-searches

2014-04-05 Thread Mark Walters
Make the defcustom for notmuch-saved-searches use the new plist format. It should still work with oldstyle saved-searches but will write the newstyle form. --- emacs/notmuch-hello.el |2 +- emacs/notmuch-lib.el | 46 ++ 2 files changed, 43 insert

[PATCH v2 0/5] emacs: hello: convert saved-searches to plists

2014-04-05 Thread Mark Walters
appears in patch 3 while the users and references to that documentation appear in patch 2. Best wishes Mark Mark Walters (5): emacs: hello: add helper functions for saved-searches emacs: hello: use the saved-search helper functions emacs: hello: add a customize for saved-searches emacs: hello

Re: [PATCH 0/5] emacs: hello: convert saved-searches to plists

2014-04-05 Thread Mark Walters
On Sun, 06 Apr 2014, David Bremner wrote: > Mark Walters writes: > >> This series converts the saved-search format to plists. This should >> make it much easier to extend their functionality. The final patch >> illustrates this by adding a sort-order option to the sa

Re: [PATCH 5/5] emacs: Add a sort-order option to saved-searches

2014-04-05 Thread Mark Walters
Hi On Sun, 06 Apr 2014, Austin Clements wrote: > Quoth Mark Walters on Apr 05 at 10:24 pm: >> This adds a sort-order option to saved-searches, stores it in the >> saved-search buttons (widgets), and uses the stored value when the >> button is pressed. >> >> Sto

Re: [PATCH 4/5] emacs: hello: switch notmuch-hello-insert-buttons to plists

2014-04-05 Thread Mark Walters
Hello >> @@ -455,23 +457,26 @@ (defun notmuch-hello-query-counts (query-list &rest >> options) >> #'identity >> (mapcar >>(lambda (elem) >> -(let ((name (notmuch-saved-search-get elem :name)) >> - (search-query (notmuch-saved-search-get elem :query)) >> -

[PATCH 5/5] emacs: Add a sort-order option to saved-searches

2014-04-05 Thread Mark Walters
This adds a sort-order option to saved-searches, stores it in the saved-search buttons (widgets), and uses the stored value when the button is pressed. Storing the sort-order in the widget was suggested by Jani in id:4c3876274126985683e888641b29cf18142a5eb8.1391771337.git.jani at nikula.org. ---

[PATCH 4/5] emacs: hello: switch notmuch-hello-insert-buttons to plists

2014-04-05 Thread Mark Walters
Switching notmuch-hello-insert-buttons to plists means we can easily pass extra options through to the buttons. --- emacs/notmuch-hello.el | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index

[PATCH 3/5] emacs: hello: add a customize for saved-searches

2014-04-05 Thread Mark Walters
Make the defcustom for notmuch-saved-searches use the new plist format. It should still work with oldstyle saved-searches but will write the newstyle form. --- emacs/notmuch-hello.el |2 +- emacs/notmuch-lib.el | 28 +--- 2 files changed, 26 insertions(+), 4 deletio

[PATCH 2/5] emacs: hello: use the saved-search helper functions

2014-04-05 Thread Mark Walters
This uses the helper functions: the saved searches format has not changed yet but backwards compatibility means everything still works. --- emacs/notmuch-hello.el | 48 ++-- emacs/notmuch.el |6 +++--- 2 files changed, 25 insertions(+), 29 de

[PATCH 1/5] emacs: hello: add helper functions for saved-searches

2014-04-05 Thread Mark Walters
Add helper functions to for saved searches to ease the transition to the new plist form while maintaining backwards compatibility. They will be used in the next patch. --- emacs/notmuch-hello.el | 39 +++ 1 file changed, 39 insertions(+) diff --git a/emacs/no

[PATCH 0/5] emacs: hello: convert saved-searches to plists

2014-04-05 Thread Mark Walters
then it may break. Also note that the functions used for saved-searches are also used for the "all tags" section: I have not converted them as they are purely internal. Since we have backwards compatibility they still work. Best wishes Mark Mark Walters (5): emacs: hello:

[PATCH 5/5] emacs: Add a sort-order option to saved-searches

2014-04-05 Thread Mark Walters
This adds a sort-order option to saved-searches, stores it in the saved-search buttons (widgets), and uses the stored value when the button is pressed. Storing the sort-order in the widget was suggested by Jani in id:4c3876274126985683e888641b29cf18142a5eb8.1391771337.git.j...@nikula.org. --- ema

[PATCH 1/5] emacs: hello: add helper functions for saved-searches

2014-04-05 Thread Mark Walters
Add helper functions to for saved searches to ease the transition to the new plist form while maintaining backwards compatibility. They will be used in the next patch. --- emacs/notmuch-hello.el | 39 +++ 1 file changed, 39 insertions(+) diff --git a/emacs/no

[PATCH 4/5] emacs: hello: switch notmuch-hello-insert-buttons to plists

2014-04-05 Thread Mark Walters
Switching notmuch-hello-insert-buttons to plists means we can easily pass extra options through to the buttons. --- emacs/notmuch-hello.el | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index

[PATCH 2/5] emacs: hello: use the saved-search helper functions

2014-04-05 Thread Mark Walters
This uses the helper functions: the saved searches format has not changed yet but backwards compatibility means everything still works. --- emacs/notmuch-hello.el | 48 ++-- emacs/notmuch.el |6 +++--- 2 files changed, 25 insertions(+), 29 de

[PATCH 3/5] emacs: hello: add a customize for saved-searches

2014-04-05 Thread Mark Walters
Make the defcustom for notmuch-saved-searches use the new plist format. It should still work with oldstyle saved-searches but will write the newstyle form. --- emacs/notmuch-hello.el |2 +- emacs/notmuch-lib.el | 28 +--- 2 files changed, 26 insertions(+), 4 deletio

[PATCH 0/5] emacs: hello: convert saved-searches to plists

2014-04-05 Thread Mark Walters
then it may break. Also note that the functions used for saved-searches are also used for the "all tags" section: I have not converted them as they are purely internal. Since we have backwards compatibility they still work. Best wishes Mark Mark Walters (5): emacs: hello:

[PATCH 2/2] emacs: add defcustom notmuch-init-file and load it if exists

2014-03-30 Thread Mark Walters
This looks good, but I haven't tested as it doesn't fit with my current setup. (Just to clarify my current setup still works, but it would be a moderate amount of effort to actually exercise the new code) One question: is it possible to get emacs to save notmuch customizations to the notmuch init

[PATCH] emacs: push mark before signature on reply

2014-03-30 Thread Mark Walters
LGTM +1 Best wishes Mark On Fri, 28 Mar 2014, Jani Nikula wrote: > We push mark on reply so user can cut the quote. Push the mark before > signature, if any, instead of end of buffer so the signature is > preserved. > > This is consistent with message-kill-to-signature. > --- > emacs/notmuch-

Re: [PATCH 2/2] emacs: add defcustom notmuch-init-file and load it if exists

2014-03-30 Thread Mark Walters
This looks good, but I haven't tested as it doesn't fit with my current setup. (Just to clarify my current setup still works, but it would be a moderate amount of effort to actually exercise the new code) One question: is it possible to get emacs to save notmuch customizations to the notmuch init

Re: [PATCH] emacs: push mark before signature on reply

2014-03-30 Thread Mark Walters
LGTM +1 Best wishes Mark On Fri, 28 Mar 2014, Jani Nikula wrote: > We push mark on reply so user can cut the quote. Push the mark before > signature, if any, instead of end of buffer so the signature is > preserved. > > This is consistent with message-kill-to-signature. > --- > emacs/notmuch-

[PATCH 0/2] cli: notmuch dump abstractions

2014-03-26 Thread Mark Walters
This series (with v2 of patch 2/2) LGTM +1 Best wishes Mark On Tue, 25 Mar 2014, Jani Nikula wrote: > These are non-functional prep work for letting us do database dumps from > elsewhere in notmuch, e.g. automatically before a database upgrade. > > BR, > Jani. > > > Jani Nikula (2): > cli:

[PATCH] test: conditionally test help system depending on configured support

2014-03-26 Thread Mark Walters
LGTM +1 (and tests pass on one of my systems that does not have sphinx or rst2man) Best wishes Mark On Wed, 26 Mar 2014, Jani Nikula wrote: > If neither sphinx nor rst2man is available, the notmuch man pages will > not be available. Take this into account in the help system test. > --- > test

Re: [PATCH 0/2] cli: notmuch dump abstractions

2014-03-26 Thread Mark Walters
This series (with v2 of patch 2/2) LGTM +1 Best wishes Mark On Tue, 25 Mar 2014, Jani Nikula wrote: > These are non-functional prep work for letting us do database dumps from > elsewhere in notmuch, e.g. automatically before a database upgrade. > > BR, > Jani. > > > Jani Nikula (2): > cli:

Re: [PATCH] test: conditionally test help system depending on configured support

2014-03-26 Thread Mark Walters
LGTM +1 (and tests pass on one of my systems that does not have sphinx or rst2man) Best wishes Mark On Wed, 26 Mar 2014, Jani Nikula wrote: > If neither sphinx nor rst2man is available, the notmuch man pages will > not be available. Take this into account in the help system test. > --- > test

[Patch v3 3/3] emacs: show: make `seen' mean user viewed whole message

2014-03-25 Thread Mark Walters
This changes `seen' to mean that the user viewed `enough' of the whole message: more precisely, a message is deemed seen if the top of the message and either the bottom of the message or a point at least some customisable number of lines into the message have each been visible in the buffer at some

[Patch v3 2/3] emacs: show: add an update seen function to post-command-hook

2014-03-25 Thread Mark Walters
Add a function stub for updating seen messages to the post-command-hook. This dummy function gets called with parameters the start and end of the current window and can decide what to mark seen based on that. Since this is in the post-command-hook it should get called after most user actions (exce

[Patch v3 1/3] test: make test_emacs call post-command-hook

2014-03-25 Thread Mark Walters
From: David Bremner The unread/read changes will use the post-command-hook. test_emacs does not call the post-command-hook. This adds a notmuch-test-progn which takes a list of commands as argument and executes them in turn but runs the post-command-hook after each one. The caller can batch oper

[Patch v3 0/3] emacs: show: redesign unread/read logic

2014-03-25 Thread Mark Walters
nt to merge the two when commiting. Best wishes Mark Mark Walters (3): test: make test_emacs call post-command-hook emacs: show: add an update seen function to post-command-hook emacs: show: make `seen' mean user viewed whole message emacs/notmuch-show

[Patch v3 1/3] test: make test_emacs call post-command-hook

2014-03-25 Thread Mark Walters
From: David Bremner The unread/read changes will use the post-command-hook. test_emacs does not call the post-command-hook. This adds a notmuch-test-progn which takes a list of commands as argument and executes them in turn but runs the post-command-hook after each one. The caller can batch oper

[Patch v3 3/3] emacs: show: make `seen' mean user viewed whole message

2014-03-25 Thread Mark Walters
This changes `seen' to mean that the user viewed `enough' of the whole message: more precisely, a message is deemed seen if the top of the message and either the bottom of the message or a point at least some customisable number of lines into the message have each been visible in the buffer at some

[Patch v3 2/3] emacs: show: add an update seen function to post-command-hook

2014-03-25 Thread Mark Walters
Add a function stub for updating seen messages to the post-command-hook. This dummy function gets called with parameters the start and end of the current window and can decide what to mark seen based on that. Since this is in the post-command-hook it should get called after most user actions (exce

[Patch v3 0/3] emacs: show: redesign unread/read logic

2014-03-25 Thread Mark Walters
e two when commiting. Best wishes Mark Mark Walters (3): test: make test_emacs call post-command-hook emacs: show: add an update seen function to post-command-hook emacs: show: make `seen' mean user viewed whole message emacs/notmuch-show

[Patch v4 8/8] emacs: tree: use orig-tags in search

2014-03-22 Thread Mark Walters
This uses the recent functionality to show the tag changes in the tree buffer. Currently this is only used to show changes the tree buffer makes itself: i.e., it does not make display any changes reflecting tagging done by other notmuch-buffers. --- emacs/notmuch-tree.el |9 ++--- 1 file c

[Patch v4 7/8] emacs: search: use orig-tags in search

2014-03-22 Thread Mark Walters
This uses the recent functionality to show the tag changes in the search buffer. Currently this is only used to show changes the search buffer makes itself: i.e., it does not make display any changes reflecting tagging done by other notmuch-buffers. --- emacs/notmuch.el | 41

[Patch v4 6/8] emacs: show: use orig-tags for tag display

2014-03-22 Thread Mark Walters
This uses the previous patch to show the tag changes that have occured in the show buffer since it was last loaded/refreshed. --- emacs/notmuch-show.el |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 5492be4..f6ca827 100

[Patch v4 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-22 Thread Mark Walters
This allows (and requires) the original-tags to be passed along with the current-tags to be passed to notmuch-tag-format-tags. This allows the tag formatting to show added and deleted tags.By default a removed tag is displayed with strike-through in red (if strike-through is not available, eg on a

[Patch v4 4/8] emacs: tag: add customize for deleted/added tag formats

2014-03-22 Thread Mark Walters
Add customize options for deleted/added tag formats. These are not used yet but will be later in the series. We switch to using `notmuch-apply-face' rather than `propertize' in the defcustom for faces so that the faces for deleted/added tags add to the default face attributes for the tag. We spe

[Patch v4 3/8] emacs: tag split customise option for format-tags into a widget

2014-03-22 Thread Mark Walters
We will re-use the customize option for format-tags for formattting deleted tags to added tags in the next patch so split it into a widget. There should be no functional change. --- emacs/notmuch-tag.el | 55 ++ 1 file changed, 29 insertions(+), 26

[Patch v4 2/8] Make keys of notmuch-tag-formats regexps and use caching

2014-03-22 Thread Mark Walters
From: Austin Clements This modifies `notmuch-tag-format-tag' to treat the keys of `notmuch-tag-formats' as (anchored) regexps, rather than literal strings. This is clearly more flexible, as it allows for prefix matching, defining a fallback format, etc. This may cause compatibility problems if

[Patch v4 1/8] emacs: Combine notmuch-combine-face-text-property{, -string}

2014-03-22 Thread Mark Walters
From: Austin Clements This combines our two face combining functions into one, easy to use function with a much shorter name: `notmuch-apply-face'. This function takes the full set of arguments that `notmuch-combine-face-text-property' took, but takes them in a more convenient order and provides

[Patch v4 0/8] emacs: show tag changes in buffer

2014-03-22 Thread Mark Walters
lements (2): emacs: Combine notmuch-combine-face-text-property{,-string} Make keys of notmuch-tag-formats regexps and use caching Mark Walters (6): emacs: tag split customise option for format-tags into a widget emacs: tag: add customize for deleted/added tag formats emacs: show: mark ta

[Patch v3 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-22 Thread Mark Walters
On Sat, 22 Mar 2014, Mark Walters wrote: > Hi > > Ok I have something working based on your version below. I will post > once I have tested a little more. Since the diff with my version will be > quite big I will just comment on the differences from your version. > > On Sat

[Patch v3 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-22 Thread Mark Walters
Hi Ok I have something working based on your version below. I will post once I have tested a little more. Since the diff with my version will be quite big I will just comment on the differences from your version. On Sat, 22 Mar 2014, Austin Clements wrote: > Quoth Mark Walters on Mar 12 at

[Patch v3 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-22 Thread Mark Walters
On Sat, 22 Mar 2014, Austin Clements wrote: > Quoth Mark Walters on Mar 12 at 4:09 am: >> This allows (and requires) the original-tags to be passed along with >> the current-tags to be passed to notmuch-tag-format-tags. This allows >> the tag formatting to show added and de

[Patch v3 4/8] emacs: tag: add customize for deleted/added tag formats

2014-03-22 Thread Mark Walters
Hi Many thanks for the review. On Sat, 22 Mar 2014, Austin Clements wrote: > Quoth Mark Walters on Mar 12 at 4:09 am: >> Add customize options for deleted/added tag formats. These are not >> used yet but will be later in the series. >> >> We switch to using `notm

[Patch v4 8/8] emacs: tree: use orig-tags in search

2014-03-22 Thread Mark Walters
This uses the recent functionality to show the tag changes in the tree buffer. Currently this is only used to show changes the tree buffer makes itself: i.e., it does not make display any changes reflecting tagging done by other notmuch-buffers. --- emacs/notmuch-tree.el |9 ++--- 1 file c

[Patch v4 6/8] emacs: show: use orig-tags for tag display

2014-03-22 Thread Mark Walters
This uses the previous patch to show the tag changes that have occured in the show buffer since it was last loaded/refreshed. --- emacs/notmuch-show.el |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 5492be4..f6ca827 100

[Patch v4 4/8] emacs: tag: add customize for deleted/added tag formats

2014-03-22 Thread Mark Walters
Add customize options for deleted/added tag formats. These are not used yet but will be later in the series. We switch to using `notmuch-apply-face' rather than `propertize' in the defcustom for faces so that the faces for deleted/added tags add to the default face attributes for the tag. We spe

[Patch v4 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-22 Thread Mark Walters
This allows (and requires) the original-tags to be passed along with the current-tags to be passed to notmuch-tag-format-tags. This allows the tag formatting to show added and deleted tags.By default a removed tag is displayed with strike-through in red (if strike-through is not available, eg on a

[Patch v4 7/8] emacs: search: use orig-tags in search

2014-03-22 Thread Mark Walters
This uses the recent functionality to show the tag changes in the search buffer. Currently this is only used to show changes the search buffer makes itself: i.e., it does not make display any changes reflecting tagging done by other notmuch-buffers. --- emacs/notmuch.el | 41

[Patch v4 3/8] emacs: tag split customise option for format-tags into a widget

2014-03-22 Thread Mark Walters
We will re-use the customize option for format-tags for formattting deleted tags to added tags in the next patch so split it into a widget. There should be no functional change. --- emacs/notmuch-tag.el | 55 ++ 1 file changed, 29 insertions(+), 26

[Patch v4 1/8] emacs: Combine notmuch-combine-face-text-property{, -string}

2014-03-22 Thread Mark Walters
From: Austin Clements This combines our two face combining functions into one, easy to use function with a much shorter name: `notmuch-apply-face'. This function takes the full set of arguments that `notmuch-combine-face-text-property' took, but takes them in a more convenient order and provides

[Patch v4 0/8] emacs: show tag changes in buffer

2014-03-22 Thread Mark Walters
): emacs: Combine notmuch-combine-face-text-property{,-string} Make keys of notmuch-tag-formats regexps and use caching Mark Walters (6): emacs: tag split customise option for format-tags into a widget emacs: tag: add customize for deleted/added tag formats emacs: show: mark tags cha

Re: [Patch v3 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-22 Thread Mark Walters
On Sat, 22 Mar 2014, Mark Walters wrote: > Hi > > Ok I have something working based on your version below. I will post > once I have tested a little more. Since the diff with my version will be > quite big I will just comment on the differences from your version. > > On Sat

Re: [Patch v3 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-22 Thread Mark Walters
Hi Ok I have something working based on your version below. I will post once I have tested a little more. Since the diff with my version will be quite big I will just comment on the differences from your version. On Sat, 22 Mar 2014, Austin Clements wrote: > Quoth Mark Walters on Mar 12 at

Re: [Patch v3 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-22 Thread Mark Walters
On Sat, 22 Mar 2014, Austin Clements wrote: > Quoth Mark Walters on Mar 12 at 4:09 am: >> This allows (and requires) the original-tags to be passed along with >> the current-tags to be passed to notmuch-tag-format-tags. This allows >> the tag formatting to show added and de

Re: [Patch v3 4/8] emacs: tag: add customize for deleted/added tag formats

2014-03-22 Thread Mark Walters
Hi Many thanks for the review. On Sat, 22 Mar 2014, Austin Clements wrote: > Quoth Mark Walters on Mar 12 at 4:09 am: >> Add customize options for deleted/added tag formats. These are not >> used yet but will be later in the series. >> >> We switch to using `notm

[PATCH] make http links into buttons

2014-03-16 Thread Mark Walters
Since there was a little discussion about this on irc I post it here (with bremner's permission) so that it doesn't get lost. Best wishes Mark Day changed Mon Jan 20 2014 14:28 < mjw1009_> bremner: I am not sure quite what behaviour you were seeing on the link-buttons message (nor quite what

Re: [PATCH] make http links into buttons

2014-03-16 Thread Mark Walters
Since there was a little discussion about this on irc I post it here (with bremner's permission) so that it doesn't get lost. Best wishes Mark Day changed Mon Jan 20 2014 14:28 < mjw1009_> bremner: I am not sure quite what behaviour you were seeing on the link-buttons message (nor quite what

[Patch v3 8/8] emacs: tree: use orig-tags in search

2014-03-12 Thread Mark Walters
This uses the recent functionality to show the tag changes in the tree buffer. Currently this is only used to show changes the tree buffer makes itself: i.e., it does not make display any changes reflecting tagging done by other notmuch-buffers. --- emacs/notmuch-tree.el |9 ++--- 1 files

[Patch v3 7/8] emacs: search: use orig-tags in search

2014-03-12 Thread Mark Walters
This uses the recent functionality to show the tag changes in the search buffer. Currently this is only used to show changes the search buffer makes itself: i.e., it does not make display any changes reflecting tagging done by other notmuch-buffers. --- emacs/notmuch.el | 41

[Patch v3 6/8] emacs: show: use orig-tags for tag display

2014-03-12 Thread Mark Walters
This uses the previous patch to show the tag changes that have occured in the show buffer since it was last loaded/refreshed. --- emacs/notmuch-show.el |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 5492be4..f6ca827 1

[Patch v3 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-12 Thread Mark Walters
This allows (and requires) the original-tags to be passed along with the current-tags to be passed to notmuch-tag-format-tags. This allows the tag formatting to show added and deleted tags.By default a removed tag is displayed with strike-through in red (if strike-through is not available, eg on a

[Patch v3 4/8] emacs: tag: add customize for deleted/added tag formats

2014-03-12 Thread Mark Walters
Add customize options for deleted/added tag formats. These are not used yet but will be later in the series. We switch to using `notmuch-apply-face' rather than `propertize' in the defcustom for faces so that the faces for deleted/added tags add to the default face attributes for the tag. We spe

[Patch v3 3/8] emacs: tag split customise option for format-tags into a widget

2014-03-12 Thread Mark Walters
We will re-use the customize option for format-tags for formattting deleted tags to added tags in the next patch so split it into a widget. There should be no functional change. --- emacs/notmuch-tag.el | 55 ++--- 1 files changed, 29 insertions(+), 26

[Patch v3 2/8] Make keys of notmuch-tag-formats regexps and use caching

2014-03-12 Thread Mark Walters
From: Austin Clements This modifies `notmuch-tag-format-tag' to treat the keys of `notmuch-tag-formats' as (anchored) regexps, rather than literal strings. This is clearly more flexible, as it allows for prefix matching, defining a fallback format, etc. This may cause compatibility problems if

[Patch v3 1/8] emacs: Combine notmuch-combine-face-text-property{, -string}

2014-03-12 Thread Mark Walters
From: Austin Clements This combines our two face combining functions into one, easy to use function with a much shorter name: `notmuch-apply-face'. This function takes the full set of arguments that `notmuch-combine-face-text-property' took, but takes them in a more convenient order and provides

[Patch v3 0/8] emacs: show tag changes in buffer

2014-03-12 Thread Mark Walters
the original tags; tags which have been deleted (i.e., are in ORIG-TAGS but @@ -246,7 +249,7 @@ (defun notmuch-tag-format-tags (tags orig-tags &optional face) "Return a string representing formatted TAGS." (let ((face (or face 'notmuch-tag-face)) (all-tags (sort (delet

[Patch v3 8/8] emacs: tree: use orig-tags in search

2014-03-11 Thread Mark Walters
This uses the recent functionality to show the tag changes in the tree buffer. Currently this is only used to show changes the tree buffer makes itself: i.e., it does not make display any changes reflecting tagging done by other notmuch-buffers. --- emacs/notmuch-tree.el |9 ++--- 1 files

[Patch v3 6/8] emacs: show: use orig-tags for tag display

2014-03-11 Thread Mark Walters
This uses the previous patch to show the tag changes that have occured in the show buffer since it was last loaded/refreshed. --- emacs/notmuch-show.el |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 5492be4..f6ca827 1

[Patch v3 7/8] emacs: search: use orig-tags in search

2014-03-11 Thread Mark Walters
This uses the recent functionality to show the tag changes in the search buffer. Currently this is only used to show changes the search buffer makes itself: i.e., it does not make display any changes reflecting tagging done by other notmuch-buffers. --- emacs/notmuch.el | 41

[Patch v3 4/8] emacs: tag: add customize for deleted/added tag formats

2014-03-11 Thread Mark Walters
Add customize options for deleted/added tag formats. These are not used yet but will be later in the series. We switch to using `notmuch-apply-face' rather than `propertize' in the defcustom for faces so that the faces for deleted/added tags add to the default face attributes for the tag. We spe

[Patch v3 5/8] emacs: show: mark tags changed since buffer loaded

2014-03-11 Thread Mark Walters
This allows (and requires) the original-tags to be passed along with the current-tags to be passed to notmuch-tag-format-tags. This allows the tag formatting to show added and deleted tags.By default a removed tag is displayed with strike-through in red (if strike-through is not available, eg on a

[Patch v3 3/8] emacs: tag split customise option for format-tags into a widget

2014-03-11 Thread Mark Walters
We will re-use the customize option for format-tags for formattting deleted tags to added tags in the next patch so split it into a widget. There should be no functional change. --- emacs/notmuch-tag.el | 55 ++--- 1 files changed, 29 insertions(+), 26

[Patch v3 0/8] emacs: show tag changes in buffer

2014-03-11 Thread Mark Walters
the original tags; tags which have been deleted (i.e., are in ORIG-TAGS but @@ -246,7 +249,7 @@ (defun notmuch-tag-format-tags (tags orig-tags &optional face) "Return a string representing formatted TAGS." (let ((face (or face 'notmuch-tag-face)) (all-tags (sort

[Patch v3 1/8] emacs: Combine notmuch-combine-face-text-property{, -string}

2014-03-11 Thread Mark Walters
From: Austin Clements This combines our two face combining functions into one, easy to use function with a much shorter name: `notmuch-apply-face'. This function takes the full set of arguments that `notmuch-combine-face-text-property' took, but takes them in a more convenient order and provides

[PATCH] notmuch new: add a --in-directory option

2014-03-06 Thread Mark Walters
This patch adds a --in-directory=folder option to notmuch new which tells it to only check for new messages inside folder (relative to the database root) --- NOTE This is only very lightly tested (but seems to work) so please make sure you backup the notmuch database before testing! notmuch-new

[PATCH] notmuch new: add a --in-directory option

2014-03-06 Thread Mark Walters
This patch adds a --in-directory=folder option to notmuch new which tells it to only check for new messages inside folder (relative to the database root) --- NOTE This is only very lightly tested (but seems to work) so please make sure you backup the notmuch database before testing! notmuch-new

[DRAFT PATCH] notmuch new: do not ignore '.notmuch' in non-toplevel directories

2014-03-01 Thread Mark Walters
An alternative would be to ignore any .notmuch path with a xapian sub-directory. This would mean if a user indexed some subset of their mail before trying to index the whole thing they wouldn't accidentally index the old xapian database. Alternatively we could just view the above as user error.

[PATCH v2] emacs: Simplify and fix `notmuch-mua-prompt-for-sender'

2014-03-01 Thread Mark Walters
This version is fine (thanks!). And the patch looks good to me too +1. Best wishes Mark On Thu, 27 Feb 2014, Austin Clements wrote: > `notmuch-mua-prompt-for-sender' is over-engineered and often wrong. > It attempts to detect when all identities have the same name and > specialize the prompt

Re: [DRAFT PATCH] notmuch new: do not ignore '.notmuch' in non-toplevel directories

2014-03-01 Thread Mark Walters
An alternative would be to ignore any .notmuch path with a xapian sub-directory. This would mean if a user indexed some subset of their mail before trying to index the whole thing they wouldn't accidentally index the old xapian database. Alternatively we could just view the above as user error.

Re: [PATCH v2] emacs: Simplify and fix `notmuch-mua-prompt-for-sender'

2014-03-01 Thread Mark Walters
This version is fine (thanks!). And the patch looks good to me too +1. Best wishes Mark On Thu, 27 Feb 2014, Austin Clements wrote: > `notmuch-mua-prompt-for-sender' is over-engineered and often wrong. > It attempts to detect when all identities have the same name and > specialize the prompt

<    3   4   5   6   7   8   9   10   11   12   >