Re: [PATCH] Add hook inside notmuch-mua-reply

2023-12-11 Thread Sandra Snan
I missed the other notes. I'll do a v3 renaming to notmuch-mua-reply-functions. The reason I need message-id is because I need to call notmuch again to get other headers beyond what's included in the sexp, including autocrypt. But the suggestion to jam the entire sexp is good. I did that

Re: [PATCH] Add hook inside notmuch-mua-reply

2023-12-11 Thread David Bremner
Tomi Ollila writes: > > another thing what should be the parameters passed, and why. this change > adds (just) message-id but no reasoning (nor documentation) there... > I wonder if we should pass the whole (parsed) original message, for maximum flexibility?

Re: [PATCH] Add hook inside notmuch-mua-reply

2023-12-11 Thread Tomi Ollila
On Mon, Dec 11 2023, David Bremner wrote: > Sandra Snan writes: > > >> +(defvar in-notmuch-mua-reply-functions nil >> + "Functions to run after `notmuch-reply' was called successfully >> +without erroring. The functions get the message-id as a string >> +argument.") >> + > > Overall this looks

Re: [PATCH] Add hook inside notmuch-mua-reply

2023-12-11 Thread David Bremner
Sandra Snan writes: > +(defvar in-notmuch-mua-reply-functions nil > + "Functions to run after `notmuch-reply' was called successfully > +without erroring. The functions get the message-id as a string > +argument.") > + Overall this looks reasonable to me, but I'm not sure about the name.

[PATCH] Add hook inside notmuch-mua-reply

2023-12-10 Thread Sandra Snan
This hook is run after `notmuch reply` has been successfully called with the headers from the original message. --- Can we please get a hook inside notmuch-mua-reply in the Emacs frontend to notmuch? But not a hook for thunks but a hook that has access to the message-id for the message we are