Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-30 Thread Tomi Ollila
On Tue, Aug 30 2016, Tomi Ollila wrote: > On Tue, Aug 30 2016, Tomi Ollila wrote: > >> On Sat, Aug 27 2016, Erik Rybakken wrote: >> >>> Hi, >>> >>> Thanks Tomi and David for the feedback! >>> >>> On Fri, Aug 26, 2016 at 02:32:19PM +0300, Tomi Ollila wrote: >>> ... but I can think of one pr

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-30 Thread Tomi Ollila
On Tue, Aug 30 2016, Tomi Ollila wrote: > On Sat, Aug 27 2016, Erik Rybakken wrote: > >> Hi, >> >> Thanks Tomi and David for the feedback! >> >> On Fri, Aug 26, 2016 at 02:32:19PM +0300, Tomi Ollila wrote: >> >>> ... but I can think of one problem there (if my memory server correctly) >> >> Yeah

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-30 Thread David Bremner
Erik Rybakken writes: >> >> 1) there is one indentation mismatch ;/ > > I'm not sure what you refer to here. Could you point me to it? I'm not sure either, but a good way to check is % uncrustify [--replace] --config devel/uncrustify.cfg $file Then git diff will tell you what uncrustify found

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-30 Thread Erik Rybakken
On Tue, Aug 30, 2016 at 08:43:20AM +0300, Tomi Ollila wrote: > The code looked pretty good -- when did I git am to the email content > I got all from the beginning of this email to the commit message -- > so before next patches use git-format-patch and git-am... Check > > https://notmuchmail.org/c

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-29 Thread Tomi Ollila
On Sat, Aug 27 2016, Erik Rybakken wrote: > Hi, > > Thanks Tomi and David for the feedback! > > On Fri, Aug 26, 2016 at 02:32:19PM +0300, Tomi Ollila wrote: > >> ... but I can think of one problem there (if my memory server correctly) > > Yeah, I didn't think of that. I have been thinking about h

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-27 Thread Erik Rybakken
Hi, Thanks Tomi and David for the feedback! On Fri, Aug 26, 2016 at 02:32:19PM +0300, Tomi Ollila wrote: > ... but I can think of one problem there (if my memory server correctly) Yeah, I didn't think of that. I have been thinking about how to make the generated configuration show only the opti

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-26 Thread Tomi Ollila
On Thu, Aug 25 2016, Erik Rybakken wrote: > Hi again, > > I implemented the option for hooks myself. The patch is included. Please > bear with me, this is my first contribution to notmuch (and my first > attempt to write C code). I tested the option, and it seems to work. The implementation look

Re: [PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-26 Thread David Bremner
Erik Rybakken writes: > Hi again, > > I implemented the option for hooks myself. The patch is included. Please > bear with me, this is my first contribution to notmuch (and my first > attempt to write C code). I tested the option, and it seems to work. > > Best, > Erik Welcome. You may find http

[PATCH] Add option `hooks.path` for setting the directory of hooks.

2016-08-24 Thread Erik Rybakken
Hi again, I implemented the option for hooks myself. The patch is included. Please bear with me, this is my first contribution to notmuch (and my first attempt to write C code). I tested the option, and it seems to work. Best, Erik On Wed, Aug 24, 2016 at 08:45:36PM +0300, Jani Nikula wrote: > O