On Mon, 18 Jul 2011 11:30:53 -0700, Jameson Graef Rollins wrote:
Non-text part: multipart/signed
> On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller wrote:
> > Ok, tried again :)
>
> Hey, Felix. It looks like the two attachments to your email are
> actually the emails generated by format-patch
On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller wrote:
> Ok, tried again :)
Hey, Felix. It looks like the two attachments to your email are
actually the emails generated by format-patch that should have been sent
to the list. Instead of attaching them to other emails, send them to
the list
On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller fgel...@gmail.com wrote:
Ok, tried again :)
Hey, Felix. It looks like the two attachments to your email are
actually the emails generated by format-patch that should have been sent
to the list. Instead of attaching them to other emails, send
On Mon, 18 Jul 2011 11:30:53 -0700, Jameson Graef Rollins
jroll...@finestructure.net wrote:
Non-text part: multipart/signed
On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller fgel...@gmail.com wrote:
Ok, tried again :)
Hey, Felix. It looks like the two attachments to your email are
On Mon, 18 Jul 2011 21:04:17 +0200, Felix Geller fgel...@gmail.com wrote:
Used git send-email this time, did that turn out correctly? :)
It looks good, except you need some commit messages. Have a look at the
existing commits to get an idea of what the standards are. Particularly
look at
On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller wrote:
> I attached two commits. One that includes the changes (which have most
> comments incorporated, only that I stick to when rather than if) and one
> that includes a test. I still can't run the tests myself, I attached an
> excerpt of what
On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller fgel...@gmail.com wrote:
I attached two commits. One that includes the changes (which have most
comments incorporated, only that I stick to when rather than if) and one
that includes a test. I still can't run the tests myself, I attached an
On Mon, 11 Jul 2011 11:24:57 +0200, Felix Geller wrote:
> Hi Dmitry,
>
> thank you for the comments. I included an updated patch that also
> includes Daniel's comment regarding the default value.
>
Another thing that would be nice to have is a test for this feature.
Regards,
Dmitry
> I
Hi Felix.
On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller wrote:
> Hi,
>
> I added a variable to toggle message indentation in Emacs.
>
> Please let me know what you think.
>
I like the change. Though I do not think I would use it without
chronological sorting.
Comments on the code below.
On Mon, 11 Jul 2011 13:55:24 +0400, Dmitry Kurochkin wrote:
> On Mon, 11 Jul 2011 11:24:57 +0200, Felix Geller wrote:
> > Hi Dmitry,
> >
> > thank you for the comments. I included an updated patch that also
> > includes Daniel's comment regarding the default value.
> >
>
> Another thing that
Hi Dmitry,
thank you for the comments. I included an updated patch that also
includes Daniel's comment regarding the default value.
I didn't change the "when" though--not because of personal reasons
;)--but because it is used for determining indentation of multi-parts.
Cheers,
Felix
On
Hi Felix,
On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller wrote:
> +(defcustom notmuch-show-indent-messages-in-thread nil
> + "Should the messages in a thread be indented according to their respective
> depth in the thread?"
> + :group 'notmuch
> + :type 'boolean)
> +
I think this should
Hi,
I added a variable to toggle message indentation in Emacs.
Please let me know what you think.
Cheers,
Felix
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a433dec..8101c27 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -90,6 +90,11 @@ any given
Hi Dmitry,
thank you for the comments. I included an updated patch that also
includes Daniel's comment regarding the default value.
I didn't change the when though--not because of personal reasons
;)--but because it is used for determining indentation of multi-parts.
Cheers,
Felix
On Mon,
On Mon, 11 Jul 2011 11:24:57 +0200, Felix Geller fgel...@gmail.com wrote:
Hi Dmitry,
thank you for the comments. I included an updated patch that also
includes Daniel's comment regarding the default value.
Another thing that would be nice to have is a test for this feature.
Regards,
On Mon, 11 Jul 2011 13:55:24 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On Mon, 11 Jul 2011 11:24:57 +0200, Felix Geller fgel...@gmail.com wrote:
Hi Dmitry,
thank you for the comments. I included an updated patch that also
includes Daniel's comment regarding the default
On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller fgel...@gmail.com wrote:
I added a variable to toggle message indentation in Emacs.
Hi, Felix. Thanks for submitting this patch. I think it's a good idea.
I have a couple of comments below, a couple of which echo what Dmitry
has already pointed
17 matches
Mail list logo
