Jinwoo Lee writes:
> Thanks for the review, guys. Sent yet another patch. BTW I'm not sure
> if I should specify --in-reply-to when sending updates.
>
> -jinwoo
It's up to you. I generally specify in-reply-to unless the thread alread
seems too long.
d
Jinwoo Lee writes:
> And what's the process for checking the code in? I just push to the
> repo?
>
> -jinwoo
Hi Jinwoo;
I pushed it. We're pretty miserly with push access, but once you get
through the reviews, getting the code in is quick.
Welcome aboard ;).
d
On Mon, Feb 02 2015, Jinwoo Lee wrote:
> It's default value is ".", meaning all remote images will be blocked
> by default.
>
> ---
> Addressed review comments.
Ok, looks good to me. David can perhaps amend away the (accidental)
whitespace change in the last hunk ?
Tomi
> ---
>
On Mon, Feb 2, 2015 at 02:15 PM, David Bremner wrote:
> Jinwoo Lee writes:
>
>> And what's the process for checking the code in? I just push to the
>> repo?
>>
>> -jinwoo
>
> Hi Jinwoo;
>
> I pushed it. We're pretty miserly with push access, but once you get
> through the reviews, getting the
And what's the process for checking the code in? I just push to the
repo?
-jinwoo
It's default value is ".", meaning all remote images will be blocked
by default.
---
Addressed review comments.
---
emacs/notmuch-show.el | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index
On Mon, Feb 2, 2015 at 12:32 PM, Tomi Ollila wrote:
> On Mon, Feb 02 2015, Jinwoo Lee wrote:
>
>> It's default value is ".", meaning all remote images will be blocked
>> by default.
>>
>> ---
>> Addressed review comments.
>
> Ok, looks good to me. David can perhaps amend away the (accidental)
>
Thanks for the review, guys. Sent yet another patch. BTW I'm not sure
if I should specify --in-reply-to when sending updates.
-jinwoo
It's default value is ".", meaning all remote images will be blocked
by default.
---
Addressed review comments.
---
emacs/notmuch-show.el | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index
And what's the process for checking the code in? I just push to the
repo?
-jinwoo
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Jinwoo Lee jinwo...@gmail.com writes:
Thanks for the review, guys. Sent yet another patch. BTW I'm not sure
if I should specify --in-reply-to when sending updates.
-jinwoo
It's up to you. I generally specify in-reply-to unless the thread alread
seems too long.
d
On Mon, Feb 2, 2015 at 02:15 PM, David Bremner da...@tethera.net wrote:
Jinwoo Lee jinwo...@gmail.com writes:
And what's the process for checking the code in? I just push to the
repo?
-jinwoo
Hi Jinwoo;
I pushed it. We're pretty miserly with push access, but once you get
through the
Jinwoo Lee jinwo...@gmail.com writes:
And what's the process for checking the code in? I just push to the
repo?
-jinwoo
Hi Jinwoo;
I pushed it. We're pretty miserly with push access, but once you get
through the reviews, getting the code in is quick.
Welcome aboard ;).
d
It's default value is ., meaning all remote images will be blocked
by default.
---
Addressed review comments.
---
emacs/notmuch-show.el | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index
On Mon, Feb 02 2015, Jinwoo Lee jinwo...@gmail.com wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
Addressed review comments.
Ok, looks good to me. David can perhaps amend away the (accidental)
whitespace change in the last hunk ?
Tomi
---
On Mon, Feb 2, 2015 at 12:32 PM, Tomi Ollila tomi.oll...@iki.fi wrote:
On Mon, Feb 02 2015, Jinwoo Lee jinwo...@gmail.com wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
Addressed review comments.
Ok, looks good to me. David can perhaps amend
It's default value is ., meaning all remote images will be blocked
by default.
---
Addressed review comments.
---
emacs/notmuch-show.el | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index
Thanks for the review, guys. Sent yet another patch. BTW I'm not sure
if I should specify --in-reply-to when sending updates.
-jinwoo
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
On Sun, Feb 01 2015, Tomi Ollila wrote:
> On Sun, Feb 01 2015, David Edmondson wrote:
>
>> On Thu, Jan 29 2015, Jinwoo Lee wrote:
>>> It's default value is ".", meaning all remote images will be blocked
>>> by default.
>>>
>>> ---
>>> This time setting gnus-blocked-images from the correct
On Sun, Feb 01 2015, David Edmondson wrote:
> On Thu, Jan 29 2015, Jinwoo Lee wrote:
>> It's default value is ".", meaning all remote images will be blocked
>> by default.
>>
>> ---
>> This time setting gnus-blocked-images from the correct place.
>
> Looks good - it is better than the code
On Thu, Jan 29 2015, Jinwoo Lee wrote:
> It's default value is ".", meaning all remote images will be blocked
> by default.
>
> ---
> This time setting gnus-blocked-images from the correct place.
> ---
> emacs/notmuch-show.el | 23 ++-
> 1 file changed, 18 insertions(+), 5
On Thu, Jan 29 2015, Jinwoo Lee wrote:
> It's default value is ".", meaning all remote images will be blocked
> by default.
>
> ---
> This time setting gnus-blocked-images from the correct place.
Looks good - it is better than the code currently in the repository,
even if it doesn?t address every
On Thu, Jan 29 2015, Jinwoo Lee wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
This time setting gnus-blocked-images from the correct place.
Looks good - it is better than the code currently in the repository,
even if it doesn’t address every
On Thu, Jan 29 2015, Jinwoo Lee jinwo...@gmail.com wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
This time setting gnus-blocked-images from the correct place.
---
emacs/notmuch-show.el | 23 ++-
1 file changed, 18
On Sun, Feb 01 2015, Tomi Ollila tomi.oll...@iki.fi wrote:
On Sun, Feb 01 2015, David Edmondson d...@dme.org wrote:
On Thu, Jan 29 2015, Jinwoo Lee wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
This time setting gnus-blocked-images from the
On Sun, Feb 01 2015, David Edmondson d...@dme.org wrote:
On Thu, Jan 29 2015, Jinwoo Lee wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
This time setting gnus-blocked-images from the correct place.
Looks good - it is better than the code
Can someone take a look please?
On Thu, Jan 29, 2015 at 01:35 PM, Jinwoo Lee wrote:
> It's default value is ".", meaning all remote images will be blocked
> by default.
>
> ---
> This time setting gnus-blocked-images from the correct place.
> ---
> emacs/notmuch-show.el | 23
Can someone take a look please?
On Thu, Jan 29, 2015 at 01:35 PM, Jinwoo Lee jinwo...@gmail.com wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
This time setting gnus-blocked-images from the correct place.
---
emacs/notmuch-show.el | 23
It's default value is ".", meaning all remote images will be blocked
by default.
---
This time setting gnus-blocked-images from the correct place.
---
emacs/notmuch-show.el | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-show.el
It's default value is ".", meaning all remote images will be blocked
by default.
---
emacs/notmuch-show.el | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 66350d4..cc6aca9 100644
--- a/emacs/notmuch-show.el
It's default value is ., meaning all remote images will be blocked
by default.
---
emacs/notmuch-show.el | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 66350d4..cc6aca9 100644
--- a/emacs/notmuch-show.el
+++
It's default value is ., meaning all remote images will be blocked
by default.
---
This time setting gnus-blocked-images from the correct place.
---
emacs/notmuch-show.el | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-show.el
32 matches
Mail list logo
