On 05/26/2011 06:04 PM, Carl Worth wrote:
> 2. The hello screen is now lying a bit by saying "all tags".
>
>Perhaps if the user has the notmuch-hello-hide-tags variable set to
>non-nil the text might change somewhat? I'm not sure to what exactly.
maybe "all non-hidden tags" ?
On Wed, 25 May 2011 23:21:54 +0200, Daniel Schoepe wrote:
> I incorporated most of you recommendations in the attached patch.
Looks good, thanks!
I've pushed this out now.
I only have two suggestions:
1. Could you please add some basic testing for this?
The existing notmuch-hello tests
On Wed, 25 May 2011 18:42:30 -0400, Austin Clements wrote:
> 'Doh. That's what I get for not reading the surrounding code. I
> misunderstood what your patch was going for and assumed it was what
> *I* wanted notmuch to do, which is to show me useful counts (e.g.,
> unread count), but not to
On May 25, 2011 7:21 PM, "Daniel Schoepe"
wrote:
>
> On Wed, 25 May 2011 18:42:30 -0400, Austin Clements
wrote:
> > 'Doh. That's what I get for not reading the surrounding code. I
> > misunderstood what your patch was going for and assumed it was what
> > *I* wanted notmuch to do, which is to
On Wed, 25 May 2011 15:11:16 -0400, Austin Clements wrote:
> At least in Emacs 23.3.1, it has to be (const :tag "tag:TAG" nil). I
> didn't think the order mattered, but the tag didn't display otherwise.
> It would also be good to give descriptive tags to the other choices.
>
> It would be more
On Wed, 25 May 2011 23:21:54 +0200, Daniel Schoepe
daniel.scho...@googlemail.com wrote:
I incorporated most of you recommendations in the attached patch.
Looks good, thanks!
I've pushed this out now.
I only have two suggestions:
1. Could you please add some basic testing for this?
The
On 05/26/2011 06:04 PM, Carl Worth wrote:
2. The hello screen is now lying a bit by saying all tags.
Perhaps if the user has the notmuch-hello-hide-tags variable set to
non-nil the text might change somewhat? I'm not sure to what exactly.
maybe all non-hidden tags ?
--dkg
I accidentally used `filter' in the previous patch which isn't defined
by default during runtime, updated version in the attachment.
-- next part --
A non-text attachment was scrubbed...
Name: 0001-emacs-Make-queries-used-in-the-all-tags-section-conf.patch
Type:
On Wed, 25 May 2011 10:44:51 -0400, Austin Clements wrote:
> May I suggest a slightly different way of looking at this that will
> quell my inner parser? Instead of configuring a weird "query
> fragment" like "and tag:unread" to be string-concatenated with the tag
> query, configure a *filter*
On Wed, May 25, 2011 at 5:21 PM, Daniel Schoepe
wrote:
> On Wed, 25 May 2011 15:11:16 -0400, Austin Clements
> wrote:
>> So, perhaps something like
>>
>> (defcustom notmuch-hello-tag-list-counts nil
>> ? "Method for generating counts displayed in the all tags list.
>>
>> This variable controls
On Thu, 26 May 2011 01:21:17 +0200, Daniel Schoepe wrote:
> Since the main difference between those sections is the clear visual
> distinction, it might be an option to provide the user with functions to
> easily declare new sections for the hello screen, where this sort of
> thing is
On Wed, May 25, 2011 at 1:56 PM, Daniel Schoepe
wrote:
> I accidentally used `filter' in the previous patch which isn't defined
> by default during runtime, updated version in the attachment.
Cool. My inner parser is happy.
A few comments on the code:
> +(defcustom
On Wed, 25 May 2011 00:10:43 -0400, Austin Clements wrote:
> Out of curiosity, what use cases do you envision for this? So far
> I've only heard two, both of which seem like great ideas, but neither
> of which require such a heavy-handed solution: displaying unread
> counts for tags rather than
On Wed, May 25, 2011 at 6:04 AM, Daniel Schoepe
wrote:
> On Wed, 25 May 2011 00:10:43 -0400, Austin Clements
> wrote:
>> Out of curiosity, what use cases do you envision for this? ?So far
>> I've only heard two, both of which seem like great ideas, but neither
>> of which require such a
Out of curiosity, what use cases do you envision for this? So far
I've only heard two, both of which seem like great ideas, but neither
of which require such a heavy-handed solution: displaying unread
counts for tags rather than total counts, and hiding unused tags.
I would argue that we
On Tue, 24 May 2011 13:39:44 -0700, Carl Worth wrote:
> This seems like a useful feature, but perhaps it's a little too general?
>
> I'm imagining a user wanting to use this functionality but not knowing
> anything about writing an emacs-lisp function. For such a user, this
> variable won't
On Wed, 25 May 2011 00:10:43 -0400, Austin Clements amdra...@mit.edu wrote:
Out of curiosity, what use cases do you envision for this? So far
I've only heard two, both of which seem like great ideas, but neither
of which require such a heavy-handed solution: displaying unread
counts for tags
On Wed, May 25, 2011 at 6:04 AM, Daniel Schoepe
daniel.scho...@googlemail.com wrote:
On Wed, 25 May 2011 00:10:43 -0400, Austin Clements amdra...@mit.edu wrote:
Out of curiosity, what use cases do you envision for this? So far
I've only heard two, both of which seem like great ideas, but
, 20 May 2011 00:53:50 +0200
Subject: [PATCH] emacs: Make queries used in the all-tags section
configurable
This patch adds a customization variable that controls what queries
are used to construct the all-tags section in notmuch-hello. It allows
the user to specify a function to construct
Subject: [PATCH] emacs: Make queries used in the all-tags section
configurable
This patch adds a customization variable that controls what queries
are used to construct the all-tags section in notmuch-hello. It allows
the user to specify a function to construct the query given a tag or
a string
On Wed, May 25, 2011 at 1:56 PM, Daniel Schoepe
daniel.scho...@googlemail.com wrote:
I accidentally used `filter' in the previous patch which isn't defined
by default during runtime, updated version in the attachment.
Cool. My inner parser is happy.
A few comments on the code:
+(defcustom
without thinking about
performance.
I incorporated most of you recommendations in the attached patch.
From 2056a455cdec6b980426552b8dcd7055f6cd0805 Mon Sep 17 00:00:00 2001
From: Daniel Schoepe daniel.scho...@googlemail.com
Date: Fri, 20 May 2011 00:53:50 +0200
Subject: [PATCH] emacs: Make queries used
On Wed, May 25, 2011 at 5:21 PM, Daniel Schoepe
daniel.scho...@googlemail.com wrote:
On Wed, 25 May 2011 15:11:16 -0400, Austin Clements amdra...@mit.edu wrote:
So, perhaps something like
(defcustom notmuch-hello-tag-list-counts nil
Method for generating counts displayed in the all tags
On Wed, 25 May 2011 18:42:30 -0400, Austin Clements amdra...@mit.edu wrote:
'Doh. That's what I get for not reading the surrounding code. I
misunderstood what your patch was going for and assumed it was what
*I* wanted notmuch to do, which is to show me useful counts (e.g.,
unread count),
On Thu, 26 May 2011 01:21:17 +0200, Daniel Schoepe
daniel.scho...@googlemail.com wrote:
Since the main difference between those sections is the clear visual
distinction, it might be an option to provide the user with functions to
easily declare new sections for the hello screen, where this
On May 25, 2011 7:21 PM, Daniel Schoepe daniel.scho...@googlemail.com
wrote:
On Wed, 25 May 2011 18:42:30 -0400, Austin Clements amdra...@mit.edu
wrote:
'Doh. That's what I get for not reading the surrounding code. I
misunderstood what your patch was going for and assumed it was what
*I*
On Tue, 24 May 2011 23:01:16 +0200, Daniel Schoepe wrote:
> Another option would be to also allow various symbols like 'unread (meaning
> "tag:TAG and tag:unread") for "popular" queries in addition to a
> function.
Or, for a case like this the variable could accept a simple string to
append:
On Fri, 20 May 2011 01:18:35 +0200, Daniel Schoepe wrote:
> From the commit message:
>
> emacs: Make queries used in the all-tags section configurable
>
> This patch adds a customization variable that controls what queries
> are used to construct the all-tags section in
On Fri, 20 May 2011 01:18:35 +0200, Daniel Schoepe
daniel.scho...@googlemail.com wrote:
From the commit message:
emacs: Make queries used in the all-tags section configurable
This patch adds a customization variable that controls what queries
are used to construct the
On Tue, 24 May 2011 13:39:44 -0700, Carl Worth cwo...@cworth.org wrote:
This seems like a useful feature, but perhaps it's a little too general?
I'm imagining a user wanting to use this functionality but not knowing
anything about writing an emacs-lisp function. For such a user, this
Out of curiosity, what use cases do you envision for this? So far
I've only heard two, both of which seem like great ideas, but neither
of which require such a heavy-handed solution: displaying unread
counts for tags rather than total counts, and hiding unused tags.
I would argue that we
Sep 17 00:00:00 2001
From: Daniel Schoepe daniel.scho...@googlemail.com
Date: Fri, 20 May 2011 00:53:50 +0200
Subject: [PATCH] emacs: Make queries used in the all-tags section
configurable
This patch adds a customization variable that controls what queries
are used to construct the all-tags section
33 matches
Mail list logo
