[PATCH] emacs: notmuch-search: fix faces

2012-09-06 Thread Michal Nazarewicz
On Thu, Aug 23 2012, Michal Nazarewicz wrote: > For some reason the faces do not get applied when 'face property is > used, but they work correctly with 'font-lock-face property. This > commit changes notmuch-search to use the latter. OK, forget about this. The problem ?fixed itself? when I

Re: [PATCH] emacs: notmuch-search: fix faces

2012-09-05 Thread Michal Nazarewicz
On Thu, Aug 23 2012, Michal Nazarewicz wrote: For some reason the faces do not get applied when 'face property is used, but they work correctly with 'font-lock-face property. This commit changes notmuch-search to use the latter. OK, forget about this. The problem “fixed itself” when I

[PATCH] emacs: notmuch-search: fix faces

2012-09-03 Thread Michal Nazarewicz
Tomi Ollila writes: > Interesting problem; You could try stripping all customizations > (emacs -q ...) and see whether coloring works -- and if it does > then "bisect" (or something) the culprit. FYI, I've identified the problem. I'll follow up when I find the solution, or separate it into a

Re: [PATCH] emacs: notmuch-search: fix faces

2012-09-03 Thread Michal Nazarewicz
Tomi Ollila tomi.oll...@iki.fi writes: Interesting problem; You could try stripping all customizations (emacs -q ...) and see whether coloring works -- and if it does then bisect (or something) the culprit. FYI, I've identified the problem. I'll follow up when I find the solution, or separate

[PATCH] emacs: notmuch-search: fix faces

2012-08-30 Thread Tomi Ollila
On Tue, Aug 28 2012, Michal Nazarewicz wrote: >> Quoth Michal Nazarewicz on Aug 28 at 2:51 am: >>> I'm running Emacs compiled from a week old bzr head, emacs-version >>> reports: ?GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08-21 >>> on mpn-glaptop?. >>> >>> I don't think I have any

Re: [PATCH] emacs: notmuch-search: fix faces

2012-08-30 Thread Tomi Ollila
On Tue, Aug 28 2012, Michal Nazarewicz m...@google.com wrote: Quoth Michal Nazarewicz on Aug 28 at 2:51 am: I'm running Emacs compiled from a week old bzr head, emacs-version reports: “GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08-21 on mpn-glaptop”. I don't think I have any

[PATCH] emacs: notmuch-search: fix faces

2012-08-28 Thread Michal Nazarewicz
> Quoth Michal Nazarewicz on Aug 28 at 2:51 am: >> I'm running Emacs compiled from a week old bzr head, emacs-version >> reports: ?GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08-21 >> on mpn-glaptop?. >> >> I don't think I have any ?unusual? packages, but I do have quite a bit >> of

[PATCH] emacs: notmuch-search: fix faces

2012-08-28 Thread Michal Nazarewicz
> Quoth Michal Nazarewicz on Aug 28 at 1:11 am: >> I'm not an expert either, but with this patch applied I see colours, >> without this patch, I don't see colours, ie. everything is rendered >> using the default face. >> >> I'm also not entirely sure if that's the correct way of doing things >>

[PATCH] emacs: notmuch-search: fix faces

2012-08-28 Thread Michal Nazarewicz
> On Thu, Aug 23 2012, Michal Nazarewicz wrote: >> For some reason the faces do not get applied when 'face property is >> used, but they work correctly with 'font-lock-face property. This >> commit changes notmuch-search to use the latter. Jameson Graef Rollins writes: > Hi, Michal. Can you

[PATCH] emacs: notmuch-search: fix faces

2012-08-27 Thread Austin Clements
Quoth Michal Nazarewicz on Aug 28 at 2:51 am: > > Quoth Michal Nazarewicz on Aug 28 at 1:11 am: > >> I'm not an expert either, but with this patch applied I see colours, > >> without this patch, I don't see colours, ie. everything is rendered > >> using the default face. > >> > >> I'm also not

[PATCH] emacs: notmuch-search: fix faces

2012-08-27 Thread Austin Clements
Quoth Michal Nazarewicz on Aug 28 at 1:11 am: > > On Thu, Aug 23 2012, Michal Nazarewicz wrote: > >> For some reason the faces do not get applied when 'face property is > >> used, but they work correctly with 'font-lock-face property. This > >> commit changes notmuch-search to use the latter. >

[PATCH] emacs: notmuch-search: fix faces

2012-08-27 Thread Jameson Graef Rollins
On Thu, Aug 23 2012, Michal Nazarewicz wrote: > For some reason the faces do not get applied when 'face property is > used, but they work correctly with 'font-lock-face property. This > commit changes notmuch-search to use the latter. Hi, Michal. Can you say a bit more about what's motivating

Re: [PATCH] emacs: notmuch-search: fix faces

2012-08-27 Thread Jameson Graef Rollins
On Thu, Aug 23 2012, Michal Nazarewicz m...@google.com wrote: For some reason the faces do not get applied when 'face property is used, but they work correctly with 'font-lock-face property. This commit changes notmuch-search to use the latter. Hi, Michal. Can you say a bit more about what's

Re: [PATCH] emacs: notmuch-search: fix faces

2012-08-27 Thread Michal Nazarewicz
On Thu, Aug 23 2012, Michal Nazarewicz m...@google.com wrote: For some reason the faces do not get applied when 'face property is used, but they work correctly with 'font-lock-face property. This commit changes notmuch-search to use the latter. Jameson Graef Rollins

Re: [PATCH] emacs: notmuch-search: fix faces

2012-08-27 Thread Austin Clements
Quoth Michal Nazarewicz on Aug 28 at 1:11 am: On Thu, Aug 23 2012, Michal Nazarewicz m...@google.com wrote: For some reason the faces do not get applied when 'face property is used, but they work correctly with 'font-lock-face property. This commit changes notmuch-search to use the

Re: [PATCH] emacs: notmuch-search: fix faces

2012-08-27 Thread Michal Nazarewicz
Quoth Michal Nazarewicz on Aug 28 at 1:11 am: I'm not an expert either, but with this patch applied I see colours, without this patch, I don't see colours, ie. everything is rendered using the default face. I'm also not entirely sure if that's the correct way of doing things since 'face

Re: [PATCH] emacs: notmuch-search: fix faces

2012-08-27 Thread Austin Clements
Quoth Michal Nazarewicz on Aug 28 at 2:51 am: Quoth Michal Nazarewicz on Aug 28 at 1:11 am: I'm not an expert either, but with this patch applied I see colours, without this patch, I don't see colours, ie. everything is rendered using the default face. I'm also not entirely sure if

[PATCH] emacs: notmuch-search: fix faces

2012-08-23 Thread Michal Nazarewicz
From: Michal Nazarewicz For some reason the faces do not get applied when 'face property is used, but they work correctly with 'font-lock-face property. This commit changes notmuch-search to use the latter. --- emacs/notmuch.el | 23 +-- 1 files

[PATCH] emacs: notmuch-search: fix faces

2012-08-23 Thread Michal Nazarewicz
From: Michal Nazarewicz min...@mina86.com For some reason the faces do not get applied when 'face property is used, but they work correctly with 'font-lock-face property. This commit changes notmuch-search to use the latter. --- emacs/notmuch.el | 23 +-- 1 files changed,