[PATCH] emacs: show: lazy part handling bugfix

2013-09-10 Thread David Bremner
Mark Walters writes: > The lazy part handler had a bug that it allowed the button to be > toggled to be specified. During toggling it needs to save and restore > the text-properties for the button but it actually saved the text > properties at point rather than from the button. pushed, d

Re: [PATCH] emacs: show: lazy part handling bugfix

2013-09-10 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: The lazy part handler had a bug that it allowed the button to be toggled to be specified. During toggling it needs to save and restore the text-properties for the button but it actually saved the text properties at point rather than from the

[PATCH] emacs: show: lazy part handling bugfix

2013-09-09 Thread Austin Clements
Nice sleuthing! LGTM. One question, though. `notmuch-show-insert-bodypart' calls `notmuch-show-toggle-part-invisibility' with point at the end of the buffer and not on the button. Without this patch, properties will be nil as a result, but with this patch, they may not be. This still seems

Re: [PATCH] emacs: show: lazy part handling bugfix

2013-09-09 Thread Austin Clements
Nice sleuthing! LGTM. One question, though. `notmuch-show-insert-bodypart' calls `notmuch-show-toggle-part-invisibility' with point at the end of the buffer and not on the button. Without this patch, properties will be nil as a result, but with this patch, they may not be. This still seems

[PATCH] emacs: show: lazy part handling bugfix

2013-09-07 Thread Mark Walters
The lazy part handler had a bug that it allowed the button to be toggled to be specified. During toggling it needs to save and restore the text-properties for the button but it actually saved the text properties at point rather than from the button. In almost all cases this didn't matter as as

[PATCH] emacs: show: lazy part handling bugfix

2013-09-06 Thread Mark Walters
The lazy part handler had a bug that it allowed the button to be toggled to be specified. During toggling it needs to save and restore the text-properties for the button but it actually saved the text properties at point rather than from the button. In almost all cases this didn't matter as as