[PATCH] new: read db_files and db_subdirs if mtime changed

2011-03-10 Thread Carl Worth
On Fri, 4 Feb 2011 22:44:31 +0100, Karel Zak wrote: > The db_files and db_subdirs are unnecessary for unchanged directories. ... > old version: real0m0.053s > new version: real0m0.032s Thanks Karel! What a lovely optimization. On Sun, 27 Feb 2011 03:45:05 -0500, Austin Clements wrote:

Re: [PATCH] new: read db_files and db_subdirs if mtime changed

2011-03-10 Thread Carl Worth
On Fri, 4 Feb 2011 22:44:31 +0100, Karel Zak k...@redhat.com wrote: The db_files and db_subdirs are unnecessary for unchanged directories. ... old version: real0m0.053s new version: real0m0.032s Thanks Karel! What a lovely optimization. On Sun, 27 Feb 2011 03:45:05 -0500, Austin

[PATCH] new: read db_files and db_subdirs if mtime changed

2011-02-27 Thread Austin Clements
Looks good (faster than, but provably equivalent to the original code! notmuch_directory_get_child_* are side-effect free, db_files/db_subdirs aren't used between where they were set in the old code and where they are set in the new code, and db_files/db_subdirs are initialized to NULL when

Re: [PATCH] new: read db_files and db_subdirs if mtime changed

2011-02-27 Thread Austin Clements
Looks good (faster than, but provably equivalent to the original code! notmuch_directory_get_child_* are side-effect free, db_files/db_subdirs aren't used between where they were set in the old code and where they are set in the new code, and db_files/db_subdirs are initialized to NULL when

[PATCH] new: read db_files and db_subdirs if mtime changed

2011-02-04 Thread Karel Zak
The db_files and db_subdirs are unnecessary for unchanged directories. maildir with 1 e-mails: old version: $ time ./notmuch new No new mail. real0m0.053s user0m0.028s sys 0m0.026s new version: $ time ./notmuch new No new