[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-12 Thread David Bremner
Mark Walters writes: > The string function in a sprinter may be called with a NULL string > pointer (eg if a header is absent). This causes a segfault. We fix > this by checking for a null pointer in the string functions pushed, d

Re: [PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-12 Thread David Bremner
Mark Walters writes: > The string function in a sprinter may be called with a NULL string > pointer (eg if a header is absent). This causes a segfault. We fix > this by checking for a null pointer in the string functions pushed, d ___ notmuch mailin

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-08 Thread Mark Walters
The string function in a sprinter may be called with a NULL string pointer (eg if a header is absent). This causes a segfault. We fix this by checking for a null pointer in the string functions and update the sprinter documentation. At the moment some output when format=text is done directly rath

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-08 Thread Austin Clements
LGTM! Quoth Mark Walters on Aug 08 at 10:23 pm: > > The string function in a sprinter may be called with a NULL string > pointer (eg if a header is absent). This causes a segfault. We fix > this by checking for a null pointer in the string functions and update > the sprinter documentation. > > A

Re: [PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-08 Thread Austin Clements
LGTM! Quoth Mark Walters on Aug 08 at 10:23 pm: > > The string function in a sprinter may be called with a NULL string > pointer (eg if a header is absent). This causes a segfault. We fix > this by checking for a null pointer in the string functions and update > the sprinter documentation. > > A

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-08 Thread Mark Walters
The string function in a sprinter may be called with a NULL string pointer (eg if a header is absent). This causes a segfault. We fix this by checking for a null pointer in the string functions and update the sprinter documentation. At the moment some output when format=text is done directly rath

Re: [PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-08 Thread Jameson Graef Rollins
On Wed, Aug 08 2012, Mark Walters wrote: > For the From/Date headers see http://www.ietf.org/rfc/rfc2822.txt > section 3.6 for details: > >The only required header fields are the origination date field and >the originator address field(s). All other header fields are >syntactically op

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-08 Thread Jameson Graef Rollins
On Wed, Aug 08 2012, Mark Walters wrote: > For the From/Date headers see http://www.ietf.org/rfc/rfc2822.txt > section 3.6 for details: > >The only required header fields are the origination date field and >the originator address field(s). All other header fields are >syntactically op

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-08 Thread Mark Walters
On Wed, 08 Aug 2012, Austin Clements wrote: > LGTM. > > This won't commute with [0], since that introduces broken tests that are > fixed by this patch. Yes: I guess the tidiest might be for me to send a version of my patch which marks these tests fixed so it can be applied after this. > I think

Re: [PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-08 Thread Mark Walters
On Wed, 08 Aug 2012, Austin Clements wrote: > LGTM. > > This won't commute with [0], since that introduces broken tests that are > fixed by this patch. Yes: I guess the tidiest might be for me to send a version of my patch which marks these tests fixed so it can be applied after this. > I think

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-07 Thread Austin Clements
LGTM. This won't commute with [0], since that introduces broken tests that are fixed by this patch. I think we should remove the fields in the JSON header object for missing headers (except perhaps From and Date, if those really are mandatory headers), but I think we should do that after the free

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-07 Thread Mark Walters
The string function in a sprinter may be called with a NULL string pointer (eg if a header is absent). This causes a segfault. We fix this by checking for a null pointer in the string functions and update the sprinter documentation. At the moment some output when format=text is done directly rath

Re: [PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-07 Thread Austin Clements
LGTM. This won't commute with [0], since that introduces broken tests that are fixed by this patch. I think we should remove the fields in the JSON header object for missing headers (except perhaps From and Date, if those really are mandatory headers), but I think we should do that after the free

Re: [PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-07 Thread Jameson Graef Rollins
On Tue, Aug 07 2012, Mark Walters wrote: > The string function in a sprinter may be called with a NULL string > pointer (eg if a header is absent). This causes a segfault. We fix > this by checking for a null pointer in the string functions and update > the sprinter documentation. > > At the momen

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-07 Thread Jameson Graef Rollins
On Tue, Aug 07 2012, Mark Walters wrote: > The string function in a sprinter may be called with a NULL string > pointer (eg if a header is absent). This causes a segfault. We fix > this by checking for a null pointer in the string functions and update > the sprinter documentation. > > At the momen

[PATCH] sprinters: bugfix when NULL passed for a string.

2012-08-07 Thread Mark Walters
The string function in a sprinter may be called with a NULL string pointer (eg if a header is absent). This causes a segfault. We fix this by checking for a null pointer in the string functions and update the sprinter documentation. At the moment some output when format=text is done directly rath