[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread David Bremner
Jani Nikula writes: >> Of course you're right that moving it forward to only skip the gdb >> requiring tests is the right thing to do, and in that setting having a >> skipped message for all 10 skipped tests is a bit ugly. OTOHO your >> version doesn't give any output at all, which seems not

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread Jani Nikula
On Tue, 28 Oct 2014, David Bremner wrote: > Jani Nikula writes: > >> You need to actually check the return value. Limit the missing deps >> part to subtests requiring gdb. > > For me, on a system without gdb, the current version looks like > > T070-insert: Testing "notmuch insert" > missing

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread Jani Nikula
You need to actually check the return value. Limit the missing deps part to subtests requiring gdb. --- test/T070-insert.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index 168345c9897b..b21609833228 100755 ---

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread David Bremner
Jani Nikula writes: > You need to actually check the return value. Limit the missing deps > part to subtests requiring gdb. For me, on a system without gdb, the current version looks like T070-insert: Testing "notmuch insert" missing prerequisites: gdb(1) SKIP all tests in T070-insert

[PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread Jani Nikula
You need to actually check the return value. Limit the missing deps part to subtests requiring gdb. --- test/T070-insert.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index 168345c9897b..b21609833228 100755 ---

Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread David Bremner
Jani Nikula j...@nikula.org writes: You need to actually check the return value. Limit the missing deps part to subtests requiring gdb. For me, on a system without gdb, the current version looks like T070-insert: Testing notmuch insert missing prerequisites: gdb(1) SKIP all tests in

Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread Jani Nikula
On Tue, 28 Oct 2014, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: You need to actually check the return value. Limit the missing deps part to subtests requiring gdb. For me, on a system without gdb, the current version looks like T070-insert: Testing notmuch

Re: [PATCH] test: fix test_require_external_prereq gdb in insert test

2014-10-28 Thread David Bremner
Jani Nikula j...@nikula.org writes: Of course you're right that moving it forward to only skip the gdb requiring tests is the right thing to do, and in that setting having a skipped message for all 10 skipped tests is a bit ugly. OTOHO your version doesn't give any output at all, which seems