[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-22 Thread David Bremner
Ethan Glasser-Camp writes: > > Fix the failures by sorting the output of notmuch --debug and > comparing this to a hand-sorted version of its output. Pushed. Good to see the debug flag being put to use. d P.S. somebody also requested a quiet flag for notmuch new, if someone is looking for an

[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-22 Thread Austin Clements
LGTM. This is closely related to another problem in the test suite that causes frequent failures for me when I run on tmpfs: generate_message creates messages with the same time stamp by default, which means that the output of date-sorted notmuch search is technically non-deterministic. I

Re: [PATCH] test: new: Fix intermittent test failures with --debug

2012-10-22 Thread Austin Clements
LGTM. This is closely related to another problem in the test suite that causes frequent failures for me when I run on tmpfs: generate_message creates messages with the same time stamp by default, which means that the output of date-sorted notmuch search is technically non-deterministic. I

Re: [PATCH] test: new: Fix intermittent test failures with --debug

2012-10-22 Thread David Bremner
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: Fix the failures by sorting the output of notmuch --debug and comparing this to a hand-sorted version of its output. Pushed. Good to see the debug flag being put to use. d P.S. somebody also requested a quiet flag for notmuch new, if

[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Jameson Graef Rollins
On Sun, Oct 21 2012, Ethan Glasser-Camp wrote: > Although messages are created in a particular order, it seems that > when they are created on a tmpfs, they do not always come back in the > same order, leading to the same files being ignored but being output > in a different order. This causes

[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Ethan Glasser-Camp
Although messages are created in a particular order, it seems that when they are created on a tmpfs, they do not always come back in the same order, leading to the same files being ignored but being output in a different order. This causes the test to fail because the outputs being compared are

[PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Ethan Glasser-Camp
Although messages are created in a particular order, it seems that when they are created on a tmpfs, they do not always come back in the same order, leading to the same files being ignored but being output in a different order. This causes the test to fail because the outputs being compared are

Re: [PATCH] test: new: Fix intermittent test failures with --debug

2012-10-21 Thread Jameson Graef Rollins
On Sun, Oct 21 2012, Ethan Glasser-Camp ethan.glasser.c...@gmail.com wrote: Although messages are created in a particular order, it seems that when they are created on a tmpfs, they do not always come back in the same order, leading to the same files being ignored but being output in a