[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

2011-09-12 Thread Dmitry Kurochkin
On Sun, 11 Sep 2011 20:51:47 -0300, David Bremner wrote: > On Mon, 12 Sep 2011 03:30:54 +0400, Dmitry Kurochkin gmail.com> wrote: > > Hi David. > > IMHO this is not a good idea, because: > > > > 1. It introduces multiple places where the flag is reset. If new > >test_expect_* functions are

[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

2011-09-12 Thread Dmitry Kurochkin
Hi David. On Sun, 11 Sep 2011 20:11:54 -0300, david at tethera.net wrote: > From: David Bremner > > Commit 4cc6727 introduced the library function > test_subtest_known_broken which sets a variable > test_subtest_known_broken_ . Unfortunately this variable is not reset > if test_begin_subtest is

[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

2011-09-11 Thread David Bremner
On Mon, 12 Sep 2011 03:30:54 +0400, Dmitry Kurochkin wrote: > Hi David. > IMHO this is not a good idea, because: > > 1. It introduces multiple places where the flag is reset. If new >test_expect_* functions are added in the future, there would be more >of these. So it brings us more

[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

2011-09-11 Thread da...@tethera.net
From: David Bremner Commit 4cc6727 introduced the library function test_subtest_known_broken which sets a variable test_subtest_known_broken_ . Unfortunately this variable is not reset if test_begin_subtest is not called before the next test_expect_success or

[PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

2011-09-11 Thread david
From: David Bremner brem...@debian.org Commit 4cc6727 introduced the library function test_subtest_known_broken which sets a variable test_subtest_known_broken_ . Unfortunately this variable is not reset if test_begin_subtest is not called before the next test_expect_success or

Re: [PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

2011-09-11 Thread Dmitry Kurochkin
Hi David. On Sun, 11 Sep 2011 20:11:54 -0300, da...@tethera.net wrote: From: David Bremner brem...@debian.org Commit 4cc6727 introduced the library function test_subtest_known_broken which sets a variable test_subtest_known_broken_ . Unfortunately this variable is not reset if

Re: [PATCH] test: reset known_broken status in test_expect_equal and test_expect_equal_file

2011-09-11 Thread David Bremner
On Mon, 12 Sep 2011 03:30:54 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi David. IMHO this is not a good idea, because: 1. It introduces multiple places where the flag is reset. If new test_expect_* functions are added in the future, there would be more of these. So