Re: [PATCH] test: swap order of arguments of test_expect_equal

2017-04-06 Thread David Bremner
Tomi Ollila writes: > On Thu, Apr 06 2017, David Bremner wrote: > >> For some reason (probably inherited from git), the order arguments for >> test_expect_equal was "$output $expected"; this again matters when >> generating diffs. >> --- > > IMO these both

Re: [PATCH] test: swap order of arguments of test_expect_equal

2017-04-06 Thread Tomi Ollila
On Thu, Apr 06 2017, David Bremner wrote: > For some reason (probably inherited from git), the order arguments for > test_expect_equal was "$output $expected"; this again matters when > generating diffs. > --- IMO these both of these should use expected - output argument

[PATCH] test: swap order of arguments of test_expect_equal

2017-04-05 Thread David Bremner
For some reason (probably inherited from git), the order arguments for test_expect_equal was "$output $expected"; this again matters when generating diffs. --- I'm less sure about this one so I didn't go through and update all of the tests. The existing use of test_expect_equal is mostly