[PATCH 01/18] cli: add stub for insert command

2012-11-19 Thread Peter Wang
On Sun, 18 Nov 2012 17:35:23 +, Mark Walters wrote: > > Hi > > I have now been through essentially the whole series (except the tests) > and broadly like it. Just to summarise my concerns from the individual > replies here: Thanks for the review. > > What should insert do when

[PATCH 01/18] cli: add stub for insert command

2012-11-19 Thread Mark Walters
Hi On Mon, 19 Nov 2012, Peter Wang wrote: > On Sun, 18 Nov 2012 17:35:23 +, Mark Walters gmail.com> wrote: >> >> Hi >> >> I have now been through essentially the whole series (except the tests) >> and broadly like it. Just to summarise my concerns from the individual >> replies here: > >

[PATCH 01/18] cli: add stub for insert command

2012-11-19 Thread David Bremner
Jameson Graef Rollins writes: > > This is an interesting series, but let me play devil's advocate for a > moment: Why is this functionality needed? What can this functionality > do that notmuch new can't? Or how is it better? I feel like everything > that this series does can be done with

Re: [PATCH 01/18] cli: add stub for insert command

2012-11-19 Thread David Bremner
Jameson Graef Rollins jroll...@finestructure.net writes: This is an interesting series, but let me play devil's advocate for a moment: Why is this functionality needed? What can this functionality do that notmuch new can't? Or how is it better? I feel like everything that this series does

Re: [PATCH 01/18] cli: add stub for insert command

2012-11-19 Thread Peter Wang
On Sun, 18 Nov 2012 17:35:23 +, Mark Walters markwalters1...@gmail.com wrote: Hi I have now been through essentially the whole series (except the tests) and broadly like it. Just to summarise my concerns from the individual replies here: Thanks for the review. What should insert

Re: [PATCH 01/18] cli: add stub for insert command

2012-11-19 Thread Mark Walters
Hi On Mon, 19 Nov 2012, Peter Wang noval...@gmail.com wrote: On Sun, 18 Nov 2012 17:35:23 +, Mark Walters markwalters1...@gmail.com wrote: Hi I have now been through essentially the whole series (except the tests) and broadly like it. Just to summarise my concerns from the

[PATCH 01/18] cli: add stub for insert command

2012-11-18 Thread Mark Walters
Hi I have now been through essentially the whole series (except the tests) and broadly like it. Just to summarise my concerns from the individual replies here: What should insert do when interrupted and is it safe? I am not knowledgeable enough to be confident about that. I think some of the

Re: [PATCH 01/18] cli: add stub for insert command

2012-11-18 Thread Mark Walters
Hi I have now been through essentially the whole series (except the tests) and broadly like it. Just to summarise my concerns from the individual replies here: What should insert do when interrupted and is it safe? I am not knowledgeable enough to be confident about that. I think some of the

[PATCH 01/18] cli: add stub for insert command

2012-07-26 Thread Peter Wang
On Wed, 25 Jul 2012 10:11:14 -0700, Jameson Graef Rollins wrote: > > This is an interesting series, but let me play devil's advocate for a > moment: Why is this functionality needed? What can this functionality > do that notmuch new can't? My mail is stored on a remote server running notmuch.

[PATCH 01/18] cli: add stub for insert command

2012-07-26 Thread Peter Wang
This does nothing yet. --- Makefile.local |1 + notmuch-client.h |3 +++ notmuch-insert.c | 27 +++ notmuch.c|3 +++ 4 files changed, 34 insertions(+), 0 deletions(-) create mode 100644 notmuch-insert.c diff --git a/Makefile.local b/Makefile.local

[PATCH 01/18] cli: add stub for insert command

2012-07-25 Thread Jameson Graef Rollins
On Wed, Jul 25 2012, Peter Wang wrote: > This does nothing yet. Hi, Peter. This commit log is rather terse. Maybe the commit message should explain a bit what this stub is intended to do. This is an interesting series, but let me play devil's advocate for a moment: Why is this functionality

[PATCH 01/18] cli: add stub for insert command

2012-07-25 Thread Peter Wang
This does nothing yet. --- Makefile.local |1 + notmuch-client.h |3 +++ notmuch-insert.c | 27 +++ notmuch.c|3 +++ 4 files changed, 34 insertions(+), 0 deletions(-) create mode 100644 notmuch-insert.c diff --git a/Makefile.local b/Makefile.local

Re: [PATCH 01/18] cli: add stub for insert command

2012-07-25 Thread Jameson Graef Rollins
On Wed, Jul 25 2012, Peter Wang noval...@gmail.com wrote: This does nothing yet. Hi, Peter. This commit log is rather terse. Maybe the commit message should explain a bit what this stub is intended to do. This is an interesting series, but let me play devil's advocate for a moment: Why is

Re: [PATCH 01/18] cli: add stub for insert command

2012-07-25 Thread Peter Wang
On Wed, 25 Jul 2012 10:11:14 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This is an interesting series, but let me play devil's advocate for a moment: Why is this functionality needed? What can this functionality do that notmuch new can't? My mail is stored on a remote