Re: [PATCH 04/20] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state

2018-06-28 Thread Daniel Kahn Gillmor
On Fri 2018-06-15 07:16:05 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> +notmuch_status_t >> +_notmuch_message_crypto_set_sig_list (_notmuch_message_crypto_t >> *msg_crypto, GMimeSignatureList *sigs) >> +{ > > It's a bit confusing that nothing in this API/patch seems to use the

Re: [PATCH 04/20] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state

2018-06-15 Thread David Bremner
Daniel Kahn Gillmor writes: > +notmuch_status_t > +_notmuch_message_crypto_set_sig_list (_notmuch_message_crypto_t *msg_crypto, > GMimeSignatureList *sigs) > +{ It's a bit confusing that nothing in this API/patch seems to use the sig_list stored by this function > +void > +_notmuch_message_cry

[PATCH 04/20] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state

2018-05-10 Thread Daniel Kahn Gillmor
E-mail encryption and signatures reported by notmuch are at the MIME part level. This makes sense in the dirty details, but for users we need to have a per-message conception of the cryptographic state of the e-mail. (see https://dkg.fifthhorseman.net/blog/e-mail-cryptography.html for more discus