[PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

2014-02-21 Thread David Bremner
Tomi Ollila writes: > Python dict() object does not have __values__() function which > OrderedDict().values() (the stub provided in nmbug-status) could call > to provide ordered list of values. By renaming this thinko to > values() will make our stub work as expected -- dict items listed out > in

Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

2014-02-21 Thread David Bremner
Tomi Ollila writes: > Python dict() object does not have __values__() function which > OrderedDict().values() (the stub provided in nmbug-status) could call > to provide ordered list of values. By renaming this thinko to > values() will make our stub work as expected -- dict items listed out > in

[PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

2014-02-18 Thread Tomi Ollila
Python dict() object does not have __values__() function which OrderedDict().values() (the stub provided in nmbug-status) could call to provide ordered list of values. By renaming this thinko to values() will make our stub work as expected -- dict items listed out in order those were added to the d

Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

2014-02-18 Thread W. Trevor King
On Tue, Feb 18, 2014 at 08:34:52PM +0200, Tomi Ollila wrote: > -def __values__(self): > +def values(self): Looks good to me. I'm not sure why I used __values__ in the first place; probably just in the __ zone after __init__ and __setitem__. Cheers, Trevor -- This email may be s

[PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

2014-02-18 Thread W. Trevor King
On Tue, Feb 18, 2014 at 08:34:52PM +0200, Tomi Ollila wrote: > -def __values__(self): > +def values(self): Looks good to me. I'm not sure why I used __values__ in the first place; probably just in the __ zone after __init__ and __setitem__. Cheers, Trevor -- This email may be s

[PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub

2014-02-18 Thread Tomi Ollila
Python dict() object does not have __values__() function which OrderedDict().values() (the stub provided in nmbug-status) could call to provide ordered list of values. By renaming this thinko to values() will make our stub work as expected -- dict items listed out in order those were added to the d