[PATCH 1/4] show: indicate length of omitted body content (json)

2012-10-19 Thread Ethan Glasser-Camp
Peter Wang writes: > If a leaf part's body content is omitted, return the content length in > --format=json output. This information may be used by the consumer, > e.g. to decide whether to download a large attachment over a slow link. It looks like this patch series was thoroughly reviewed

Re: [PATCH 1/4] show: indicate length of omitted body content (json)

2012-10-19 Thread Ethan Glasser-Camp
Peter Wang noval...@gmail.com writes: If a leaf part's body content is omitted, return the content length in --format=json output. This information may be used by the consumer, e.g. to decide whether to download a large attachment over a slow link. It looks like this patch series was

[PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-08 Thread Peter Wang
On Wed, 08 Aug 2012 00:01:06 +0100, Mark Walters wrote: > > I have two minor queries: do you think omitted text/html parts should > also have the length given? Or even should it always be sent? But I am > happy with it as is. It could be added. I wouldn't have much use for it myself.

[PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-08 Thread Mark Walters
I like this (and agree with Austin and you that text and json can diverge). I just hacked something together which uses this and makes the emacs front-end display the content-length on part buttons and as someone who uses notmuch over ssh that is nice. I have two minor queries: do you think

[PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-08 Thread Peter Wang
On Mon, 6 Aug 2012 12:47:10 -0400, Austin Clements wrote: > What's the overall goal of adding this? Are you planning to add size > information to one of the frontends? Yes, to my frontend. >> > diff --git a/devel/schemata b/devel/schemata > > index 9cb25f5..3df2764 100644 > > ---

Re: [PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-08 Thread Peter Wang
On Wed, 08 Aug 2012 00:01:06 +0100, Mark Walters markwalters1...@gmail.com wrote: I have two minor queries: do you think omitted text/html parts should also have the length given? Or even should it always be sent? But I am happy with it as is. It could be added. I wouldn't have much use

[PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-07 Thread Austin Clements
Quoting Peter Wang : > On Mon, 6 Aug 2012 12:47:10 -0400, Austin Clements > wrote: >> What's the overall goal of adding this? Are you planning to add size >> information to one of the frontends? > > Yes, to my frontend. > >>> > diff --git a/devel/schemata b/devel/schemata >> > index

Re: [PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-07 Thread Peter Wang
On Mon, 6 Aug 2012 12:47:10 -0400, Austin Clements amdra...@mit.edu wrote: What's the overall goal of adding this? Are you planning to add size information to one of the frontends? Yes, to my frontend. diff --git a/devel/schemata b/devel/schemata index 9cb25f5..3df2764 100644 ---

Re: [PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-07 Thread Austin Clements
Quoting Peter Wang noval...@gmail.com: On Mon, 6 Aug 2012 12:47:10 -0400, Austin Clements amdra...@mit.edu wrote: What's the overall goal of adding this? Are you planning to add size information to one of the frontends? Yes, to my frontend. diff --git a/devel/schemata b/devel/schemata

Re: [PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-07 Thread Mark Walters
I like this (and agree with Austin and you that text and json can diverge). I just hacked something together which uses this and makes the emacs front-end display the content-length on part buttons and as someone who uses notmuch over ssh that is nice. I have two minor queries: do you think

Re: [PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-06 Thread Peter Wang
On Sun, 05 Aug 2012 14:37:02 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sun, Aug 05 2012, Peter Wang noval...@gmail.com wrote: diff --git a/devel/schemata b/devel/schemata index 9cb25f5..3df2764 100644 --- a/devel/schemata +++ b/devel/schemata @@ -69,7 +69,10 @@

[PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-05 Thread Peter Wang
If a leaf part's body content is omitted, return the content length in --format=json output. This information may be used by the consumer, e.g. to decide whether to download a large attachment over a slow link. --- devel/schemata |5 - notmuch-show.c |8 2 files changed, 12

[PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-05 Thread Jameson Graef Rollins
On Sun, Aug 05 2012, Peter Wang wrote: > If a leaf part's body content is omitted, return the content length in > --format=json output. This information may be used by the consumer, > e.g. to decide whether to download a large attachment over a slow link. > --- > devel/schemata |5 - >

[PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-05 Thread Tomi Ollila
On Sun, Aug 05 2012, Peter Wang wrote: > If a leaf part's body content is omitted, return the content length in > --format=json output. This information may be used by the consumer, > e.g. to decide whether to download a large attachment over a slow link. > --- Code looks good to me and tests

Re: [PATCH 1/4] show: indicate length of omitted body content (json)

2012-08-05 Thread Jameson Graef Rollins
On Sun, Aug 05 2012, Peter Wang noval...@gmail.com wrote: If a leaf part's body content is omitted, return the content length in --format=json output. This information may be used by the consumer, e.g. to decide whether to download a large attachment over a slow link. --- devel/schemata |