Re: [PATCH 2/2 v2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-21 Thread Daniel Kahn Gillmor
Thanks for the review, and for the poke about out-of-tree builds on IRC, Bremner. Another revision is coming in a minute. Notes below… On Thu 2020-05-21 20:29:05 -0300, David Bremner wrote: > I find these long lines with !! in the middle pretty surprising. Is > there some reason for this style?

Re: [PATCH 2/2 v2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-21 Thread David Bremner
Daniel Kahn Gillmor writes: > When checking cryptographic signatures, Notmuch relies on GMime to > tell it whether the certificate that signs a message has a valid User > ID or not. > > If the User ID is not valid, then notmuch does not report the signer's > User ID to the user. This means that

[PATCH 2/2 v2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-12 Thread Daniel Kahn Gillmor
When checking cryptographic signatures, Notmuch relies on GMime to tell it whether the certificate that signs a message has a valid User ID or not. If the User ID is not valid, then notmuch does not report the signer's User ID to the user. This means that the consumer of notmuch's cryptographic