[PATCH 2/3] emacs: show: add overlays for each part

2012-12-15 Thread Austin Clements
Quoth Mark Walters on Dec 13 at 8:54 am: > >> + (string= chosen-type > >> inner-type)) > > > > You could let-bind the (not (or ..)) to some variable ("hide" perhaps) > > in the let above to avoid this crazy line length. > > > >> inner-parts)

Re: [PATCH 2/3] emacs: show: add overlays for each part

2012-12-14 Thread Austin Clements
Quoth Mark Walters on Dec 13 at 8:54 am: + (string= chosen-type inner-type)) You could let-bind the (not (or ..)) to some variable (hide perhaps) in the let above to avoid this crazy line length. inner-parts) (when

[PATCH 2/3] emacs: show: add overlays for each part

2012-12-13 Thread Mark Walters
Hi Many thanks for the review: I will post a new version shortly. Some comments inline below: On Tue, 11 Dec 2012, Austin Clements wrote: > On Tue, 04 Dec 2012, Mark Walters wrote: >> This make notmuch-show-insert-bodypart add an overlay for any > > s/make/makes/ > >> non-trivial part with a

Re: [PATCH 2/3] emacs: show: add overlays for each part

2012-12-13 Thread Mark Walters
Hi Many thanks for the review: I will post a new version shortly. Some comments inline below: On Tue, 11 Dec 2012, Austin Clements acleme...@csail.mit.edu wrote: On Tue, 04 Dec 2012, Mark Walters markwalters1...@gmail.com wrote: This make notmuch-show-insert-bodypart add an overlay for any

[PATCH 2/3] emacs: show: add overlays for each part

2012-12-10 Thread Austin Clements
On Tue, 04 Dec 2012, Mark Walters wrote: > This make notmuch-show-insert-bodypart add an overlay for any s/make/makes/ > non-trivial part with a button header (currently the first text/plain > part does not have a button). At this point the overlay is available > to the button but there is no

Re: [PATCH 2/3] emacs: show: add overlays for each part

2012-12-10 Thread Austin Clements
On Tue, 04 Dec 2012, Mark Walters markwalters1...@gmail.com wrote: This make notmuch-show-insert-bodypart add an overlay for any s/make/makes/ non-trivial part with a button header (currently the first text/plain part does not have a button). At this point the overlay is available to the

[PATCH 2/3] emacs: show: add overlays for each part

2012-12-04 Thread Mark Walters
This make notmuch-show-insert-bodypart add an overlay for any non-trivial part with a button header (currently the first text/plain part does not have a button). At this point the overlay is available to the button but there is no action using it yet. In addition a not-shown variable which is

[PATCH 2/3] emacs: show: add overlays for each part

2012-12-04 Thread Mark Walters
This make notmuch-show-insert-bodypart add an overlay for any non-trivial part with a button header (currently the first text/plain part does not have a button). At this point the overlay is available to the button but there is no action using it yet. In addition a not-shown variable which is