LGTM other than what Mark pointed out about this not applying to
subjects in the search buffer.
Quoth David Edmondson on Jan 25 at 1:48 pm:
> ---
> emacs/notmuch-lib.el |6 ++
> emacs/notmuch-print.el |8 ++--
> emacs/notmuch-show.el |5 -
> emacs/notmuch.el |
LGTM other than what Mark pointed out about this not applying to
subjects in the search buffer.
Quoth David Edmondson on Jan 25 at 1:48 pm:
> ---
> emacs/notmuch-lib.el |6 ++
> emacs/notmuch-print.el |8 ++--
> emacs/notmuch-show.el |5 -
> emacs/notmuch.el |
On Fri, 27 Jan 2012 13:31:27 +, Mark Walters
wrote:
> Oh one other question: I think a search result line in the emacs
> interface just has a blank if a thread has no subject. Would it be
> appropriate to change that to [No Subject] too? (I have no preference)
Yes, makes sense. In the next v
Oh one other question: I think a search result line in the emacs
interface just has a blank if a thread has no subject. Would it be
appropriate to change that to [No Subject] too? (I have no preference)
Best wishes
Mark
On Fri, 27 Jan 2012 10:28:56 +, David Edmondson wrote:
> On Fri, 27 Ja
I am very much not a lisp expert but for what it's worth I read/reviewed
the patches and like them with a couple of minor queries that I am happy
to be overruled on
The patch 1/3 seems to set the show buffer line to *[No Subject]* where
it used to be just [No Subject]. (I have no preference: I ju
On Fri, 27 Jan 2012 10:23:07 +, Mark Walters
wrote:
> I am very much not a lisp expert
Me neither, so please do continue to review stuff.
> The patch 1/3 seems to set the show buffer line to *[No Subject]* where
> it used to be just [No Subject]. (I have no preference: I just wasn't
> sure
On Fri, 27 Jan 2012 13:31:27 +, Mark Walters
wrote:
> Oh one other question: I think a search result line in the emacs
> interface just has a blank if a thread has no subject. Would it be
> appropriate to change that to [No Subject] too? (I have no preference)
Yes, makes sense. In the next v
Oh one other question: I think a search result line in the emacs
interface just has a blank if a thread has no subject. Would it be
appropriate to change that to [No Subject] too? (I have no preference)
Best wishes
Mark
On Fri, 27 Jan 2012 10:28:56 +, David Edmondson wrote:
> On Fri, 27 Ja
I am very much not a lisp expert but for what it's worth I read/reviewed
the patches and like them with a couple of minor queries that I am happy
to be overruled on
The patch 1/3 seems to set the show buffer line to *[No Subject]* where
it used to be just [No Subject]. (I have no preference: I ju
On Fri, 27 Jan 2012 10:23:07 +, Mark Walters wrote:
> I am very much not a lisp expert
Me neither, so please do continue to review stuff.
> The patch 1/3 seems to set the show buffer line to *[No Subject]* where
> it used to be just [No Subject]. (I have no preference: I just wasn't
> sure i
---
emacs/notmuch-lib.el |6 ++
emacs/notmuch-print.el |8 ++--
emacs/notmuch-show.el |5 -
emacs/notmuch.el |5 +
4 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 241fe8c..5b8a41c 100644
---
On Wed, 25 Jan 2012 13:08:33 +, David Edmondson wrote:
> ---
> emacs/notmuch-lib.el |5 +
> emacs/notmuch-print.el |8 ++--
> emacs/notmuch-show.el |5 -
> emacs/notmuch.el |5 +
> 4 files changed, 16 insertions(+), 7 deletions(-)
Don't apply this one
---
emacs/notmuch-lib.el |5 +
emacs/notmuch-print.el |8 ++--
emacs/notmuch-show.el |5 -
emacs/notmuch.el |5 +
4 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 241fe8c..de33575 100644
--- a
---
emacs/notmuch-lib.el |6 ++
emacs/notmuch-print.el |8 ++--
emacs/notmuch-show.el |5 -
emacs/notmuch.el |5 +
4 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 241fe8c..5b8a41c 100644
---
On Wed, 25 Jan 2012 13:08:33 +, David Edmondson wrote:
> ---
> emacs/notmuch-lib.el |5 +
> emacs/notmuch-print.el |8 ++--
> emacs/notmuch-show.el |5 -
> emacs/notmuch.el |5 +
> 4 files changed, 16 insertions(+), 7 deletions(-)
Don't apply this one
---
emacs/notmuch-lib.el |5 +
emacs/notmuch-print.el |8 ++--
emacs/notmuch-show.el |5 -
emacs/notmuch.el |5 +
4 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 241fe8c..de33575 100644
--- a
16 matches
Mail list logo
