On Mon, 23 Jan 2012 17:55:14 +, David Edmondson wrote:
> On that basis, I hope no-one will complain if I fix them as a 'drive by'
> during another change...
Hrm. I don't think that follows. Unless the patch is already touching
that code, I would really prefer we continue to enforce that unr
On Mon, 23 Jan 2012 09:39:30 -0800, Jameson Graef Rollins
wrote:
> On Mon, 23 Jan 2012 11:02:04 +, David Edmondson wrote:
> > On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins
> > wrote:
> > > -(defun notmuch-show-next-open-message ()
> > > +(defun notmuch-show-next-open-message (&
On Mon, 23 Jan 2012 11:02:04 +, David Edmondson wrote:
> On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins
> wrote:
> > -(defun notmuch-show-next-open-message ()
> > +(defun notmuch-show-next-open-message (&optional pop-at-end)
> >"Show the next message."
> > - (interactive)
> >
On Mon, 23 Jan 2012 09:39:30 -0800, Jameson Graef Rollins wrote:
> On Mon, 23 Jan 2012 11:02:04 +, David Edmondson wrote:
> > On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins > finestructure.net> wrote:
> > > -(defun notmuch-show-next-open-message ()
> > > +(defun notmuch-show-next-
On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins wrote:
> -(defun notmuch-show-next-open-message ()
> +(defun notmuch-show-next-open-message (&optional pop-at-end)
>"Show the next message."
> - (interactive)
> - (let (r)
> + (interactive "P")
> + (let ((parent-buffer notmuch-show-
On Mon, 23 Jan 2012 17:55:14 +, David Edmondson wrote:
> On that basis, I hope no-one will complain if I fix them as a 'drive by'
> during another change...
Hrm. I don't think that follows. Unless the patch is already touching
that code, I would really prefer we continue to enforce that unr
On Mon, 23 Jan 2012 11:02:04 +, David Edmondson wrote:
> On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins finestructure.net> wrote:
> > -(defun notmuch-show-next-open-message ()
> > +(defun notmuch-show-next-open-message (&optional pop-at-end)
> >"Show the next message."
> > - (
On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins
wrote:
> -(defun notmuch-show-next-open-message ()
> +(defun notmuch-show-next-open-message (&optional pop-at-end)
>"Show the next message."
> - (interactive)
> - (let (r)
> + (interactive "P")
> + (let ((parent-buffer notmuch-show
This will allow for keybindings that achieve a smoother message
processing flow by reducing the number of key presses needed for most
common operations.
---
emacs/notmuch-show.el | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/no
This will allow for keybindings that achieve a smoother message
processing flow by reducing the number of key presses needed for most
common operations.
---
emacs/notmuch-show.el | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/no
On Wed, 18 Jan 2012 08:56:26 +, David Edmondson wrote:
> I'm used to the cursor going to the bottom of the thread to let me know
> that I reached the end, then I hit 'space' and move on to the next
> thread. Will that behaviour be retained with this patch? (Well,
> including your other patch w
On Wed, 18 Jan 2012 08:56:26 +, David Edmondson wrote:
> I'm used to the cursor going to the bottom of the thread to let me know
> that I reached the end, then I hit 'space' and move on to the next
> thread. Will that behaviour be retained with this patch? (Well,
> including your other patch w
On Wed, 18 Jan 2012 00:47:11 -0800, Jameson Graef Rollins wrote:
> > > (while (and (setq r (notmuch-show-goto-message-next))
> > > (not (notmuch-show-message-visible-p
> > > (if r
> > > (progn
> > > (notmuch-show-mark-read)
> > > (notmuch-show-message-adjust))
> >
On Tue, 17 Jan 2012 10:05:29 -0800, Jameson Graef Rollins wrote:
> -(defun notmuch-show-next-open-message ()
> +(defun notmuch-show-next-open-message (&optional pop-at-end)
>"Show the next message."
>(interactive)
> - (let (r)
> + (let ((r)
> + (parent-buffer notmuch-show-parent-buff
On Wed, 18 Jan 2012 00:47:11 -0800, Jameson Graef Rollins
wrote:
> > > (while (and (setq r (notmuch-show-goto-message-next))
> > > (not (notmuch-show-message-visible-p
> > > (if r
> > > (progn
> > > (notmuch-show-mark-read)
> > > (notmuch-show-message-adjust))
>
On Wed, 18 Jan 2012 08:12:27 +, David Edmondson wrote:
> No need for brackets around `r'. Please put initialised local variables
> before uninitialised.
Yeah, that's another comment of Aron's that I forgot to fix this time
around. Sorry about that.
> > (while (and (setq r (notmuch-show
On Wed, 18 Jan 2012 08:12:27 +, David Edmondson wrote:
> No need for brackets around `r'. Please put initialised local variables
> before uninitialised.
Yeah, that's another comment of Aron's that I forgot to fix this time
around. Sorry about that.
> > (while (and (setq r (notmuch-show
On Tue, 17 Jan 2012 10:05:29 -0800, Jameson Graef Rollins
wrote:
> -(defun notmuch-show-next-open-message ()
> +(defun notmuch-show-next-open-message (&optional pop-at-end)
>"Show the next message."
>(interactive)
> - (let (r)
> + (let ((r)
> + (parent-buffer notmuch-show-parent-buf
This will allow for keybindings that achieve a smoother message
processing flow by reducing the number of key presses needed for most
common operations.
---
emacs/notmuch-show.el | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmu
This will allow for keybindings that achieve a smoother message
processing flow by reducing the number of key presses needed for most
common operations.
---
emacs/notmuch-show.el | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmu
20 matches
Mail list logo
