On Sun, Oct 21 2012, Peter Wang wrote:
> On Fri, 19 Oct 2012 01:15:31 -0400, Ethan Glasser-Camp gmail.com> wrote:
>> Peter Wang writes:
>>
>> > Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
>> > cover all four values of search --exclude in the cli.
>>
>> This series looks good
On Fri, 19 Oct 2012 01:15:31 -0400, Ethan Glasser-Camp wrote:
> Peter Wang writes:
>
> > Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
> > cover all four values of search --exclude in the cli.
>
> This series looks good to me. It's a nice clean up and a nice new
> feature.
Peter Wang writes:
> Does it help if you add a "sleep 1" before the second generate_message
> call, i.e. on line 35?
It turns out that this test failure is sporadic (perhaps due to the fact
that I'm running on tmpfs) and exists even before this series. Doing
"sleep 1" makes it go away, but that
On Sun, Oct 21 2012, Peter Wang wrote:
On Fri, 19 Oct 2012 01:15:31 -0400, Ethan Glasser-Camp
ethan.glasser.c...@gmail.com wrote:
Peter Wang noval...@gmail.com writes:
Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
cover all four values of search --exclude in the cli.
Peter Wang noval...@gmail.com writes:
Does it help if you add a sleep 1 before the second generate_message
call, i.e. on line 35?
It turns out that this test failure is sporadic (perhaps due to the fact
that I'm running on tmpfs) and exists even before this series. Doing
sleep 1 makes it go
On Sat, Oct 20 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> It looks like you have better wording for patch 4/8 so I'd like to see
>> you resend it.
>>
>> I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!
>
> It turns out that patch 4 already has a v2 in the
On Sat, Oct 20 2012, Ethan Glasser-Camp wrote:
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
It looks like you have better wording for patch 4/8 so I'd like to see
you resend it.
I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!
It turns out that patch 4 already has
On Fri, 19 Oct 2012 01:15:31 -0400, Ethan Glasser-Camp
ethan.glasser.c...@gmail.com wrote:
Peter Wang noval...@gmail.com writes:
Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
cover all four values of search --exclude in the cli.
This series looks good to me. It's a nice
Ethan Glasser-Camp writes:
> It looks like you have better wording for patch 4/8 so I'd like to see
> you resend it.
>
> I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!
It turns out that patch 4 already has a v2 in the thread, but I didn't
see it due to some kind of selective
Peter Wang writes:
> Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
> cover all four values of search --exclude in the cli.
This series looks good to me. It's a nice clean up and a nice new
feature. Patches all apply.
However, I'm getting test failures like:
FAIL Search,
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
It looks like you have better wording for patch 4/8 so I'd like to see
you resend it.
I'm marking patches 3, 4, and 7 as moreinfo. Please resubmit!
It turns out that patch 4 already has a v2 in the thread, but I didn't
see it due to
Peter Wang noval...@gmail.com writes:
Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
cover all four values of search --exclude in the cli.
This series looks good to me. It's a nice clean up and a nice new
feature. Patches all apply.
However, I'm getting test failures like:
Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
cover all four values of search --exclude in the cli.
---
lib/notmuch.h|1 +
lib/query.cc |6 --
notmuch-search.c |2 +-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/notmuch.h
Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
cover all four values of search --exclude in the cli.
---
lib/notmuch.h|1 +
lib/query.cc |6 --
notmuch-search.c |2 +-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/notmuch.h
14 matches
Mail list logo
