[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-12 Thread David Bremner
On Mon, 09 Jan 2012 11:16:20 +, David Edmondson wrote: > On Mon, 09 Jan 2012 06:38:54 -0400, David Bremner > wrote: > Could you try running > (notmuch-dev-delete-branch > "review/patch-emacs-don't-signal-an-error-when-reaching-the-end-of-the-search-results") > when inside that

Re: [PATCH v2] emacs: Helpers for notmuch developers.

2012-01-12 Thread David Bremner
On Mon, 09 Jan 2012 11:16:20 +, David Edmondson d...@dme.org wrote: On Mon, 09 Jan 2012 06:38:54 -0400, David Bremner da...@tethera.net wrote: Could you try running (notmuch-dev-delete-branch review/patch-emacs-don't-signal-an-error-when-reaching-the-end-of-the-search-results) when

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
On Mon, 09 Jan 2012 06:38:54 -0400, David Bremner wrote: > > Oh. It's supposed to delete the existing branch. It did in my test. What > > happens for you? > > FWIW, I loaded notmuch-dev.el on top of current master. > > The magit buffer shows > > $ git --no-pager checkout -b >

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
On Sat, 07 Jan 2012 07:53:54 -0400, David Bremner wrote: > On Fri, 6 Jan 2012 10:03:19 +, David Edmondson wrote: > > --- > > > > - Prefix the branch name with 'review/' > > - Avoid `shell-command', which also results in better error reporting > > when 'git-am' fails. > > > > One thing

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Bremner
On Mon, 09 Jan 2012 08:23:53 +, David Edmondson wrote: > On Sat, 07 Jan 2012 07:53:54 -0400, David Bremner > wrote: > > On Fri, 6 Jan 2012 10:03:19 +, David Edmondson wrote: > > > --- > > > > > > - Prefix the branch name with 'review/' > > > - Avoid `shell-command', which also

Re: [PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
On Sat, 07 Jan 2012 07:53:54 -0400, David Bremner da...@tethera.net wrote: On Fri, 6 Jan 2012 10:03:19 +, David Edmondson d...@dme.org wrote: --- - Prefix the branch name with 'review/' - Avoid `shell-command', which also results in better error reporting when 'git-am' fails.

Re: [PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Bremner
On Mon, 09 Jan 2012 08:23:53 +, David Edmondson d...@dme.org wrote: On Sat, 07 Jan 2012 07:53:54 -0400, David Bremner da...@tethera.net wrote: On Fri, 6 Jan 2012 10:03:19 +, David Edmondson d...@dme.org wrote: --- - Prefix the branch name with 'review/' - Avoid

Re: [PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
On Mon, 09 Jan 2012 06:38:54 -0400, David Bremner da...@tethera.net wrote: Oh. It's supposed to delete the existing branch. It did in my test. What happens for you? FWIW, I loaded notmuch-dev.el on top of current master. The magit buffer shows $ git --no-pager checkout -b

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-07 Thread David Bremner
On Fri, 6 Jan 2012 10:03:19 +, David Edmondson wrote: > --- > > - Prefix the branch name with 'review/' > - Avoid `shell-command', which also results in better error reporting > when 'git-am' fails. > One thing I noticed is that reviewing a patch for the second time fails because the

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-06 Thread David Edmondson
--- - Prefix the branch name with 'review/' - Avoid `shell-command', which also results in better error reporting when 'git-am' fails. emacs/notmuch-dev.el | 129 ++ 1 files changed, 129 insertions(+), 0 deletions(-) create mode 100644

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-06 Thread David Edmondson
--- - Prefix the branch name with 'review/' - Avoid `shell-command', which also results in better error reporting when 'git-am' fails. emacs/notmuch-dev.el | 129 ++ 1 files changed, 129 insertions(+), 0 deletions(-) create mode 100644