[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-10-17 Thread Daniel Schoepe
On Mon, 17 Oct 2011 15:11:47 +0200, Thomas Schwinge wrote: > Ah, of course, right... Yet, won't yours -- id:\"[^ ]+\" -- match too > much in this example: > > Bla, bla, see id:"some at thing"--"some famous quote" is bla. > > How about this one? id:\(\"?\)[^[:space:]"]+\1 You're right,

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-10-17 Thread Thomas Schwinge
Hi! On Mon, 17 Oct 2011 14:13:05 +0200, Daniel Schoepe wrote: > On Mon, 17 Oct 2011 11:16:45 +0200, Thomas Schwinge > wrote: > > Is it permissible for message IDs to contain double quotes? If not (and > > I hope so), might id:\"[^\"]+\" be a better regexp? (Untested.) As it > > appears to

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-10-17 Thread Daniel Schoepe
On Mon, 17 Oct 2011 11:16:45 +0200, Thomas Schwinge wrote: > Is it permissible for message IDs to contain double quotes? If not (and > I hope so), might id:\"[^\"]+\" be a better regexp? (Untested.) As it > appears to me, this would allow proper matching in text like this, too: > > Bla

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-10-17 Thread Thomas Schwinge
Hi! Good idea! On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe wrote: > +(defun notmuch-show-buttonise-links (start end) > + "Buttonise URLs and mail addresses between START and END. > + > +This also turns id:\"\"-parts into buttons for > +a corresponding notmuch search." > +

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-10-11 Thread Daniel Schoepe
On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe wrote: > This fixes the minor annoyance that message ids were parsed as mail > addresses by goto-address-mode in notmuch-show buffers. Due to the frequent references to other threads on this mailing list, I found my patch quite useful and

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-07-07 Thread Dmitry Kurochkin
On Thu, 07 Jul 2011 10:15:47 +0200, Daniel Schoepe wrote: > Hi Dmitry, > > On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin gmail.com> wrote: > > Why do we need to remove `goto-address-mode' overlays if it is not > > enabled ((goto-address-mode t) is below is removed)? > > [..] > >

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-07-07 Thread Dmitry Kurochkin
Hi Daniel. On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe wrote: > This fixes the minor annoyance that message ids were parsed as mail > addresses by goto-address-mode in notmuch-show buffers. I did not try it yet but it looks like a nice feature. Though I have some questions on the code

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-07-07 Thread Daniel Schoepe
Hi Dmitry, On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin wrote: > Why do we need to remove `goto-address-mode' overlays if it is not > enabled ((goto-address-mode t) is below is removed)? > [..] > `goto-address-mode' creates buttons not only for email addresses but > also for URLs. Do we

[PATCH v2] emacs: Turn id:"" elements into buttons for notmuch searches

2011-07-07 Thread Pieter Praet
On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe wrote: > This fixes the minor annoyance that message ids were parsed as mail > addresses by goto-address-mode in notmuch-show buffers. > --- > emacs/notmuch-show.el | 24 +--- > 1 files changed, 21 insertions(+), 3