[PATCH v2] emacs: show: lazy part bugfix

2013-09-05 Thread Mark Walters
Thanks to Austin's prodding and debugging and pointing out contradictory evidence I have looked into this bug in more detail and think I have got the actual cause this time. Having chased it all down I think there is a one line fix. Since I had already written the rest of the email when I

Re: [PATCH v2] emacs: show: lazy part bugfix

2013-09-05 Thread Mark Walters
Thanks to Austin's prodding and debugging and pointing out contradictory evidence I have looked into this bug in more detail and think I have got the actual cause this time. Having chased it all down I think there is a one line fix. Since I had already written the rest of the email when I

[PATCH v2] emacs: show: lazy part bugfix

2013-09-04 Thread Austin Clements
Quoth Jameson Graef Rollins on Sep 04 at 8:50 am: > On Wed, Sep 04 2013, Austin Clements wrote: > >> Now, some mime parts have subparts and to avoid overwriting the > >> sub-part data notmuch checks and if part data is already recorded it > >> does not overwrite it. > >> > >> Now with lazy part

[PATCH v2] emacs: show: lazy part bugfix

2013-09-04 Thread Austin Clements
Quoth Mark Walters on Sep 04 at 8:30 am: > The lazy part handling had a subtle bug. Notmuch stores the part > information as a text property with the displayed part so attachment > handling (saving viewing etc work). s/ work)/) work/ > > Now, some mime parts have subparts and to avoid

[PATCH v2] emacs: show: lazy part bugfix

2013-09-04 Thread Jameson Graef Rollins
On Wed, Sep 04 2013, Austin Clements wrote: >> Now, some mime parts have subparts and to avoid overwriting the >> sub-part data notmuch checks and if part data is already recorded it >> does not overwrite it. >> >> Now with lazy part handling this could fail: there is already part >> data

[PATCH v2] emacs: show: lazy part bugfix

2013-09-04 Thread Mark Walters
The lazy part handling had a subtle bug. Notmuch stores the part information as a text property with the displayed part so attachment handling (saving viewing etc work). Now, some mime parts have subparts and to avoid overwriting the sub-part data notmuch checks and if part data is already

[PATCH v2] emacs: show: lazy part bugfix

2013-09-04 Thread Mark Walters
The lazy part handling had a subtle bug. Notmuch stores the part information as a text property with the displayed part so attachment handling (saving viewing etc work). Now, some mime parts have subparts and to avoid overwriting the sub-part data notmuch checks and if part data is already

Re: [PATCH v2] emacs: show: lazy part bugfix

2013-09-04 Thread Austin Clements
Quoth Mark Walters on Sep 04 at 8:30 am: The lazy part handling had a subtle bug. Notmuch stores the part information as a text property with the displayed part so attachment handling (saving viewing etc work). s/ work)/) work/ Now, some mime parts have subparts and to avoid overwriting

Re: [PATCH v2] emacs: show: lazy part bugfix

2013-09-04 Thread Austin Clements
Quoth Jameson Graef Rollins on Sep 04 at 8:50 am: On Wed, Sep 04 2013, Austin Clements amdra...@mit.edu wrote: Now, some mime parts have subparts and to avoid overwriting the sub-part data notmuch checks and if part data is already recorded it does not overwrite it. Now with lazy part

Re: [PATCH v2] emacs: show: lazy part bugfix

2013-09-04 Thread Jameson Graef Rollins
On Wed, Sep 04 2013, Austin Clements amdra...@mit.edu wrote: Now, some mime parts have subparts and to avoid overwriting the sub-part data notmuch checks and if part data is already recorded it does not overwrite it. Now with lazy part handling this could fail: there is already part data