[PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-08 Thread Tomi Ollila
On Thu, Nov 08 2012, Blake Jones wrote: >>> @@ -11,10 +12,44 @@ fi >>> HEADER=$1 >>> shift >>> >>> +if [ `uname -s` == SunOS ] ; then >>> +# >>> +# Using Solaris "nm", a defined symbol looks like this: >>> +# >> >> The POSIX / Bourne -comformant equality comparison is '='. > > S

Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-08 Thread Blake Jones
>> Would a respun version of these patches help toward testing? > > $ grep vim test/* > zsh: exit 1 grep vim test/* > > i.e. no vim tests... Sure -- I was referring to any more general testing you might do. Anyway, thanks for your comments. Barring any more comments I'll probably send out

[PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-08 Thread Blake Jones
>> Would a respun version of these patches help toward testing? > > $ grep vim test/* > zsh: exit 1 grep vim test/* > > i.e. no vim tests... Sure -- I was referring to any more general testing you might do. Anyway, thanks for your comments. Barring any more comments I'll probably send out

Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-08 Thread Tomi Ollila
On Thu, Nov 08 2012, Blake Jones wrote: >>> @@ -11,10 +12,44 @@ fi >>> HEADER=$1 >>> shift >>> >>> +if [ `uname -s` == SunOS ] ; then >>> +# >>> +# Using Solaris "nm", a defined symbol looks like this: >>> +# >> >> The POSIX / Bourne -comformant equality comparison is '='. > > S

Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-07 Thread Blake Jones
>> @@ -11,10 +12,44 @@ fi >> HEADER=$1 >> shift >> >> +if [ `uname -s` == SunOS ] ; then >> +# >> +# Using Solaris "nm", a defined symbol looks like this: >> +# > > The POSIX / Bourne -comformant equality comparison is '='. Sigh, of course it is. Fixed. > e.g. > > $ ./heirloom

[PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-07 Thread Blake Jones
>> @@ -11,10 +12,44 @@ fi >> HEADER=$1 >> shift >> >> +if [ `uname -s` == SunOS ] ; then >> +# >> +# Using Solaris "nm", a defined symbol looks like this: >> +# > > The POSIX / Bourne -comformant equality comparison is '='. Sigh, of course it is. Fixed. > e.g. > > $ ./heirloom

[PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-06 Thread Tomi Ollila
On Mon, Nov 05 2012, Blake Jones wrote: > The output of "nm" on Solaris is substantially different from that on > Linux, and the current version of gen-version-script is tied to the > Linux "nm" output. This patch separates the parts of "nm" processing > which are dependent on the output format

Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-06 Thread Tomi Ollila
On Mon, Nov 05 2012, Blake Jones wrote: > The output of "nm" on Solaris is substantially different from that on > Linux, and the current version of gen-version-script is tied to the > Linux "nm" output. This patch separates the parts of "nm" processing > which are dependent on the output format

[PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-05 Thread Blake Jones
The output of "nm" on Solaris is substantially different from that on Linux, and the current version of gen-version-script is tied to the Linux "nm" output. This patch separates the parts of "nm" processing which are dependent on the output format into a couple shell functions, and makes another s

[PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-05 Thread Blake Jones
The output of "nm" on Solaris is substantially different from that on Linux, and the current version of gen-version-script is tied to the Linux "nm" output. This patch separates the parts of "nm" processing which are dependent on the output format into a couple shell functions, and makes another s