[PATCH v2 08/10] cli: address: Do not output duplicate addresses

2014-11-04 Thread Michal Sojka
On Tue, Nov 04 2014, David Bremner wrote: > Michal Sojka writes: > >> >> +/* Returns TRUE iff name and addr is duplicate. */ > > If you're revising this patch, it would be good to mention the side > effect of this function. > >> -process_address_list (const search_context_t *ctx,

[PATCH v2 08/10] cli: address: Do not output duplicate addresses

2014-11-04 Thread David Bremner
Michal Sojka writes: > > +/* Returns TRUE iff name and addr is duplicate. */ If you're revising this patch, it would be good to mention the side effect of this function. > -process_address_list (const search_context_t *ctx, InternetAddressList *list) > +process_address_list (const

[PATCH v2 08/10] cli: address: Do not output duplicate addresses

2014-11-04 Thread Michal Sojka
This filters out duplicate addresses from address command output. It also also adds tests for the address command. The code here is an extended version of a patch from Jani Nikula. --- doc/man1/notmuch-address.rst | 2 +- notmuch-search.c | 40 -

Re: [PATCH v2 08/10] cli: address: Do not output duplicate addresses

2014-11-04 Thread Michal Sojka
On Tue, Nov 04 2014, David Bremner wrote: Michal Sojka sojk...@fel.cvut.cz writes: +/* Returns TRUE iff name and addr is duplicate. */ If you're revising this patch, it would be good to mention the side effect of this function. -process_address_list (const search_context_t *ctx,

[PATCH v2 08/10] cli: address: Do not output duplicate addresses

2014-11-03 Thread Michal Sojka
This filters out duplicate addresses from address command output. It also also adds tests for the address command. The code here is an extended version of a patch from Jani Nikula. --- doc/man1/notmuch-address.rst | 2 +- notmuch-search.c | 40 -

Re: [PATCH v2 08/10] cli: address: Do not output duplicate addresses

2014-11-03 Thread David Bremner
Michal Sojka sojk...@fel.cvut.cz writes: +/* Returns TRUE iff name and addr is duplicate. */ If you're revising this patch, it would be good to mention the side effect of this function. -process_address_list (const search_context_t *ctx, InternetAddressList *list) +process_address_list