[PATCH v2 2/7] lib: add a date/time parser module

2012-08-06 Thread Jani Nikula
Hi David, thanks for the review! On Sun, 05 Aug 2012, David Bremner wrote: > Jani Nikula writes: > >> + >> +static enum field >> +abs_to_rel_field (enum field field) >> +{ >> +assert (field <= TM_ABS_YEAR); >> + >> +/* note: depends on the enum ordering */ >> +return field +

[PATCH v2 2/7] lib: add a date/time parser module

2012-08-05 Thread David Bremner
Jani Nikula writes: > + > +static enum field > +abs_to_rel_field (enum field field) > +{ > +assert (field <= TM_ABS_YEAR); > + > +/* note: depends on the enum ordering */ > +return field + (TM_REL_SEC - TM_ABS_SEC); > +} > + I wonder if this would be slightly nicer of you defined a

[PATCH v2 2/7] lib: add a date/time parser module

2012-08-04 Thread Jani Nikula
Build a date/time parser as part of the notmuch lib, to be used for adding date range query support later on. Signed-off-by: Jani Nikula --- lib/Makefile.local |1 + lib/parse-time-string.c | 1384 +++ lib/parse-time-string.h | 95 3

[PATCH v2 2/7] lib: add a date/time parser module

2012-08-04 Thread Jani Nikula
Build a date/time parser as part of the notmuch lib, to be used for adding date range query support later on. Signed-off-by: Jani Nikula j...@nikula.org --- lib/Makefile.local |1 + lib/parse-time-string.c | 1384 +++ lib/parse-time-string.h |