On Thu, Oct 18 2012, Ethan wrote:
> On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila wrote:
>
>> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
>>
>> > Ethan Glasser-Camp writes:
>> >
>> >> This patch, and its predecessors, all look great to me.
>> >
>> > But a note: many of the first lines in your
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> This patch, and its predecessors, all look great to me.
>
> But a note: many of the first lines in your commit messages ("{show,
Hmm, first lines -- IIRC mailman adds those tabs to the subject line -- and
those are
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> This patch, and its predecessors, all look great to me.
>
> But a note: many of the first lines in your commit messages ("{show,
> hide} message headers") contain tabs. I hate tabs. Is this intentional?
> I have
On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila wrote:
> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
>
> > Ethan Glasser-Camp writes:
> >
> >> This patch, and its predecessors, all look great to me.
> >
> > But a note: many of the first lines in your commit messages ("{show,
>
> Hmm, first
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
This patch, and its predecessors, all look great to me.
But a note: many of the first lines in your commit messages ({show,
hide} message headers) contain tabs. I hate tabs. Is this
On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila tomi.oll...@iki.fi wrote:
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
This patch, and its predecessors, all look great to me.
But a note: many of the first lines in your commit
Ethan Glasser-Camp writes:
> This patch, and its predecessors, all look great to me.
But a note: many of the first lines in your commit messages ("{show,
hide} message headers") contain tabs. I hate tabs. Is this intentional?
I have noticed it on other patches you've sent (such as
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
This patch, and its predecessors, all look great to me.
But a note: many of the first lines in your commit messages ({show,
hide} message headers) contain tabs. I hate tabs. Is this intentional?
I have noticed it on other patches you've
Pieter Praet writes:
> * emacs/notmuch-show.el
>
> (notmuch-show-toggle-headers):
> Rename to `notmuch-show-toggle-visibility-headers'.
This patch, and its predecessors, all look great to me. The following
patches were already marked "stale" (and indeed they don't apply). But
it looks
Pieter Praet pie...@praet.org writes:
* emacs/notmuch-show.el
(notmuch-show-toggle-headers):
Rename to `notmuch-show-toggle-visibility-headers'.
This patch, and its predecessors, all look great to me. The following
patches were already marked stale (and indeed they don't apply). But
it
* emacs/notmuch-show.el
(notmuch-show-toggle-headers):
Rename to `notmuch-show-toggle-visibility-headers'.
(notmuch-show-mode-map):
Update "h" binding wrt renamed `notmuch-show-toggle-headers'.
(notmuch-message-headers):
Update docstring wrt renamed
* emacs/notmuch-show.el
(notmuch-show-toggle-headers):
Rename to `notmuch-show-toggle-visibility-headers'.
(notmuch-show-mode-map):
Update h binding wrt renamed `notmuch-show-toggle-headers'.
(notmuch-message-headers):
Update docstring wrt renamed
12 matches
Mail list logo
