> I think the API should be clear and easy to understand, because people will
> probably bind them to custom shortcuts. You should not have to think about
> what that weird extra parameter (-1, false, ...) means and go read the docs.
I agree. One might replace the parameter with a string like
I think the API should be clear and easy to understand, because people will
probably bind them to custom shortcuts. You should not have to think about
what that weird extra parameter (-1, false, ...) means and go read the docs.
I agree. One might replace the parameter with a string like prev
Bartosz Telenczuk wrote:
> Hi Ian,
>
> The patch looks good. I tested it on my system and it works fine. I just
> have one suggestion regarding coding style.
>
> > +function! s:show_prev_msg()
> > function! s:show_next_msg()
>
> Since these functions are almost the same, you could avoid code
Bartosz Telenczuk wrote:
Hi Ian,
The patch looks good. I tested it on my system and it works fine. I just
have one suggestion regarding coding style.
+function! s:show_prev_msg()
function! s:show_next_msg()
Since these functions are almost the same, you could avoid code repetition
Hi Ian,
The patch looks good. I tested it on my system and it works fine. I just have
one suggestion regarding coding style.
> +function! s:show_prev_msg()
> function! s:show_next_msg()
Since these functions are almost the same, you could avoid code repetition by
replacing them by a
Hi Ian,
The patch looks good. I tested it on my system and it works fine. I just have
one suggestion regarding coding style.
+function! s:show_prev_msg()
function! s:show_next_msg()
Since these functions are almost the same, you could avoid code repetition by
replacing them by a function
Add a few changes to moving between threads:
- It supports 'scrolloff' so that if you have this set it will move the
buffer and cursor so the next/prev email starts at the top of the
screen.
- It adds the ability to use shift-tab to go to the previous msg in
the thread.
Ian
---
Remove
Add a few changes to moving between threads:
- It supports 'scrolloff' so that if you have this set it will move the
buffer and cursor so the next/prev email starts at the top of the
screen.
- It adds the ability to use shift-tab to go to the previous msg in
the thread.
Ian
---
Remove
