Re: [PATCH v4 4/5] test: support testing notmuch as installed

2023-07-22 Thread David Bremner
Tomi Ollila writes: >> fi >> >> +if [ -n "${LD_PRELOAD-}" ]; then > > Is it problem to chain LD_PRELOADs here ? I see later in this message > there is LD_PRELOAD's concatenated with :'s (in case non-empty) ? > It is not a problem in general, but ASAN insists on being first in LD_PRELOAD, so

Re: [PATCH v4 4/5] test: support testing notmuch as installed

2023-07-22 Thread David Bremner
Tomi Ollila writes: >> -LD_PRELOAD=${LD_PRELOAD:+:$LD_PRELOAD}:./${shim_file} notmuch-shared >> "$@" >> +LD_PRELOAD=${LD_PRELOAD:+:$LD_PRELOAD}:./${shim_file} $notmuch_cmd "$@" > > hmm, should the "chaining" be done on other order (i.e. the shim_file > before anything if there... (that

Re: [PATCH v4 4/5] test: support testing notmuch as installed

2023-07-11 Thread Tomi Ollila
On Sun, Jul 09 2023, David Bremner wrote: Note: I almost commented cases where it was not ensured that variable is defined, to notice later that those were actually defined for sure -- so in some previous mails in this series I may have missed same cases. The comments for this message may be

[PATCH v4 4/5] test: support testing notmuch as installed

2023-07-09 Thread David Bremner
We put some effort into testing the built copy rather than some installed copy. On the other hand for people like packagers, testing the installed copy is also of interest. When NOTMUCH_TEST_INSTALLED is set to a nonempty value, tests do not require a built notmuch tree or running configure.