[PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-29 Thread Dmitry Kurochkin
Hi Daniel. On Sat, 28 Jan 2012 22:30:57 +0100, Daniel Schoepe wrote: > Hi Dmitry, > > On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin > wrote: > > There are some trailing whitespaces in the tests. > > those are also produced by the various notmuch-hello functions, and are > also in the existing

[PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-28 Thread Daniel Schoepe
Hi Dmitry. On Sun, 29 Jan 2012 02:48, Dmitry Kurochkin wrote: > I only meant trailing whitespaces in test/emacs file in the lines added > by the patch. Trailing whitespaces in expected results are obviously > fine. Ah, okay. I fixed those with delete-trailing-whitespace, but then noticed that

[PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-28 Thread Daniel Schoepe
Hi Dmitry, On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin wrote: > There are some trailing whitespaces in the tests. those are also produced by the various notmuch-hello functions, and are also in the existing tests. If someone is bothered by this, it should be fixed in a separate patch. > >

Re: [PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-28 Thread Dmitry Kurochkin
Hi Daniel. On Sat, 28 Jan 2012 22:30:57 +0100, Daniel Schoepe dan...@schoepe.org wrote: Hi Dmitry, On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: There are some trailing whitespaces in the tests. those are also produced by the various notmuch-hello

Re: [PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-28 Thread Daniel Schoepe
Hi Dmitry. On Sun, 29 Jan 2012 02:48, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I only meant trailing whitespaces in test/emacs file in the lines added by the patch. Trailing whitespaces in expected results are obviously fine. Ah, okay. I fixed those with delete-trailing-whitespace,

[PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-24 Thread Dmitry Kurochkin
Hi Daniel. There are some trailing whitespaces in the tests. Also, please consider moving the hello sections tests to a separate file (emacs-hello-sections, perhaps?). I am worried that test/emacs file becomes too big. And we will probably add more notmuch-hello section-related tests in the

Re: [PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-24 Thread Dmitry Kurochkin
Hi Daniel. There are some trailing whitespaces in the tests. Also, please consider moving the hello sections tests to a separate file (emacs-hello-sections, perhaps?). I am worried that test/emacs file becomes too big. And we will probably add more notmuch-hello section-related tests in the

[PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-22 Thread Daniel Schoepe
From: Daniel Schoepe --- test/emacs | 37 test/emacs.expected-output/notmuch-hello |4 ++- .../notmuch-hello-new-section |4 ++

[PATCH v7 2/2] emacs: Tests for user-defined sections

2012-01-21 Thread Daniel Schoepe
From: Daniel Schoepe daniel.scho...@googlemail.com --- test/emacs | 37 test/emacs.expected-output/notmuch-hello |4 ++- .../notmuch-hello-new-section |4 ++ .../notmuch-hello-no-saved-searches