[Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

2012-12-15 Thread David Bremner
Mark Walters writes: > I don't know if this matters but it seems that one can still add a "-" > tag by doing something like > > echo "+%2d -- search" | notmuch tag --batch > > This might be the right thing to do but I thought I would mention it. I _think_ it's a feature, so I'm tempted to docume

Re: [Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

2012-12-15 Thread David Bremner
Mark Walters writes: > I don't know if this matters but it seems that one can still add a "-" > tag by doing something like > > echo "+%2d -- search" | notmuch tag --batch > > This might be the right thing to do but I thought I would mention it. I _think_ it's a feature, so I'm tempted to docume

[Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

2012-12-13 Thread Mark Walters
I don't know if this matters but it seems that one can still add a "-" tag by doing something like echo "+%2d -- search" | notmuch tag --batch This might be the right thing to do but I thought I would mention it. Best wishes Mark On Sun, 09 Dec 2012, david at tethera.net wrote: > From: David

Re: [Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

2012-12-13 Thread Mark Walters
I don't know if this matters but it seems that one can still add a "-" tag by doing something like echo "+%2d -- search" | notmuch tag --batch This might be the right thing to do but I thought I would mention it. Best wishes Mark On Sun, 09 Dec 2012, da...@tethera.net wrote: > From: David Bre

[Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

2012-12-10 Thread Jani Nikula
On Mon, 10 Dec 2012, david at tethera.net wrote: > From: David Bremner > > This will allow us to be consistent between batch tagging and command > line tagging as far as what is an illegal tag. LGTM, with some nitpick and observations below. Jani. > --- > tag-util.c | 35

Re: [Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

2012-12-10 Thread Jani Nikula
On Mon, 10 Dec 2012, da...@tethera.net wrote: > From: David Bremner > > This will allow us to be consistent between batch tagging and command > line tagging as far as what is an illegal tag. LGTM, with some nitpick and observations below. Jani. > --- > tag-util.c | 35 +++

[Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

2012-12-09 Thread da...@tethera.net
From: David Bremner This will allow us to be consistent between batch tagging and command line tagging as far as what is an illegal tag. --- tag-util.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/tag-util.c b/tag-util.c index eab482f

[Patch v6 1/6] tag-util: factor out rules for illegal tags, use in parse_tag_line

2012-12-09 Thread david
From: David Bremner This will allow us to be consistent between batch tagging and command line tagging as far as what is an illegal tag. --- tag-util.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/tag-util.c b/tag-util.c index eab482f