Re: [PATCH 1/2] test/raw: add some messages likely to be multiples of buffer size

2019-05-05 Thread Daniel Kahn Gillmor
On Sun 2019-05-05 07:49:16 -0300, David Bremner wrote: > My take away from that is that I should probably squash these two > commits into one. I've read this series and it seems reasonable to me. i agree that we should be testing messages smaller than 4096 octets, either by squashing the two

Re: [PATCH 1/2] test/raw: add some messages likely to be multiples of buffer size

2019-05-05 Thread David Bremner
Tomi Ollila writes: > On Sun, May 05 2019, Tomi Ollila wrote: > >> On Sat, May 04 2019, David Bremner wrote: >> >>> >>> +test_python <>> +from email.message import EmailMessage >>> +for pow in range(12,21): >> >> ...^ space. i.e. (12, 21) >> >> from 4KiB to 1MiB. uh,

Re: [PATCH 1/2] test/raw: add some messages likely to be multiples of buffer size

2019-05-05 Thread Tomi Ollila
On Sun, May 05 2019, Tomi Ollila wrote: > On Sat, May 04 2019, David Bremner wrote: > >> >> +test_python <> +from email.message import EmailMessage >> +for pow in range(12,21): > > ...^ space. i.e. (12, 21) > > from 4KiB to 1MiB. uh, perhaps I should have kept my fingers

Re: [PATCH 1/2] test/raw: add some messages likely to be multiples of buffer size

2019-05-05 Thread Tomi Ollila
On Sat, May 04 2019, David Bremner wrote: > This highlights a bug where zero bytes are read at the end of the > file, and we attempt to write those to stdout, causing spurious write > failures. > --- > test/T210-raw.sh | 35 +++ > 1 file changed, 35 insertions(+)