Re: [PATCH v3 2/5] reply: Add a JSON reply format.

2012-02-05 Thread Mark Walters
On Thu, 19 Jan 2012 10:46:54 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: This new JSON format for replies includes headers generated for a reply message as well as the headers and all text parts of the original message. Using this data, a client can intelligently create a reply. For

Re: [PATCH v3 2/5] reply: Add a JSON reply format.

2012-02-05 Thread Mark Walters
On Sun, 05 Feb 2012 11:50:12 +, Mark Walters markwalters1...@gmail.com wrote: On Thu, 19 Jan 2012 10:46:54 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: This new JSON format for replies includes headers generated for a reply message as well as the headers and all text parts of

Re: [PATCH v3 2/5] reply: Add a JSON reply format.

2012-02-05 Thread Adam Wolfe Gordon
Thanks for the review. The style nits are things I missed in my previous cleanup, so thanks for pointing them out. I should probably run uncrustify and see if it complains about anything else. The other points are definitely up for discussion, and some are areas where I was unsure to start with.

Re: [PATCH v3 2/5] reply: Add a JSON reply format.

2012-02-05 Thread Dmitry Kurochkin
On Sun, 5 Feb 2012 12:42:12 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: Thanks for the review. The style nits are things I missed in my previous cleanup, so thanks for pointing them out. I should probably run uncrustify and see if it complains about anything else. The other points are

Re: [PATCH v3 2/5] reply: Add a JSON reply format.

2012-02-05 Thread Austin Clements
Quoth Adam Wolfe Gordon on Jan 19 at 10:46 am: This new JSON format for replies includes headers generated for a reply message as well as the headers and all text parts of the original message. Using this data, a client can intelligently create a reply. For example, the emacs client will be

Re: [PATCH v3 2/5] reply: Add a JSON reply format.

2012-02-05 Thread Adam Wolfe Gordon
On Sun, Feb 5, 2012 at 20:44, Austin Clements amdra...@mit.edu wrote: Sorry for coming late to the party.  I really like this idea, but it seems like your implementation is duplicating a lot of the work of notmuch show.  This makes me wonder if it would be better to return reply header