Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

2012-11-30 Thread Austin Clements
Quoth David Bremner on Nov 29 at 8:17 pm: Mark Walters markwalters1...@gmail.com writes: I don't know how freeze/thaw work but does it matter that you don't thaw when there is an error? My interpretation is that by not thawing before we destroy the message, we are aborting the

Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

2012-11-29 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: I don't know how freeze/thaw work but does it matter that you don't thaw when there is an error? My interpretation is that by not thawing before we destroy the message, we are aborting the transaction, since the freeze/thaw information is stored

Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

2012-11-25 Thread Mark Walters
This looks good. A couple of typos and a small queries (and I agree with Tomi but I think you have already included that). On Sat, 24 Nov 2012, da...@tethera.net wrote: From: David Bremner brem...@debian.org These are meant to be shared between notmuch-tag and notmuch-restore. The bulk of

Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

2012-11-24 Thread Tomi Ollila
On Sat, Nov 24 2012, da...@tethera.net wrote: From: David Bremner brem...@debian.org These are meant to be shared between notmuch-tag and notmuch-restore. The bulk of the routines implement a tag operation list abstract data type act as a structured representation of a set of tag

Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

2012-11-24 Thread David Bremner
Maybe something like the following formatted and consistency-tuned version: typedef enum { TAG_FLAG_NONE = 0, /* Operations are synced to maildir, if possible. */ TAG_FLAG_MAILDIR_SYNC = (1 0), /* Remove all tags from message before applying list. */