Re: Patch: Flush and Reopen

2011-09-09 Thread Martin Owens
On Fri, 2011-09-09 at 08:06 -0300, David Bremner wrote: I was also puzzled by your changes to debian/changelog. We really need justification for every little change introduced by the patch; this is another reason it helps to split things up a bit. That probably was unintended. See attached

Re: Patch: Flush and Reopen

2011-09-09 Thread Austin Clements
On Fri, Sep 9, 2011 at 1:55 PM, Martin Owens docto...@gmail.com wrote: That probably was unintended. See attached for the all new slimmed down patch. --- a/lib/database.cc +++ b/lib/database.cc @@ -700,18 +700,37 @@ notmuch_database_open (const char *path, } void -notmuch_database_close

Re: Patch: Flush and Reopen

2011-09-09 Thread Martin Owens
On Fri, 2011-09-09 at 19:40 -0400, Austin Clements wrote: (indented correctly, of course). Reopen is a method of Xapian::Database, which is what notmuch-xapian_db is anyway (unlike, flush, which is a member of the subclass WritableDatabase and hence requires the cast). And reopening is a

Re: Patch: Flush and Reopen

2011-09-08 Thread Austin Clements
On Wed, Sep 7, 2011 at 9:34 PM, Martin Owens docto...@gmail.com wrote: Hello, Per discussions on irc, I've attached a patch for your consideration which allows the developer to run two new database commands; notmuch_database_flush - used on read_write databases to commit changes to disk