Small bug in json-search changes

2012-08-07 Thread Mark Walters
Hi I have found a small bug in the recent changes to notmuch search to use the JSON output. If you refresh the search buffer "point" does not stay on the same thread. I think the problem is that notmuch-search-refresh-view calls notmuch search with target-thread set to notmuch-search-find-threa

Small bug in json-search changes

2012-08-06 Thread Austin Clements
Nice catch. I think the solution is either exactly this, or we should strip "thread:" off notmuch-search-target-thread when we set it. I would lean slightly toward the latter so we don't have to generate up a new (identical) string on every notmuch-search-show-result call, but I doubt it would ma

Re: Small bug in json-search changes

2012-08-06 Thread Austin Clements
Nice catch. I think the solution is either exactly this, or we should strip "thread:" off notmuch-search-target-thread when we set it. I would lean slightly toward the latter so we don't have to generate up a new (identical) string on every notmuch-search-show-result call, but I doubt it would ma

Small bug in json-search changes

2012-08-06 Thread Mark Walters
Hi I have found a small bug in the recent changes to notmuch search to use the JSON output. If you refresh the search buffer "point" does not stay on the same thread. I think the problem is that notmuch-search-refresh-view calls notmuch search with target-thread set to notmuch-search-find-threa