Solaris support - missing or incompatible functions (v2)

2013-08-16 Thread vladimir.ma...@oracle.com
Hi, I'm re-sending the patches which were rebased to current top of the tree. Apart from rebasing there has been no change made. I am using this notmuch for half a year and it seems to work fine. As I said in my previous email, not all the tests pass, but I know that the failures in the testing

Solaris support - missing or incompatible functions

2013-08-16 Thread Tomi Ollila
On Fri, Aug 16 2013, Vladimir Marek wrote: > Hi, > >> > > I didn't pay too much attention to the test output as it's broken on >> > > linux too :) >> > >> > It shouldn't be. All tests pass for me, and we're pretty strict about >> > maintaining that. >> > >> > There may be some prerequisites to

Solaris support - missing or incompatible functions

2013-08-16 Thread Vladimir Marek
Hi, > > > I didn't pay too much attention to the test output as it's broken on > > > linux too :) > > > > It shouldn't be. All tests pass for me, and we're pretty strict about > > maintaining that. > > > > There may be some prerequisites to running tests that you're missing, > > and the test

Solaris support - missing or incompatible functions

2013-05-20 Thread Vladimir Marek
[...] > That must be some setting in (your?) bash: > > $ sh -c 'echo '\''foo\nbar'\''' > foo > bar > > $ bash -c 'echo '\''foo\nbar'\''' > foo\nbar > > $ dash -c 'echo '\''foo\nbar'\''' > foo > bar > > ... after a bit digging ... > > $ bash -c 'shopt -s xpg_echo; echo '\''foo\nbar'\''' > foo

Solaris support - missing or incompatible functions

2013-05-20 Thread Tomi Ollila
On Mon, May 20 2013, Vladimir Marek wrote: >> >> There may be some prerequisites to running tests that you're missing, >> >> and the test setup fails to tell you about. A pastebin of the 'make >> >> test' output might be helpful. >> > >> > Ok, in that case please let me take a look at the tests

Solaris support - missing or incompatible functions

2013-05-20 Thread Vladimir Marek
> >> There may be some prerequisites to running tests that you're missing, > >> and the test setup fails to tell you about. A pastebin of the 'make > >> test' output might be helpful. > > > > Ok, in that case please let me take a look at the tests first. > > > > For what it's worth, I can confirm

Re: Re: Solaris support - missing or incompatible functions

2013-05-20 Thread Vladimir Marek
There may be some prerequisites to running tests that you're missing, and the test setup fails to tell you about. A pastebin of the 'make test' output might be helpful. Ok, in that case please let me take a look at the tests first. For what it's worth, I can confirm no test failures

Re: Re: Solaris support - missing or incompatible functions

2013-05-20 Thread Tomi Ollila
On Mon, May 20 2013, Vladimir Marek vladimir.ma...@oracle.com wrote: There may be some prerequisites to running tests that you're missing, and the test setup fails to tell you about. A pastebin of the 'make test' output might be helpful. Ok, in that case please let me take a look at the

Re: Re: Re: Solaris support - missing or incompatible functions

2013-05-20 Thread Vladimir Marek
[...] That must be some setting in (your?) bash: $ sh -c 'echo '\''foo\nbar'\''' foo bar $ bash -c 'echo '\''foo\nbar'\''' foo\nbar $ dash -c 'echo '\''foo\nbar'\''' foo bar ... after a bit digging ... $ bash -c 'shopt -s xpg_echo; echo '\''foo\nbar'\''' foo bar $ bash

Solaris support - missing or incompatible functions

2013-05-18 Thread David Bremner
Vladimir Marek writes: >> >> There may be some prerequisites to running tests that you're missing, >> and the test setup fails to tell you about. A pastebin of the 'make >> test' output might be helpful. > > Ok, in that case please let me take a look at the tests first. > For what it's worth,

Re: Solaris support - missing or incompatible functions

2013-05-18 Thread David Bremner
Vladimir Marek vladimir.ma...@oracle.com writes: There may be some prerequisites to running tests that you're missing, and the test setup fails to tell you about. A pastebin of the 'make test' output might be helpful. Ok, in that case please let me take a look at the tests first. For

Solaris support - missing or incompatible functions

2013-05-13 Thread Vladimir Marek
> > I didn't pay too much attention to the test output as it's broken on > > linux too :) > > It shouldn't be. All tests pass for me, and we're pretty strict about > maintaining that. > > There may be some prerequisites to running tests that you're missing, > and the test setup fails to tell you

Solaris support - missing or incompatible functions

2013-05-13 Thread Jani Nikula
On Sun, 12 May 2013, Vladimir Marek wrote: > I didn't pay too much attention to the test output as it's broken on > linux too :) It shouldn't be. All tests pass for me, and we're pretty strict about maintaining that. There may be some prerequisites to running tests that you're missing, and the

Solaris support - missing or incompatible functions

2013-05-13 Thread Jani Nikula
On Mon, 06 May 2013, Vladimir.Marek at oracle.com wrote: > I can't run the notmuch 'make test' on Solaris (too old bash) and on linux the > results are > > 421/525 tests passed. > 25 tests failed. > 79 tests skipped. > > but they are the same without my changes too ... The series LGTM, except I

Solaris support - missing or incompatible functions

2013-05-12 Thread Vladimir Marek
> > I can't run the notmuch 'make test' on Solaris (too old bash) and on linux > > the > > results are > > > > 421/525 tests passed. > > 25 tests failed. > > 79 tests skipped. > > > > but they are the same without my changes too ... > > The series LGTM, except I didn't pay much attention to the

Re: Solaris support - missing or incompatible functions

2013-05-12 Thread Jani Nikula
On Mon, 06 May 2013, vladimir.ma...@oracle.com wrote: I can't run the notmuch 'make test' on Solaris (too old bash) and on linux the results are 421/525 tests passed. 25 tests failed. 79 tests skipped. but they are the same without my changes too ... The series LGTM, except I didn't pay

Re: Solaris support - missing or incompatible functions

2013-05-12 Thread Vladimir Marek
I can't run the notmuch 'make test' on Solaris (too old bash) and on linux the results are 421/525 tests passed. 25 tests failed. 79 tests skipped. but they are the same without my changes too ... The series LGTM, except I didn't pay much attention to the timegm()

Re: Solaris support - missing or incompatible functions

2013-05-12 Thread Jani Nikula
On Sun, 12 May 2013, Vladimir Marek vladimir.ma...@oracle.com wrote: I didn't pay too much attention to the test output as it's broken on linux too :) It shouldn't be. All tests pass for me, and we're pretty strict about maintaining that. There may be some prerequisites to running tests that

Re: Solaris support - missing or incompatible functions

2013-05-12 Thread Vladimir Marek
I didn't pay too much attention to the test output as it's broken on linux too :) It shouldn't be. All tests pass for me, and we're pretty strict about maintaining that. There may be some prerequisites to running tests that you're missing, and the test setup fails to tell you about. A

Solaris support - missing or incompatible functions

2013-05-06 Thread vladimir.ma...@oracle.com
Hi, This is next series of patches adding Solaris support to notmuch. I am mostly using what Blake Jones sent some time ago + I fixed all the comments he received back then. Since it's mostly his work, it's IMO fair to keep him as an author. But since I made sure the patches work, I'm signing

Solaris support - missing or incompatible functions

2013-05-06 Thread Vladimir . Marek
Hi, This is next series of patches adding Solaris support to notmuch. I am mostly using what Blake Jones sent some time ago + I fixed all the comments he received back then. Since it's mostly his work, it's IMO fair to keep him as an author. But since I made sure the patches work, I'm signing