RE: notmuch-0.21 bug report

2016-04-25 Thread David Binderman
Hello there, > Hi David; > > Thanks for the report. fclose doesn't really make sense here; Surprising. There is a call to fclose for the success return, so I just assumed that one would also be required for the error return. >what is that error message

RE: notmuch-0.21 bug report

2016-04-25 Thread David Bremner
David Binderman writes: > Hello there, > > >> Hi David; >> >> Thanks for the report. fclose doesn't really make sense here; > > Surprising. There is a call to fclose for the success return, > so I just assumed that one would also be

Re: notmuch-0.21 bug report

2016-04-25 Thread David Bremner
David Binderman writes: > Hello there, > > [notmuch-count.c:207]: (error) Resource leak: input > > Source code is > >    if (notmuch_database_open (notmuch_config_get_database_path (config), >    NOTMUCH_DATABASE_MODE_READ_ONLY, )) >     return EXIT_FAILURE;

notmuch-0.21 bug report

2016-04-25 Thread David Binderman
Hello there, [notmuch-count.c:207]: (error) Resource leak: input Source code is    if (notmuch_database_open (notmuch_config_get_database_path (config),    NOTMUCH_DATABASE_MODE_READ_ONLY, ))     return EXIT_FAILURE; Suggest call fclose. Some duplicates: