Re: read after free in notmuch new

2017-02-28 Thread David Bremner
David Bremner writes: > David Bremner writes: > >> I haven't had a chance to really track this down, but it seems there is >> a memory error in notmuch new (or a maybe false positive from valgrind). >> >> Attached is the log from running "make memory-test

Re: read after free in notmuch new

2017-02-21 Thread David Bremner
David Bremner writes: > Tomi Ollila writes: > >> To me it looks like replacing g_hash_table_insert() with >> g_hash_table_replace() would do the trick. >> >> (or even g_hash_table_add()!) >> >> One has to read the documentation a bit (and compare the

Re: read after free in notmuch new

2017-02-21 Thread David Bremner
Tomi Ollila writes: > To me it looks like replacing g_hash_table_insert() with > g_hash_table_replace() would do the trick. > > (or even g_hash_table_add()!) > > One has to read the documentation a bit (and compare the docstrings of > these 2 functions to guess the missing

Re: read after free in notmuch new

2017-02-21 Thread Tomi Ollila
On Tue, Feb 21 2017, David Bremner wrote: > David Bremner writes: > >> David Bremner writes: >> >>> I haven't had a chance to really track this down, but it seems there is >>> a memory error in notmuch new (or a maybe false positive from

Re: read after free in notmuch new

2017-02-20 Thread David Bremner
David Bremner writes: > David Bremner writes: > >> I haven't had a chance to really track this down, but it seems there is >> a memory error in notmuch new (or a maybe false positive from valgrind). >> >> Attached is the log from running "make memory-test

Re: read after free in notmuch new

2017-02-19 Thread David Bremner
David Bremner writes: > I haven't had a chance to really track this down, but it seems there is > a memory error in notmuch new (or a maybe false positive from valgrind). > > Attached is the log from running "make memory-test OPTIONS=--medium" on > current git master

read after free in notmuch new

2017-02-19 Thread David Bremner
I haven't had a chance to really track this down, but it seems there is a memory error in notmuch new (or a maybe false positive from valgrind). Attached is the log from running "make memory-test OPTIONS=--medium" on current git master (0e037c34). It looks like we talloc the message_id string