[PATCH] emacs: User-defined sections in notmuch-hello

2011-05-27 Thread Daniel Schoepe
ail/notmuch/attachments/20110527/60d6652a/attachment.patch> -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527

[PATCH] emacs: User-defined sections in notmuch-hello

2011-05-27 Thread Daniel Schoepe
: 17893 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527/acae73f9/attachment-0001.patch> -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not ava

[PATCH] emacs: User-defined sections in notmuch-hello

2011-05-27 Thread Daniel Schoepe

one-time-iterators

2011-05-27 Thread Patrick Totzke
just to walk the > iterator (unfortunately I don't think profiling will help much here > because much of your time is probably spent waiting for I/O). I don't think I understand what you mean by dummy info in a thread object. > I don't think there would be any downside to doing this for eager > consumers like the CLI. one should think so, yes. /p -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527/8bb52855/attachment.pgp>

Re: normalizing part numbering across PGP/MIME processing

2011-05-27 Thread Carl Worth
On Fri, 27 May 2011 03:27:35 -0700, Jameson Graef Rollins wrote: > Ok. So I very much hope this patch series satisfies those who were > bothered by the part renumbering that was happening when PGP/MIME > parts were processed. For signed messages we no longer modify the > parts at all, so number

Re: [PATCH 2/2] Workaround for Emacs bug #8721.

2011-05-27 Thread Dmitry Kurochkin
This is an amended patch which uses `isearch-range-invisible' from Emacs trunk r104393 (includes the second patch from #8721). Regards, Dmitry >From d56f2c308c995639aad04f0e5388b52912e603b0 Mon Sep 17 00:00:00 2001 From: Dmitry Kurochkin Date: Fri, 27 May 2011 01:35:09 +0400 Subject: [PATCH] Wo

normalizing part numbering across PGP/MIME processing

2011-05-27 Thread Carl Worth
crubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527/23ad4e6a/attachment.pgp>

Re: [PATCH] test: use `princ' instead of `message' calls in emacs tests

2011-05-27 Thread Carl Worth
On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin wrote: > The patch replaces all (message (buffer-string)) calls in emacs > tests with (princ (buffer-string)). This avoids accidentally > interpreting '%' as format specifiers and makes code simpler > because we do not need to capture stderr.

[PATCH] test: use `princ' instead of `message' calls in emacs tests

2011-05-27 Thread Carl Worth
change is pushed now. -Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527/d94d24fd/attachment.pgp>

one-time-iterators

2011-05-27 Thread Austin Clements
On Fri, May 27, 2011 at 2:04 PM, Patrick Totzke wrote: > Excerpts from Austin Clements's message of Fri May 27 03:41:44 +0100 2011: >> >> > > Have you tried simply calling list() on your thread >> >> > > iterator to see how expensive it is? ?My bet is that it's quite cheap, >> >> > > both memory-w

Re: [PATCH] emacs: User-defined sections in notmuch-hello

2011-05-27 Thread Daniel Schoepe
Accidentally attached the old file again, sorry for the noise. From cafc93e3364955cab70885fec740fee87bc3248e Mon Sep 17 00:00:00 2001 From: Daniel Schoepe Date: Thu, 26 May 2011 23:03:22 +0200 Subject: [PATCH] emacs: User-defined sections in notmuch-hello This patch allows the user to define vari

Re: [PATCH] emacs: User-defined sections in notmuch-hello

2011-05-27 Thread Daniel Schoepe
I forgot to run the test suite with the previous patch, which revealed some minor formatting problems, updated patch in the attachment. From bca5a58d7910b6d46a782db787dfe07e2fcf21e1 Mon Sep 17 00:00:00 2001 From: Daniel Schoepe Date: Thu, 26 May 2011 23:03:22 +0200 Subject: [PATCH] emacs: User-def

normalizing part numbering across PGP/MIME processing

2011-05-27 Thread Daniel Kahn Gillmor
ed... Name: not available Type: application/pgp-signature Size: 965 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527/d45b6e14/attachment.pgp>

Re: [PATCH] test: change "#!/bin/bash" to "#!/usr/bin/env bash" enhances portability

2011-05-27 Thread Carl Worth
On Wed, 1 Dec 2010 21:27:52 +0100, Joel Borggrén-Franck wrote: > From: Joel Borggrén-Franck > > Change #!/bin/bash at start of tests to "#!/usr/bin/env bash". That way > systems running on bash < 4 can prepend bash >= 4 to path before > running the tests. Thanks for the patch, Joel! This iss

[PATCH] test: change "#!/bin/bash" to "#!/usr/bin/env bash" enhances portability

2011-05-27 Thread Carl Worth
Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527/f9cf0cd3/attachment.pgp>

Re: one-time-iterators

2011-05-27 Thread Austin Clements
On Fri, May 27, 2011 at 2:04 PM, Patrick Totzke wrote: > Excerpts from Austin Clements's message of Fri May 27 03:41:44 +0100 2011: >> >> > > Have you tried simply calling list() on your thread >> >> > > iterator to see how expensive it is?  My bet is that it's quite cheap, >> >> > > both memory-w

[PATCH] emacs: Give mutlipart/{signed, encrypted} their own part handler.

2011-05-27 Thread Jameson Graef Rollins
This is the best way to make the displayed output for decrypted/verified messages clearer. The special sigstatus and encstatus buttons are now displayed under the part header button. The part header button is also tweaked to provide information to user about how to proces crypto. --- This patch

[PATCH] emacs: User-defined sections in notmuch-hello

2011-05-27 Thread Daniel Schoepe
From the commit message: > This patch allows the user to define various sections that will > be displayed in notmuch-hello. I tried to keep the section > description flexible, so it allows different queries for the > tag buttons and the counts next to them, as well as hiding items > with zero resul

[PATCH] emacs: Give mutlipart/{signed, encrypted} their own part handler.

2011-05-27 Thread Jameson Graef Rollins
This is the best way to make the displayed output for decrypted/verified messages clearer. The special sigstatus and encstatus buttons are now displayed under the part header button. The part header button is also tweaked to provide information to user about how to proces crypto. --- This patch

Re: normalizing part numbering across PGP/MIME processing

2011-05-27 Thread Daniel Kahn Gillmor
On Fri, 27 May 2011 03:27:35 -0700, Jameson Graef Rollins wrote: > Ok. So I very much hope this patch series satisfies those who were > bothered by the part renumbering that was happening when PGP/MIME > parts were processed. For signed messages we no longer modify the > parts at all, so number

[PATCH 2/2] emacs: Cleaner interface when prompting for sender address

2011-05-27 Thread Thomas Jost
Most of the time, every entry in the list of identities has the same user name part. It can then be filled in automatically, and the user can only be prompted for the email address, which makes the interface much cleaner. --- Hi Jameson, Once again, a very good suggestion. I had doubts at first (b

[PATCH 1/2] emacs: Don't always prompt for the "From" address when replying

2011-05-27 Thread Thomas Jost
When replying, the From: address is already filled in by notmuch reply, so most of the time there is no need to prompt the user for it. --- Hi Jameson, You're right, this is mostly annoying when replying to messages. Here's a fix. Regards, Thomas emacs/notmuch-mua.el |7 +-- 1 files cha

Re: one-time-iterators

2011-05-27 Thread Patrick Totzke
Excerpts from Austin Clements's message of Fri May 27 03:41:44 +0100 2011: > >> > > Have you tried simply calling list() on your thread > >> > > iterator to see how expensive it is?  My bet is that it's quite cheap, > >> > > both memory-wise and CPU-wise. > >> > Funny thing: > >> >  q=Database().cr

one-time-iterators

2011-05-27 Thread Michael Hudson-Doyle
On Thu, 26 May 2011 10:20:21 -0700, Carl Worth wrote: > On Thu, 26 May 2011 09:31:19 +0100, Patrick Totzke googlemail.com> wrote: > > Wow. This reads really complicated. All I want to say is: > > if I change tags in my search-results view, I get Xapian errors :) > > Yes, that's frustrating. I wi

Re: [PATCH 2/2] emacs: Cleaner interface when prompting for sender address

2011-05-27 Thread Jameson Graef Rollins
On Fri, 27 May 2011 11:15:00 +0200, Thomas Jost wrote: > Once again, a very good suggestion. I had doubts at first (because I sometimes > send mails using a nickname or on behalf of a group using that group's name), > but then I noticed I already had only one name in notmuch-identities :) So > her

[PATCH 2/2] emacs: Cleaner interface when prompting for sender address

2011-05-27 Thread Jameson Graef Rollins
lt;http://notmuchmail.org/pipermail/notmuch/attachments/20110527/7eea47d9/attachment.pgp>

Re: [PATCH 1/2] emacs: Don't always prompt for the "From" address when replying

2011-05-27 Thread Jameson Graef Rollins
On Fri, 27 May 2011 11:14:59 +0200, Thomas Jost wrote: > You're right, this is mostly annoying when replying to messages. Here's a fix. Awesome. Thanks, Thomas. Tested and works great. jamie. pgpQ1DnF9hcWt.pgp Description: PGP signature ___ notmuch

[PATCH 1/2] emacs: Don't always prompt for the "From" address when replying

2011-05-27 Thread Jameson Graef Rollins
not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527/31cfbfc8/attachment-0001.pgp>

[PATCH 1/4] Do not replace multipart/signed part with content part when doing verification.

2011-05-27 Thread Jameson Graef Rollins
Some folks have complained about the part renumbering that occurs when the entire multipart/signed part is replaced with the part contents after verification. This is primarily because it incurs an additional computational cost to retrieve individual parts, since verification has to be performed a

[PATCH 2/4] Render all parts of multipart/encrypted when decrypting.

2011-05-27 Thread Jameson Graef Rollins
The primary goal here is to keep the decrypted output as similarly structured as undecrypted output as possible. Now, when decrypting parts, only the original encrypted part is replaced by the it's decrypted content. If this part isn't itself a multipart, then all part numbering should remain con

[PATCH 4/4] emacs: Give mutlipart/{signed, encrypted} their own part handler.

2011-05-27 Thread Jameson Graef Rollins
This is the best way to make the displayed output for decrypted/verified messages clearer. The special sigstatus and encstatus buttons are now displayed under the part header button. The part header button is also tweaked to provide information to user about how to proces crypto. --- emacs/notmu

[PATCH 3/4] emacs: Do not attempt to render arbitrary application parts.

2011-05-27 Thread Jameson Graef Rollins
We probably shouldn't have been doing this anyway, but we do it here specifically because we don't want the content of the application/pgp-encrypted parts to be displayed and cluttering the message show. --- emacs/notmuch-show.el |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff

normalizing part numbering across PGP/MIME processing

2011-05-27 Thread Jameson Graef Rollins
Ok. So I very much hope this patch series satisfies those who were bothered by the part renumbering that was happening when PGP/MIME parts were processed. For signed messages we no longer modify the parts at all, so numbering always remains constant, and for encrypted messages the numbering will

[PATCH 4/4] emacs: Give mutlipart/{signed, encrypted} their own part handler.

2011-05-27 Thread Jameson Graef Rollins
This is the best way to make the displayed output for decrypted/verified messages clearer. The special sigstatus and encstatus buttons are now displayed under the part header button. The part header button is also tweaked to provide information to user about how to proces crypto. --- emacs/notmu

[PATCH 3/4] emacs: Do not attempt to render arbitrary application parts.

2011-05-27 Thread Jameson Graef Rollins
We probably shouldn't have been doing this anyway, but we do it here specifically because we don't want the content of the application/pgp-encrypted parts to be displayed and cluttering the message show. --- emacs/notmuch-show.el |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff

[PATCH 2/4] Render all parts of multipart/encrypted when decrypting.

2011-05-27 Thread Jameson Graef Rollins
The primary goal here is to keep the decrypted output as similarly structured as undecrypted output as possible. Now, when decrypting parts, only the original encrypted part is replaced by the it's decrypted content. If this part isn't itself a multipart, then all part numbering should remain con

[PATCH 1/4] Do not replace multipart/signed part with content part when doing verification.

2011-05-27 Thread Jameson Graef Rollins
Some folks have complained about the part renumbering that occurs when the entire multipart/signed part is replaced with the part contents after verification. This is primarily because it incurs an additional computational cost to retrieve individual parts, since verification has to be performed a

normalizing part numbering across PGP/MIME processing

2011-05-27 Thread Jameson Graef Rollins
Ok. So I very much hope this patch series satisfies those who were bothered by the part renumbering that was happening when PGP/MIME parts were processed. For signed messages we no longer modify the parts at all, so numbering always remains constant, and for encrypted messages the numbering will

[PATCH 2/2] emacs: Cleaner interface when prompting for sender address

2011-05-27 Thread Thomas Jost
Most of the time, every entry in the list of identities has the same user name part. It can then be filled in automatically, and the user can only be prompted for the email address, which makes the interface much cleaner. --- Hi Jameson, Once again, a very good suggestion. I had doubts at first (b

[PATCH 1/2] emacs: Don't always prompt for the "From" address when replying

2011-05-27 Thread Thomas Jost
When replying, the From: address is already filled in by notmuch reply, so most of the time there is no need to prompt the user for it. --- Hi Jameson, You're right, this is mostly annoying when replying to messages. Here's a fix. Regards, Thomas emacs/notmuch-mua.el |7 +-- 1 files cha

[PATCH 2/2] Workaround for Emacs bug #8721.

2011-05-27 Thread Dmitry Kurochkin
g-8721.patch Type: text/x-diff Size: 3417 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110527/595cc12b/attachment.patch>

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-05-27 Thread Dmitry Kurochkin
On Thu, 26 May 2011 14:31:30 -0700, Carl Worth wrote: > On Thu, 26 May 2011 14:26:34 +0400, Dmitry Kurochkin gmail.com> wrote: > > It is called indirectly. What is the best way to fix it? I imagine > > that we can replace `isearch-range-invisible' function with another one, > > which would call

[PATCH 2/2] Workaround for Emacs bug #8721.

2011-05-27 Thread Dmitry Kurochkin
The patch adds `notmuch-isearch-range-invisible' function which is the same as `isearch-range-invisible' but with fixed Emacs bug `notmuch-isearch-range-invisible' instead of the original `isearch-range-invisible' when in `notmuch-show-mode'. --- emacs/notmuch-wash.el | 67 ++

[PATCH 1/2] test: add tests for hiding messages in notmuch-show view

2011-05-27 Thread Dmitry Kurochkin
--- test/emacs | 16 .../notmuch-show-thread-with-hidden-messages |3 +++ 2 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 test/emacs.expected-output/notmuch-show-thread-with-hidden-messages diff --git a/te

[PATCH v2 3/3] Emacs changes for reply to sender

2011-05-27 Thread Mark Walters
Reply to sender is currently bound to R --- emacs/notmuch-mua.el | 10 ++ emacs/notmuch-show.el |8 +++- emacs/notmuch.el |2 +- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el index 61a723b..c9c5854 100644 ---

[PATCH v2 2/3] Documentation changes for --reply-to= option to notmuch reply.

2011-05-27 Thread Mark Walters
--- notmuch.1 | 13 + notmuch.c | 10 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/notmuch.1 b/notmuch.1 index a1c7fa8..c434e77 100644 --- a/notmuch.1 +++ b/notmuch.1 @@ -388,6 +388,19 @@ Includes subject and quoted message body. .BR headers\-only On

[PATCH v2 1/3] Adds the option "--reply-to=" to notmuch reply.

2011-05-27 Thread Mark Walters
Possible values are "sender" which replies just to sender and "all" (the default). More precisely reply to sender follows these rules: reply only to sender unless it was the user reply only to all people on the to line unless they were all the user reply to all people on the cc line Implementatio

[PATCH v2 0/3] Implement reply to sender

2011-05-27 Thread Mark Walters
Many thanks for the rapid response: I have modified the patches as suggested and this version includes the necessary documentation changes. I have also modified the emacs portion to apply to current master. Best wishes Mark These patches implement a reply to sender function. On the command lin